Completed
Pull Request — master (#448)
by
unknown
08:31
created
phpmetrics/src/Hal/Metric/System/UnitTesting/UnitTesting.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         $domList = $xpath->query('//testsuite[@file]');
77 77
         if ($domList !== false) {
78 78
             foreach ($domList as $suite) {
79
-                array_push($testsuites, (object)[
79
+                array_push($testsuites, (object) [
80 80
                     'file' => $suite->getAttribute('file'),
81 81
                     'name' => $suite->getAttribute('name'),
82 82
                     'assertions' => $suite->getAttribute('assertions'),
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
                     $assertions = $case === $suite->firstChild->nextSibling ? $suite->getAttribute('assertions') : 0;
109 109
                 }
110 110
 
111
-                $testsuites[$case->getAttribute('class')] = (object)[
111
+                $testsuites[$case->getAttribute('class')] = (object) [
112 112
                     'file' => $case->getAttribute('file'),
113 113
                     'name' => $case->getAttribute('class'),
114 114
                     'assertions' => $assertions,
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
             $traverser->addVisitor(new ExternalsVisitor($metricsOfUnitTest));
129 129
 
130 130
             if (!file_exists($suite->file) || !is_readable($suite->file)) {
131
-                throw new \LogicException('Cannot find source file referenced in testsuite: ' . $suite->file);
131
+                throw new \LogicException('Cannot find source file referenced in testsuite: '.$suite->file);
132 132
             }
133 133
 
134 134
             $code = file_get_contents($suite->file);
@@ -150,10 +150,10 @@  discard block
 block discarded – undo
150 150
             if ($metric === null) {
151 151
                 throw new MetricNullException($suite->name, self::class);
152 152
             }
153
-            $externals = (array)$metric->get('externals');
153
+            $externals = (array) $metric->get('externals');
154 154
 
155 155
             // global stats for each test
156
-            $infoAboutTests[$suite->name] = (object)[
156
+            $infoAboutTests[$suite->name] = (object) [
157 157
                 'nbExternals' => count(array_unique($externals)),
158 158
                 'externals' => array_unique($externals),
159 159
                 'filename' => $suite->file,
Please login to merge, or discard this patch.
phpmetrics/src/Hal/Metric/Class_/Component/MaintainabilityIndexVisitor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
     public function leaveNode(Node $node)
49 49
     {
50 50
         if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Trait_) {
51
-            $name = (string)(isset($node->namespacedName) ? $node->namespacedName : 'anonymous@' . spl_object_hash($node));
51
+            $name = (string) (isset($node->namespacedName) ? $node->namespacedName : 'anonymous@'.spl_object_hash($node));
52 52
             $classOrFunction = $this->metrics->get($name);
53 53
             if ($classOrFunction === null) {
54 54
                 throw new MetricNullException($name, self::class);
Please login to merge, or discard this patch.
phpmetrics/src/Hal/Metric/Class_/Text/LengthVisitor.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,10 +36,10 @@  discard block
 block discarded – undo
36 36
     {
37 37
         if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Function_ || $node instanceof Stmt\Trait_) {
38 38
             if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Trait_) {
39
-                $name = (string)(isset($node->namespacedName) ? $node->namespacedName : 'anonymous@' . spl_object_hash($node));
39
+                $name = (string) (isset($node->namespacedName) ? $node->namespacedName : 'anonymous@'.spl_object_hash($node));
40 40
                 $classOrFunction = $this->metrics->get($name);
41 41
             } else {
42
-                $name = (string)$node->name;
42
+                $name = (string) $node->name;
43 43
                 $classOrFunction = new FunctionMetric($name);
44 44
                 $this->metrics->attach($classOrFunction);
45 45
             }
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
             }
76 76
 
77 77
             // count and remove single line comments
78
-            $code = preg_replace_callback('!(\'[^\']*\'|"[^"]*")|((?:#|\/\/).*$)!m', function (array $matches) use (&$cloc) {
78
+            $code = preg_replace_callback('!(\'[^\']*\'|"[^"]*")|((?:#|\/\/).*$)!m', function(array $matches) use (&$cloc) {
79 79
                 if (isset($matches[2])) {
80 80
                     $cloc += 1;
81 81
                 }
Please login to merge, or discard this patch.
phpmetrics/src/Hal/Metric/Class_/Text/HalsteadVisitor.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,10 +45,10 @@  discard block
 block discarded – undo
45 45
     {
46 46
         if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Function_ || $node instanceof Stmt\Trait_) {
47 47
             if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Trait_) {
48
-                $name = (string)(isset($node->namespacedName) ? $node->namespacedName : 'anonymous@' . spl_object_hash($node));
48
+                $name = (string) (isset($node->namespacedName) ? $node->namespacedName : 'anonymous@'.spl_object_hash($node));
49 49
                 $classOrFunction = $this->metrics->get($name);
50 50
             } else {
51
-                $name = (string)$node->name;
51
+                $name = (string) $node->name;
52 52
                 $classOrFunction = new FunctionMetric($name);
53 53
                 $this->metrics->attach($classOrFunction);
54 54
             }
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
             $operands = [];
62 62
             $operators = [];
63 63
 
64
-            iterate_over_node($node, function ($node) use (&$operators, &$operands) {
64
+            iterate_over_node($node, function($node) use (&$operators, &$operands) {
65 65
                 if ($node instanceof Node\Expr\BinaryOp
66 66
                     || $node instanceof Node\Expr\AssignOp
67 67
                     || $node instanceof Stmt\If_
Please login to merge, or discard this patch.
phpmetrics/src/Hal/Metric/Class_/Structural/LcomVisitor.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -49,17 +49,17 @@  discard block
 block discarded – undo
49 49
 
50 50
             foreach ($node->stmts as $stmt) {
51 51
                 if ($stmt instanceof Stmt\ClassMethod) {
52
-                    if (!$graph->has($stmt->name . '()')) {
53
-                        $graph->insert(new TreeNode($stmt->name . '()'));
52
+                    if (!$graph->has($stmt->name.'()')) {
53
+                        $graph->insert(new TreeNode($stmt->name.'()'));
54 54
                     }
55
-                    $from = $graph->get($stmt->name . '()');
55
+                    $from = $graph->get($stmt->name.'()');
56 56
                     if ($from === null) {
57 57
                         throw new ShouldNotHappenException('Graph $from is null');
58 58
                     }
59 59
 
60
-                    \iterate_over_node($stmt, function ($node) use ($from, &$graph) {
60
+                    \iterate_over_node($stmt, function($node) use ($from, &$graph) {
61 61
                         if ($node instanceof Node\Expr\PropertyFetch && isset($node->var->name) && $node->var->name == 'this') {
62
-                            $name = (string)getNameOfNode($node);
62
+                            $name = (string) getNameOfNode($node);
63 63
                             // use of attribute $this->xxx;
64 64
                             if (!$graph->has($name)) {
65 65
                                 $graph->insert(new TreeNode($name));
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
                             if (!$node->var instanceof Node\Expr\New_ && isset($node->var->name) && getNameOfNode($node->var) === 'this') {
77 77
                                 // use of method call $this->xxx();
78 78
                                 // use of attribute $this->xxx;
79
-                                $name = getNameOfNode($node->name) . '()';
79
+                                $name = getNameOfNode($node->name).'()';
80 80
                                 if (!$graph->has($name)) {
81 81
                                     $graph->insert(new TreeNode($name));
82 82
                                 }
Please login to merge, or discard this patch.
phpmetrics/src/Hal/Metric/Class_/Coupling/ExternalsVisitor.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -64,20 +64,20 @@  discard block
 block discarded – undo
64 64
             // extends
65 65
             if (isset($node->extends)) {
66 66
                 if (is_array($node->extends)) {
67
-                    foreach ((array)$node->extends as $interface) {
68
-                        $this->pushToDependencies($dependencies, (string)$interface);
69
-                        array_push($parents, (string)$interface);
67
+                    foreach ((array) $node->extends as $interface) {
68
+                        $this->pushToDependencies($dependencies, (string) $interface);
69
+                        array_push($parents, (string) $interface);
70 70
                     }
71 71
                 } else {
72
-                    $this->pushToDependencies($dependencies, (string)$node->extends);
73
-                    array_push($parents, (string)$node->extends);
72
+                    $this->pushToDependencies($dependencies, (string) $node->extends);
73
+                    array_push($parents, (string) $node->extends);
74 74
                 }
75 75
             }
76 76
 
77 77
             // implements
78 78
             if (isset($node->implements)) {
79 79
                 foreach ($node->implements as $interface) {
80
-                    $this->pushToDependencies($dependencies, (string)$interface);
80
+                    $this->pushToDependencies($dependencies, (string) $interface);
81 81
                 }
82 82
             }
83 83
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
                     // return
87 87
                     if (isset($stmt->returnType)) {
88 88
                         if ($stmt->returnType instanceof Node\Name\FullyQualified) {
89
-                            $this->pushToDependencies($dependencies, (string)$stmt->returnType);
89
+                            $this->pushToDependencies($dependencies, (string) $stmt->returnType);
90 90
                         }
91 91
                     }
92 92
 
@@ -94,21 +94,21 @@  discard block
 block discarded – undo
94 94
                     foreach ($stmt->params as $param) {
95 95
                         if ($param->type) {
96 96
                             if ($param->type instanceof Node\Name\FullyQualified) {
97
-                                $this->pushToDependencies($dependencies, (string)$param->type);
97
+                                $this->pushToDependencies($dependencies, (string) $param->type);
98 98
                             }
99 99
                         }
100 100
                     }
101 101
 
102 102
                     // instantiations, static calls
103
-                    \iterate_over_node($stmt, function ($node) use (&$dependencies) {
103
+                    \iterate_over_node($stmt, function($node) use (&$dependencies) {
104 104
                         switch (true) {
105 105
                             case $node instanceof Node\Expr\New_:
106 106
                                 // new MyClass
107
-                                $this->pushToDependencies($dependencies, (string)getNameOfNode($node));
107
+                                $this->pushToDependencies($dependencies, (string) getNameOfNode($node));
108 108
                                 break;
109 109
                             case $node instanceof Node\Expr\StaticCall:
110 110
                                 // MyClass::Call
111
-                                $this->pushToDependencies($dependencies, (string)getNameOfNode($node));
111
+                                $this->pushToDependencies($dependencies, (string) getNameOfNode($node));
112 112
                                 break;
113 113
                         }
114 114
                     });
@@ -119,13 +119,13 @@  discard block
 block discarded – undo
119 119
                         foreach ($matches[1] as $check) {
120 120
                             foreach ($this->uses as $use) {
121 121
                                 if (method_exists($use, 'getAlias')) {
122
-                                    if (((string)$use->getAlias()) === $check) {
123
-                                        $this->pushToDependencies($dependencies, (string)($use->name));
122
+                                    if (((string) $use->getAlias()) === $check) {
123
+                                        $this->pushToDependencies($dependencies, (string) ($use->name));
124 124
                                     }
125 125
                                     continue;
126 126
                                 }
127 127
                                 if ($use->alias === $check) {
128
-                                    $this->pushToDependencies($dependencies, (string)($use->name));
128
+                                    $this->pushToDependencies($dependencies, (string) ($use->name));
129 129
                                 }
130 130
                             }
131 131
                         }
@@ -152,6 +152,6 @@  discard block
 block discarded – undo
152 152
         if ('self' === $lowercase || 'parent' === $lowercase) {
153 153
             return;
154 154
         }
155
-        array_push($dependencies, (string)$dependency);
155
+        array_push($dependencies, (string) $dependency);
156 156
     }
157 157
 }
Please login to merge, or discard this patch.
phpmetrics/src/Hal/Metric/Class_/Complexity/KanDefectVisitor.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 
47 47
             $select = $while = $if = 0;
48 48
 
49
-            iterate_over_node($node, function ($node) use (&$while, &$select, &$if) {
49
+            iterate_over_node($node, function($node) use (&$while, &$select, &$if) {
50 50
                 switch (true) {
51 51
                     case $node instanceof Stmt\Do_:
52 52
                     case $node instanceof Stmt\Foreach_:
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
                 }
63 63
             });
64 64
 
65
-            $defect = 0.15 + 0.23 *  $while + 0.22 *  $select + 0.07 * $if;
65
+            $defect = 0.15 + 0.23 * $while + 0.22 * $select + 0.07 * $if;
66 66
             $class->set('kanDefect', round($defect, 2));
67 67
         }
68 68
 
Please login to merge, or discard this patch.
phpmetrics/src/Hal/Metric/Package/PackageDependencies.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
     /** @return void */
14 14
     public function calculate(Metrics $metrics)
15 15
     {
16
-        $classes = array_filter($metrics->all(), function (Metric $metric) {
16
+        $classes = array_filter($metrics->all(), function(Metric $metric) {
17 17
             return $metric instanceof ClassMetric || $metric instanceof InterfaceMetric;
18 18
         });
19 19
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
      */
31 31
     private function increaseDependencies(Metric $class, Metrics $metrics)
32 32
     {
33
-        if (! $class->has('package') || ! $class->has('externals')) {
33
+        if (!$class->has('package') || !$class->has('externals')) {
34 34
             return;
35 35
         }
36 36
         /** @var PackageMetric $incomingPackage */
@@ -66,6 +66,6 @@  discard block
 block discarded – undo
66 66
         }
67 67
         $parts = explode('\\', $className);
68 68
         array_pop($parts);
69
-        return implode('\\', $parts) . '\\';
69
+        return implode('\\', $parts).'\\';
70 70
     }
71 71
 }
Please login to merge, or discard this patch.
phpmetrics/src/Hal/Metric/Package/PackageAbstraction.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     public function calculate(Metrics $metrics)
13 13
     {
14 14
         foreach ($metrics->all() as $eachPackage) {
15
-            if (! $eachPackage instanceof PackageMetric) {
15
+            if (!$eachPackage instanceof PackageMetric) {
16 16
                 continue;
17 17
             }
18 18
             $abstractClassCount = 0;
Please login to merge, or discard this patch.