MaintainabilityIndexVisitorTest::testLackOfCohesionOfMethodsIsWellCalculated()

Complexity

Conditions	1
Paths	1

Size

Total Lines

42

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function testLackOfCohesionOfMethodsIsWellCalculated($ccn, $lloc, $cloc, $volume, $mIwoC, $mi, $weight)
    {
        $metrics = new Metrics();
        $prophet = $this->prophesize('Hal\Metric\ClassMetric');
        $prophet->getName()->willReturn('A');
        $prophet->get('lloc')->willReturn($lloc);
        $prophet->get('loc')->willReturn($lloc + $cloc);
        $prophet->get('ccn')->willReturn($ccn);
        $prophet->get('cloc')->willReturn($cloc);
        $prophet->get('volume')->willReturn($volume);

        // spy
        $prophet->set('mIwoC', $mIwoC)->will(function () use ($prophet) {
            return $prophet->reveal();
        })->shouldBeCalled();
        $prophet->set('mi', $mi)->will(function () use ($prophet) {
            return $prophet->reveal();
        })->shouldBeCalled();
        $prophet->set('commentWeight', $weight)->will(function () use ($prophet) {
            return $prophet->reveal();
        })->shouldBeCalled();

        $class = $prophet->reveal();
        $metrics->attach($class);

        $parser = (new ParserFactory)->create(ParserFactory::PREFER_PHP7);
        $traverser = new \PhpParser\NodeTraverser();
        $traverser->addVisitor(new \PhpParser\NodeVisitor\NameResolver());
        $traverser->addVisitor(new MaintainabilityIndexVisitor($metrics));

        $code = <<<EOT
<?php class A {
    public function foo() {

    }
}
EOT;
        $stmts = $parser->parse($code);
        $this->assertNotNull($stmts);

        $traverser->traverse($stmts);

It seems like $stmts defined by $parser->parse($code) on line 63 can also be of type null; however, PhpParser\NodeTraverser::traverse() does only seem to accept array<integer,object<PhpParser\Node>>, maybe add an additional type check?

    }