Hal\Metric\Package\PackageInstability::calculate()

Complexity

Conditions	6
Paths	9

Size

Total Lines

38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function calculate(Metrics $metrics)
    {
        /* @var $packages PackageMetric[] */
        $packages = array_filter($metrics->all(), function ($metric) {
            return $metric instanceof PackageMetric;
        });

        // Calculate instability
        $instabilitiesByPackage = [];
        foreach ($packages as $eachPackage) {
            $afferentCoupling = count($eachPackage->getIncomingClassDependencies());
            $efferentCoupling = count($eachPackage->getOutgoingClassDependencies());
            if ($afferentCoupling + $efferentCoupling !== 0) {
                $eachPackage->setInstability(
                    $efferentCoupling / ($afferentCoupling + $efferentCoupling)
                );
                $instabilitiesByPackage[$eachPackage->getName()] = $eachPackage->getInstability();

Consider using $eachPackage->name. There is an issue with getName() and APC-enabled PHP versions.

            }
        }
        // Set depending instabilities
        foreach ($packages as $eachPackage) {
            $dependentInstabilities = array_map(function ($packageName) use ($instabilitiesByPackage) {
                return isset($instabilitiesByPackage[$packageName]) ? $instabilitiesByPackage[$packageName] : null;
            }, $eachPackage->getOutgoingPackageDependencies());

            $dependentInstabilities = array_combine(
                $eachPackage->getOutgoingPackageDependencies(),
                $dependentInstabilities
            );

            if ($dependentInstabilities === false) {
                throw new ShouldNotHappenException('$dependentInstabilities is false');
            }

            $dependentInstabilities = array_filter($dependentInstabilities, 'is_float');
            $eachPackage->setDependentInstabilities($dependentInstabilities);
        }
    }
}