Test\Hal\Metric\Class_\Coupling\KanDefectVisitorTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	41
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testLackOfCohesionOfMethodsIsWellCalculated()	23	23	1
A	provideExamples()	6	6	1

<?php
namespace Test\Hal\Metric\Class_\Coupling;

use Hal\Metric\Class_\ClassEnumVisitor;
use Hal\Metric\Class_\Complexity\KanDefectVisitor;
use Hal\Metric\Metrics;
use PhpParser\ParserFactory;

/**
 * @group metric
 * @group kan
 * @group defect
 */
class KanDefectVisitorTest extends \PHPUnit\Framework\TestCase

This class seems to be duplicated in your project.

{
    /**
     * @dataProvider provideExamples
     *
     * @param string $example
     * @param string $classname
     * @param float $expected
     */
    public function testLackOfCohesionOfMethodsIsWellCalculated($example, $classname, $expected)
    {
        $metrics = new Metrics();

        $parser = (new ParserFactory)->create(ParserFactory::PREFER_PHP7);
        $traverser = new \PhpParser\NodeTraverser();
        $traverser->addVisitor(new \PhpParser\NodeVisitor\NameResolver());
        $traverser->addVisitor(new ClassEnumVisitor($metrics));
        $traverser->addVisitor(new KanDefectVisitor($metrics));

        $code = file_get_contents($example);
        $this->assertNotFalse($code);

        $stmts = $parser->parse($code);
        $this->assertNotNull($stmts);

        $traverser->traverse($stmts);

It seems like $stmts defined by $parser->parse($code) on line 36 can also be of type null; however, PhpParser\NodeTraverser::traverse() does only seem to accept array<integer,object<PhpParser\Node>>, maybe add an additional type check?

        $metric =  $metrics->get($classname);
        $this->assertNotNull($metric);

        $this->assertSame($expected, $metric->get('kanDefect'));
    }

    /** @return mixed[]*/

The doc-type mixed[]*/ could not be parsed: Expected "|" or "end of type", but got "*/" at position 7. (view supported doc-types)

    public function provideExamples()
    {
        return [
            [ __DIR__ . '/../../examples/kan1.php', 'A', .89],
        ];
    }
}