Hal\Metric\Class_\Structural\LcomVisitor

Complexity

Total Complexity

24

Size/Duplication

Total Lines	108
Duplicated Lines	25 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
D	leaveNode()	27	68	20
A	traverse()	0	13	3

<?php
namespace Hal\Metric\Class_\Structural;

use Hal\Component\Tree\GraphDeduplicated;
use Hal\Component\Tree\Node as TreeNode;
use Hal\Metric\Helper\MetricClassNameGenerator;
use Hal\Metric\MetricNullException;
use Hal\Metric\Metrics;
use Hal\ShouldNotHappenException;
use PhpParser\Node;
use PhpParser\Node\Stmt;
use PhpParser\NodeVisitorAbstract;

/**
 * Lack of cohesion of methods
 *
 * @package Hal\Metric\Class_\Coupling
 */
class LcomVisitor extends NodeVisitorAbstract
{

    /**
     * @var Metrics
     */
    private $metrics;

    /**
     * @param Metrics $metrics
     */
    public function __construct(Metrics $metrics)
    {
        $this->metrics = $metrics;
    }

    /**
     * @inheritdoc
     */
    public function leaveNode(Node $node)
    {
        if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Trait_) {
            // we build a graph of internal dependencies in class
            $graph = new GraphDeduplicated();

            $name = MetricClassNameGenerator::getName($node);
            $class = $this->metrics->get($name);
            if ($class === null) {
                throw new MetricNullException($name, self::class);
            }

            foreach ($node->stmts as $stmt) {
                if ($stmt instanceof Stmt\ClassMethod) {
                    if (!$graph->has($stmt->name . '()')) {
                        $graph->insert(new TreeNode($stmt->name . '()'));
                    }
                    $from = $graph->get($stmt->name . '()');
                    if ($from === null) {
                        throw new ShouldNotHappenException('Graph $from is null');
                    }

                    \iterate_over_node($stmt, function ($node) use ($from, &$graph) {
                        if ($node instanceof Node\Expr\PropertyFetch && isset($node->var->name) && $node->var->name == 'this') {

This code seems to be duplicated across your project.

                            $name = (string)getNameOfNode($node);
                            // use of attribute $this->xxx;
                            if (!$graph->has($name)) {
                                $graph->insert(new TreeNode($name));
                            }
                            $to = $graph->get($name);
                            if ($to === null) {
                                throw new ShouldNotHappenException('Graph $to is null');
                            }
                            $graph->addEdge($from, $to);
                            return;
                        }

                        if ($node instanceof Node\Expr\MethodCall) {
                            if (!$node->var instanceof Node\Expr\New_ && isset($node->var->name) && getNameOfNode($node->var) === 'this') {

This code seems to be duplicated across your project.

                                // use of method call $this->xxx();
                                // use of attribute $this->xxx;
                                $name = getNameOfNode($node->name) . '()';
                                if (!$graph->has($name)) {
                                    $graph->insert(new TreeNode($name));
                                }
                                $to = $graph->get($name);
                                if ($to === null) {
                                    throw new ShouldNotHappenException('Graph $to is null');
                                }
                                $graph->addEdge($from, $to);
                                return;
                            }
                        }
                    });
                }
            }

            // we count paths
            $paths = 0;
            foreach ($graph->all() as $node) {
                $paths += $this->traverse($node);
            }

            $class->set('lcom', $paths);
        }

        return null;
    }

    /**
     * Traverse node, and return 1 if node has not been visited yet
     *
     * @param TreeNode $node
     * @return int
     */
    private function traverse(TreeNode $node)
    {
        if ($node->visited) {
            return 0;
        }
        $node->visited = true;

        foreach ($node->getAdjacents() as $adjacent) {
            $this->traverse($adjacent);
        }

        return 1;
    }
}