Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 16 | class IfElseif // ccn2: 7 |
||
| 17 | { |
||
| 18 | View Code Duplication | function __invoke() |
|
| 33 | } |
||
| 34 | |||
| 73 |
Adding explicit visibility (
private,protected, orpublic) is generally recommend to communicate to other developers how, and from where this method is intended to be used.