StableAbstractionsPrinciple::getDescription() - Code Metrics - Inspection of "Merge pull request #283 from UFOMelkor/feature/pac..." - phpmetrics/PhpMetrics - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e1173d...cdf0e4 )

by Oskar

created 2018-05-08 08:37 UTC

StableAbstractionsPrinciple::getDescription() A

↳ Parent: StableAbstractionsPrinciple

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	2
nop	0
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0

<?php

namespace Hal\Violation\Package;

use Hal\Metric\Metric;
use Hal\Metric\PackageMetric;
use Hal\Violation\Violation;

class StableAbstractionsPrinciple implements Violation
{
    /** @var PackageMetric|null */
    private $metric;

    public function getName()
    {
        return 'Stable Abstractions Principle';
    }

    public function apply(Metric $metric)
    {
        if (! $metric instanceof PackageMetric) {
            return;
        }
        if (abs($metric->getDistance()) > sqrt(2)/4) {
            $this->metric = $metric;
            $metric->get('violations')->add($this);

        }
    }

    public function getLevel()
    {
        return Violation::WARNING;
    }

    public function getDescription()
    {
        $violation = $this->metric->getDistance() > 0
            ? 'instable and abstract'
            : 'stable and concrete';

        return <<<EOT
Packages should be either abstract and stable or concrete and instable.

This package is {$violation}.
EOT;
    }
}


1			<?php
2
3			namespace Hal\Violation\Package;
4
5			use Hal\Metric\Metric;
6			use Hal\Metric\PackageMetric;
7			use Hal\Violation\Violation;
8
9			class StableAbstractionsPrinciple implements Violation
10			{
11			/** @var PackageMetric\|null */
12			private $metric;
13
14			public function getName()
15			{
16			return 'Stable Abstractions Principle';
17			}
18
19			public function apply(Metric $metric)
20			{
21			if (! $metric instanceof PackageMetric) {
22			return;
23			}
24			if (abs($metric->getDistance()) > sqrt(2)/4) {
25			$this->metric = $metric;
26			$metric->get('violations')->add($this);
			0 ignored issues – show Bug introduced 2017-04-19 09:43 UTC by Report Bug Copy Issue Report The method `add` cannot be called on `$metric->get('violations')` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
27			}
28			}
29
30			public function getLevel()
31			{
32			return Violation::WARNING;
33			}
34
35			public function getDescription()
36			{
37			$violation = $this->metric->getDistance() > 0
38			? 'instable and abstract'
39			: 'stable and concrete';
40
41			return <<<EOT
42			Packages should be either abstract and stable or concrete and instable.
43
44			This package is {$violation}.
45			EOT;
46			}
47			}
48

phpmetrics / PhpMetrics

Push — master ( e1173d...cdf0e4 )

StableAbstractionsPrinciple::getDescription() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like