MissingImportTest::testRuleDoesNotApplyWithIgnoreGlobalProperty() - Code Metrics - Inspection of "Merge pull request #869 from danepowell/issue-868" - phpmd/phpmd - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 853f24...484d62 )

by Tobias van

created 2021-03-10 20:15 UTC

testRuleDoesNotApplyWithIgnoreGlobalProperty() A

↳ Parent: MissingImportTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	6
rs	10
c	0
b	0
f	0

<?php
/**
 * This file is part of PHP Mess Detector.
 *
 * Copyright (c) Manuel Pichler <[email protected]>.
 * All rights reserved.
 *
 * Licensed under BSD License
 * For full copyright and license information, please see the LICENSE file.
 * Redistributions of files must retain the above copyright notice.
 *
 * @author Manuel Pichler <[email protected]>
 * @copyright Manuel Pichler. All rights reserved.
 * @license https://opensource.org/licenses/bsd-license.php BSD License
 * @link http://phpmd.org/
 */

namespace PHPMD\Rule\CleanCode;

use PHPMD\AbstractTest;

/**
 * MissingImport Tests
 *
 * @coversDefaultClass \PHPMD\Rule\CleanCode\MissingImport
 */
class MissingImportTest extends AbstractTest
{
    /**
     * Get the rule under test.
     *
     * @return MissingImport
     */
    public function getRule()
    {
        $rule = new MissingImport();
        $rule->addProperty('ignore-global', false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        return $rule;
    }

    /**
     * Tests the rule for cases where it should apply.
     *
     * @param string $file The test file to test against.
     * @return void
     * @dataProvider getApplyingCases
     */
    public function testRuleAppliesTo($file)
    {
        $this->expectRuleHasViolationsForFile($this->getRule(), static::ONE_VIOLATION, $file);
    }

    /**
     * Tests the rule for cases where it should not apply.
     *
     * @param string $file The test file to test against.
     * @return void
     * @dataProvider getNotApplyingCases
     */
    public function testRuleDoesNotApplyTo($file)
    {
        $this->expectRuleHasViolationsForFile($this->getRule(), static::NO_VIOLATION, $file);
    }

    /**
     * Tests that it applies to a class that has fully qualified class names
     *
     * @return void
     * @covers ::apply
     * @covers ::isSelfReference
     */
    public function testRuleAppliesTwiceToClassWithNotImportedDependencies()
    {
        $rule = $this->getRule();
        $rule->setReport($this->getReportMock(2));

        $rule->apply($this->getMethod());
    }

    /**
     * Tests the rule ignores classes in global namespace with `ignore-global`.
     *
     * @param string $file The test file to test against.
     * @return void
     * @dataProvider getApplyingCases
     */
    public function testRuleDoesNotApplyWithIgnoreGlobalProperty($file)
    {
        $rule = $this->getRule();
        $rule->addProperty('ignore-global', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->expectRuleHasViolationsForFile($rule, static::NO_VIOLATION, $file);
    }
}


1			<?php
2			/**
3			* This file is part of PHP Mess Detector.
4			*
5			* Copyright (c) Manuel Pichler <[email protected]>.
6			* All rights reserved.
7			*
8			* Licensed under BSD License
9			* For full copyright and license information, please see the LICENSE file.
10			* Redistributions of files must retain the above copyright notice.
11			*
12			* @author Manuel Pichler <[email protected]>
13			* @copyright Manuel Pichler. All rights reserved.
14			* @license https://opensource.org/licenses/bsd-license.php BSD License
15			* @link http://phpmd.org/
16			*/
17
18			namespace PHPMD\Rule\CleanCode;
19
20			use PHPMD\AbstractTest;
21
22			/**
23			* MissingImport Tests
24			*
25			* @coversDefaultClass \PHPMD\Rule\CleanCode\MissingImport
26			*/
27			class MissingImportTest extends AbstractTest
28			{
29			/**
30			* Get the rule under test.
31			*
32			* @return MissingImport
33			*/
34			public function getRule()
35			{
36			$rule = new MissingImport();
37			$rule->addProperty('ignore-global', false);
			0 ignored issues – show Documentation introduced 2021-02-11 21:20 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38			return $rule;
39			}
40
41			/**
42			* Tests the rule for cases where it should apply.
43			*
44			* @param string $file The test file to test against.
45			* @return void
46			* @dataProvider getApplyingCases
47			*/
48			public function testRuleAppliesTo($file)
49			{
50			$this->expectRuleHasViolationsForFile($this->getRule(), static::ONE_VIOLATION, $file);
51			}
52
53			/**
54			* Tests the rule for cases where it should not apply.
55			*
56			* @param string $file The test file to test against.
57			* @return void
58			* @dataProvider getNotApplyingCases
59			*/
60			public function testRuleDoesNotApplyTo($file)
61			{
62			$this->expectRuleHasViolationsForFile($this->getRule(), static::NO_VIOLATION, $file);
63			}
64
65			/**
66			* Tests that it applies to a class that has fully qualified class names
67			*
68			* @return void
69			* @covers ::apply
70			* @covers ::isSelfReference
71			*/
72			public function testRuleAppliesTwiceToClassWithNotImportedDependencies()
73			{
74			$rule = $this->getRule();
75			$rule->setReport($this->getReportMock(2));
			0 ignored issues – show Bug introduced 2020-04-19 19:12 UTC by Report Bug Copy Issue Report It seems like `$this->getReportMock(2)` targeting `PHPMD\AbstractTest::getReportMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `PHPMD\AbstractRule::setReport()` does only seem to accept `object<PHPMD\Report>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
76			$rule->apply($this->getMethod());
77			}
78
79			/**
80			* Tests the rule ignores classes in global namespace with `ignore-global`.
81			*
82			* @param string $file The test file to test against.
83			* @return void
84			* @dataProvider getApplyingCases
85			*/
86			public function testRuleDoesNotApplyWithIgnoreGlobalProperty($file)
87			{
88			$rule = $this->getRule();
89			$rule->addProperty('ignore-global', true);
			0 ignored issues – show Documentation introduced 2021-02-11 21:28 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
90			$this->expectRuleHasViolationsForFile($rule, static::NO_VIOLATION, $file);
91			}
92			}
93

phpmd / phpmd

Push — master ( 853f24...484d62 )

testRuleDoesNotApplyWithIgnoreGlobalProperty() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like