phpmd / phpmd

src/test/php/PHPMD/Rule/Design/CountInLoopExpressionTest.php

<?php
/**
 * This file is part of PHP Mess Detector.
 *
 * Copyright (c) Manuel Pichler <mapi@phpmd.org>.
 * All rights reserved.
 *
 * Licensed under BSD License
 * For full copyright and license information, please see the LICENSE file.
 * Redistributions of files must retain the above copyright notice.
 *
 * @author Manuel Pichler <mapi@phpmd.org>
 * @copyright Manuel Pichler. All rights reserved.
 * @license https://opensource.org/licenses/bsd-license.php BSD License
 * @link http://phpmd.org/
 */

namespace PHPMD\Rule\Design;

use PHPMD\AbstractTest;

/**
 * Count In Loop Expression Test
 *
 * @author Kamil Szymanski <kamilszymanski@gmail.com>
 */
class CountInLoopExpressionTest extends AbstractTest
{
    /**
     * testRuleAppliesToAllTypesOfLoops
     *
     * @return void
     */
    public function testRuleAppliesToAllTypesOfLoops()
    {
        $rule = new CountInLoopExpression();
        $rule->setReport($this->getReportMock(3));

It seems like $this->getReportMock(3) targeting PHPMD\AbstractTest::getReportMock() can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, PHPMD\AbstractRule::setReport() does only seem to accept object<PHPMD\Report>, maybe add an additional type check?

        $rule->apply($this->getMethod());
    }

    /**
     * testRuleNotApplyToExpressionElsewhere
     *
     * @return void
     */
    public function testRuleNotApplyToExpressionElsewhere()
    {
        $rule = new CountInLoopExpression();
        $rule->setReport($this->getReportWithNoViolation());
        $rule->apply($this->getMethod());
    }

    /**
     * testRuleApplyToNestedLoops
     *
     * @return void
     */
    public function testRuleApplyToNestedLoops()
    {
        $rule = new CountInLoopExpression();
        $rule->setReport($this->getReportMock(8));

It seems like $this->getReportMock(8) targeting PHPMD\AbstractTest::getReportMock() can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, PHPMD\AbstractRule::setReport() does only seem to accept object<PHPMD\Report>, maybe add an additional type check?

        $rule->apply($this->getFunction());
    }

    /**
     * testMutedRuleAtClassLevel
     *
     * @return void
     */
    public function testMutedRuleAtClassLevel()
    {
        $rule = new CountInLoopExpression();
        $rule->setReport($this->getReportWithNoViolation());
        $rule->apply($this->getClass());
    }

    /**
     * testMutedRuleAtMethodLevel
     *
     * @return void
     */
    public function testMutedRuleAtMethodLevel()
    {
        $rule = new CountInLoopExpression();
        $rule->setReport($this->getReportWithNoViolation());
        $rule->apply($this->getClass());
    }
}