It seems like $createdAt->setTimezone(new DateTimeZone('UTC')) can also be of type false. However, the property $createdAt is declared as type DateTimeImmutable. Maybe add an additional type check?
Our type inference engine has found a suspicous assignment of a value to a property.
This check raises an issue when a value that can be of a mixed type is assigned to
a property that is type hinted more strictly.
For example, imagine you have a variable $accountId that can either hold an
Id object or false (if there is no account id yet). Your code now assigns that
value to the id property of an instance of the Account class. This class
holds a proper account, so the id value must no longer be false.
Either this assignment is in error or a type check should be added for that assignment.
classId{public$id;publicfunction__construct($id){$this->id=$id;}}classAccount{/** @var Id $id */public$id;}$account_id=false;if(starsAreRight()){$account_id=newId(42);}$account=newAccount();if($accountinstanceofId){$account->id=$account_id;}
Loading history...
36
}
37
38
/**
39
* {@inheritdoc}
40
*/
41
public function getEventType(): string
42
{
43
return \get_called_class();
44
}
45
46
/**
47
* Instantiate new event.
48
*
49
* @param TimeProvider $timeProvider
50
*
51
* @return mixed|self
52
*/
53
final protected static function occurred(?TimeProvider $timeProvider = null)
54
{
55
$timeProvider = $timeProvider ?? new SystemTimeProvider();
56
57
return new static($timeProvider->getCurrentTime());
58
}
59
60
/**
61
* {@inheritdoc}
62
*
63
* @return mixed|self
64
*
65
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
66
*/
67
public static function reconstitute(array $payload, \DateTimeImmutable $createdAt, array $attributes)
68
{
69
$event = new static($createdAt);
70
71
if (isset($attributes['metadata'])) {
72
$event->addMetadata($attributes['metadata']);
73
}
74
75
return $event;
76
}
77
78
/**
79
* {@inheritdoc}
80
*
81
* @return string[]
82
*/
83
final protected function getAllowedInterfaces(): array
phpgears /
event
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountIdthat can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theidproperty of an instance of theAccountclass. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.