These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
0 ignored issues
–
show
|
|||
2 | //////////////////////////////////////////////////////////////////////////////// |
||
3 | // __________ __ ________ __________ |
||
4 | // \______ \ |__ ______ / _____/ ____ _____ ______\______ \ _______ ___ |
||
5 | // | ___/ | \\____ \/ \ ____/ __ \\__ \\_ __ \ | _// _ \ \/ / |
||
6 | // | | | Y \ |_> > \_\ \ ___/ / __ \| | \/ | ( <_> > < |
||
7 | // |____| |___| / __/ \______ /\___ >____ /__| |______ /\____/__/\_ \ |
||
8 | // \/|__| \/ \/ \/ \/ \/ |
||
9 | // ----------------------------------------------------------------------------- |
||
10 | // Designed and Developed by Brad Jones <brad @="bjc.id.au" /> |
||
11 | // ----------------------------------------------------------------------------- |
||
12 | //////////////////////////////////////////////////////////////////////////////// |
||
13 | |||
14 | /* |
||
15 | * Include our local composer autoloader just in case |
||
16 | * we are called with a globally installed version of robo. |
||
17 | */ |
||
18 | require_once(__DIR__.'/vendor/autoload.php'); |
||
19 | |||
20 | class RoboFile extends Robo\Tasks |
||
0 ignored issues
–
show
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.
You can fix this by adding a namespace to your class: namespace YourVendor;
class YourClass { }
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. ![]() |
|||
21 | { |
||
22 | public function test() |
||
23 | { |
||
24 | exit |
||
0 ignored issues
–
show
The method
test() contains an exit expression.
An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an ![]() |
|||
25 | ( |
||
26 | $this->taskPHPUnit() |
||
27 | ->arg('./tests') |
||
28 | ->option('coverage-clover', './build/logs/clover.xml') |
||
29 | ->run()->getExitCode() |
||
30 | ); |
||
31 | } |
||
32 | } |
||
33 |
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.