Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace Gears\String\Methods; |
||
16 | trait FirstLast |
||
17 | { |
||
18 | /** |
||
19 | * Returns the first $n characters of the string. |
||
20 | * |
||
21 | * @param int $n Number of characters to retrieve from the start. |
||
22 | * |
||
23 | * @return static String being the first $n chars. |
||
24 | */ |
||
25 | View Code Duplication | public function first($n) |
|
42 | |||
43 | /** |
||
44 | * Returns the last $n characters of the string. |
||
45 | * |
||
46 | * @param int $n Number of characters to retrieve from the end. |
||
47 | * |
||
48 | * @return static String being the last $n chars. |
||
49 | */ |
||
50 | View Code Duplication | public function last($n) |
|
67 | } |
||
68 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.