App - Code Metrics - Inspection of "Widgets control, improve arch, refactoring, fixes" - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 069627...087cc0 )

by Mihail

created 2016-01-09 20:41 UTC

App A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	132
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	6
Bugs	2	Features	0

Metric	Value
wmc	22
c	6
b	2
f	0
lcom	1
cbo	7
dl	0
loc	132
rs	10

7 Methods

Rating	Name	Size	Complexity
A	getAll()	15	3
A	getAllByType()	11	3
A	getItem()	10	4
A	getConfigs()	10	4
A	getLocaleName()	14	3
A	checkVersion()	10	2
A	getScriptVersion()	13	3

<?php

namespace Apps\ActiveRecord;

use Ffcms\Core\Arch\ActiveModel;
use Ffcms\Core\Cache\MemoryObject;
use Ffcms\Core\Exception\SyntaxException;
use Ffcms\Core\Helper\Serialize;
use Ffcms\Core\Helper\Type\Obj;
use Ffcms\Core\Helper\Type\Str;

/**
 * Class App - active record for 'prefix_apps' table.
 * @package Apps\ActiveRecord
 * @property int $id
 */
class App extends ActiveModel
{
    /**
     * Get all objects with query caching
     * @return \Illuminate\Database\Eloquent\Collection|static
     * @throws SyntaxException
     */
    public static function getAll()
    {
        $object = MemoryObject::instance()->get('app.cache.all');
        // empty?
        if ($object === null) {
            $object = self::all();
            MemoryObject::instance()->set('app.cache.all', $object);
        }

        if ($object === null) {
            throw new SyntaxException('Application table "prefix_app" is empty!!!');
        }

        return $object;
    }

    /**
     * Get all object by defined $type with caching query in memory
     * @param $type
     * @return array|null
     * @throws SyntaxException
     */
    public static function getAllByType($type)
    {
        $response = null;
        foreach (self::getAll() as $object) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if ($object['type'] === $type) {
                $response[] = $object;
            }
        }

        return $response;
    }

    /**
     * Get single row by defined type and sys_name with query caching
     * @param string $type
     * @param string $sys_name
     * @return mixed|null
     * @throws SyntaxException
     */
    public static function getItem($type, $sys_name)
    {
        foreach (self::getAll() as $object) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if ($object['type'] === $type && $object['sys_name'] === $sys_name) {
                return $object;
            }
        }

        return null;
    }

    /**
     * Get application configs
     * @param string $type
     * @param string $name
     * @return array|null|string
     * @throws SyntaxException
     */
    public static function getConfigs($type, $name)
    {
        foreach (self::getAll() as $row) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if ($row->type === $type && $row->sys_name === $name) {
                return Serialize::decode($row->configs);
            }
        }

        return null;
    }

    /**
     * Get localized application name
     * @return string
     * @throws SyntaxException
     */
    public function getLocaleName()
    {
        if ($this->sys_name === null) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            throw new SyntaxException('Application object is not founded');
        }

        $nameObject = Serialize::decode($this->name);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $lang = \Ffcms\Core\App::$Request->getLanguage();
        $name = $nameObject[$lang];
        if (Str::likeEmpty($name)) {
            $name = $this->sys_name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return $name;
    }

    /**
     * Check if app version match db version of this app
     * @return bool
     * @throws SyntaxException
     */
    public function checkVersion()
    {
        if ($this->sys_name === null) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            throw new SyntaxException('Application object is not founded');
        }

        $scriptVersion = $this->getScriptVersion();

        return $scriptVersion === (float)$this->version;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Get extension script version if exists
     * @return bool|float
     */
    public function getScriptVersion()
    {
        $class = 'Apps\Controller\Admin\\' . $this->sys_name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if (!class_exists($class)) {
            return false;
        }

        if (!defined($class . '::VERSION')) {
            return false;
        }

        return (float)constant($class . '::VERSION');
    }

}

1			<?php
2
3			namespace Apps\ActiveRecord;
4
5			use Ffcms\Core\Arch\ActiveModel;
6			use Ffcms\Core\Cache\MemoryObject;
7			use Ffcms\Core\Exception\SyntaxException;
8			use Ffcms\Core\Helper\Serialize;
9			use Ffcms\Core\Helper\Type\Obj;
10			use Ffcms\Core\Helper\Type\Str;
11
12			/**
13			* Class App - active record for 'prefix_apps' table.
14			* @package Apps\ActiveRecord
15			* @property int $id
16			*/
17			class App extends ActiveModel
18			{
19			/**
20			* Get all objects with query caching
21			* @return \Illuminate\Database\Eloquent\Collection\|static
22			* @throws SyntaxException
23			*/
24			public static function getAll()
25			{
26			$object = MemoryObject::instance()->get('app.cache.all');
27			// empty?
28			if ($object === null) {
29			$object = self::all();
30			MemoryObject::instance()->set('app.cache.all', $object);
31			}
32
33			if ($object === null) {
34			throw new SyntaxException('Application table "prefix_app" is empty!!!');
35			}
36
37			return $object;
38			}
39
40			/**
41			* Get all object by defined $type with caching query in memory
42			* @param $type
43			* @return array\|null
44			* @throws SyntaxException
45			*/
46			public static function getAllByType($type)
47			{
48			$response = null;
49			foreach (self::getAll() as $object) {
			0 ignored issues – show Bug introduced 2016-01-05 18:19 UTC by Report Bug Copy Issue Report The expression `self::getAll()` of type `object\|array\|string\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
50			if ($object['type'] === $type) {
51			$response[] = $object;
52			}
53			}
54
55			return $response;
56			}
57
58			/**
59			* Get single row by defined type and sys_name with query caching
60			* @param string $type
61			* @param string $sys_name
62			* @return mixed\|null
63			* @throws SyntaxException
64			*/
65			public static function getItem($type, $sys_name)
66			{
67			foreach (self::getAll() as $object) {
			0 ignored issues – show Bug introduced 2016-01-05 18:19 UTC by Report Bug Copy Issue Report The expression `self::getAll()` of type `object\|array\|string\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
68			if ($object['type'] === $type && $object['sys_name'] === $sys_name) {
69			return $object;
70			}
71			}
72
73			return null;
74			}
75
76			/**
77			* Get application configs
78			* @param string $type
79			* @param string $name
80			* @return array\|null\|string
81			* @throws SyntaxException
82			*/
83			public static function getConfigs($type, $name)
84			{
85			foreach (self::getAll() as $row) {
			0 ignored issues – show Bug introduced 2016-01-05 18:19 UTC by Report Bug Copy Issue Report The expression `self::getAll()` of type `object\|array\|string\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
86			if ($row->type === $type && $row->sys_name === $name) {
87			return Serialize::decode($row->configs);
88			}
89			}
90
91			return null;
92			}
93
94			/**
95			* Get localized application name
96			* @return string
97			* @throws SyntaxException
98			*/
99			public function getLocaleName()
100			{
101			if ($this->sys_name === null) {
			0 ignored issues – show Documentation introduced 2015-11-21 16:45 UTC by Report Bug Copy Issue Report The property `sys_name` does not exist on `object<Apps\ActiveRecord\App>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
102			throw new SyntaxException('Application object is not founded');
103			}
104
105			$nameObject = Serialize::decode($this->name);
			0 ignored issues – show Documentation introduced 2015-11-21 16:45 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<Apps\ActiveRecord\App>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
106			$lang = \Ffcms\Core\App::$Request->getLanguage();
107			$name = $nameObject[$lang];
108			if (Str::likeEmpty($name)) {
109			$name = $this->sys_name;
			0 ignored issues – show Documentation introduced 2015-11-21 16:45 UTC by Report Bug Copy Issue Report The property `sys_name` does not exist on `object<Apps\ActiveRecord\App>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
110			}
111			return $name;
112			}
113
114			/**
115			* Check if app version match db version of this app
116			* @return bool
117			* @throws SyntaxException
118			*/
119			public function checkVersion()
120			{
121			if ($this->sys_name === null) {
			0 ignored issues – show Documentation introduced 2015-12-23 16:22 UTC by Report Bug Copy Issue Report The property `sys_name` does not exist on `object<Apps\ActiveRecord\App>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
122			throw new SyntaxException('Application object is not founded');
123			}
124
125			$scriptVersion = $this->getScriptVersion();
126
127			return $scriptVersion === (float)$this->version;
			0 ignored issues – show Documentation introduced 2016-01-09 20:45 UTC by Report Bug Copy Issue Report The property `version` does not exist on `object<Apps\ActiveRecord\App>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
128			}
129
130			/**
131			* Get extension script version if exists
132			* @return bool\|float
133			*/
134			public function getScriptVersion()
135			{
136			$class = 'Apps\Controller\Admin\\' . $this->sys_name;
			0 ignored issues – show Documentation introduced 2015-12-23 15:43 UTC by Report Bug Copy Issue Report The property `sys_name` does not exist on `object<Apps\ActiveRecord\App>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
137			if (!class_exists($class)) {
138			return false;
139			}
140
141			if (!defined($class . '::VERSION')) {
142			return false;
143			}
144
145			return (float)constant($class . '::VERSION');
146			}
147
148			}

phpffcms / ffcms

Push — master ( 069627...087cc0 )

App A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like