User::actionSignup() - Code Metrics - Inspection of "Typos" - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 939347...72ceee )

by Mihail

created 2016-02-20 04:42 UTC

User::actionSignup() C

↳ Parent: User

Complexity

Conditions	10
Paths	12

Size

Total Lines	56
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes	5
Bugs	2	Features	0

Metric	Value
c	5
b	2
f	0
dl	0
loc	56
rs	6.7741
cc	10
eloc	27
nc	12
nop	0

How to fix Long Method Complexity

<?php

namespace Apps\Controller\Front;

use Apps\ActiveRecord\Invite;
use Apps\ActiveRecord\UserRecovery;
use Apps\Model\Front\User\FormRecovery;
use Apps\Model\Front\User\FormRegister;
use Extend\Core\Arch\FrontAppController;
use Ffcms\Core\App;
use Apps\Model\Front\User\FormLogin;
use Ffcms\Core\Arch\View;
use Ffcms\Core\Exception\ForbiddenException;
use Ffcms\Core\Exception\NotFoundException;
use Ffcms\Core\Helper\Type\Obj;
use Ffcms\Core\Helper\Type\Str;

/**
 * Class User - standard user controller: login/signup/logout/etc
 * @package Apps\Controller\Front
 */
class User extends FrontAppController
{
    /**
     * View login form and process submit action
     * @throws ForbiddenException
     */
    public function actionLogin()
    {
        if (App::$User->isAuth()) { // always auth? get the f*ck out
            throw new ForbiddenException();
        }

        $configs = $this->getConfigs();
        // load login model
        $loginForm = new FormLogin($configs['captchaOnLogin'] === 1);

        // check if data is send and valid
        if ($loginForm->send() && $loginForm->validate()) {
            if ($loginForm->tryAuth()) {
                App::$Response->redirect('/'); // void header change & exit()
            }
            App::$Session->getFlashBag()->add('error', __('User is never exist or password is incorrect!'));
        }

        // render view
        return App::$View->render('login', [
            'model' => $loginForm->export(),
            'useCaptcha' => $configs['captchaOnLogin'] === 1
        ]);
    }

    /**
     * View register form and process submit action
     * @throws ForbiddenException
     */
    public function actionSignup()
    {
        if (App::$User->isAuth()) { // always auth? prevent any actions
            throw new ForbiddenException();
        }

        // load configs
        $configs = $this->getConfigs();

        // init register model
        $registerForm = new FormRegister($configs['captchaOnRegister'] === 1);

        // registration based on invite. Check conditions.
        if ($configs['registrationType'] === 0) {
            // get token and email
            $inviteToken = App::$Request->query->get('token');
            $inviteEmail = App::$Request->query->get('email');
            // data sounds like a invalid?
            if (Str::length($inviteToken) < 32 || !Str::isEmail($inviteEmail)) {
                throw new ForbiddenException(__('Registration allowed only if you have invite!'));
            }
            // remove oldest data
            Invite::clean();
            // try to find token
            $find = Invite::where('token', '=', $inviteToken)
                ->where('email', '=', $inviteEmail)->count();

            // token not foud? invalid invite key
            if ($find !== 1) {
                throw new ForbiddenException(__('Your invite token is invalid! Contact with administrator'));
            }
            // notify the invite token is accepted
            if (!$registerForm->send()) {
                App::$Session->getFlashBag()->add('success', __('Invite was accepted! Continue registration'));
            }

            // set email from token data
            $registerForm->email = $inviteEmail;
        }

        // if register data is send and valid
        if ($registerForm->send() && $registerForm->validate()) {
            if ($registerForm->tryRegister($configs['registrationType'] === 1)) {
                App::$Session->getFlashBag()->add('success', __('Your account is registered. You must confirm account via email'));
            } else {
                App::$Session->getFlashBag()->add('error', __('Login or email is always used on website'));
            }
        }

        // render view
        return App::$View->render('signup', [
            'model' => $registerForm->export(),
            'config' => $configs,
            'useCaptcha' => $configs['captchaOnRegister'] === 1
        ]);
    }

    /**
     * Recovery form and recovery submit action
     * @param int|null $id
     * @param string|null $token
     * @throws ForbiddenException
     * @throws NotFoundException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionRecovery($id = null, $token = null)
    {
        if (App::$User->isAuth()) { // always auth? prevent any actions
            throw new ForbiddenException();
        }

        // is recovery submit?
        if (Obj::isLikeInt($id) && Str::length($token) >= 64) {
            $rObject = UserRecovery::where('id', '=', $id)
                ->where('token', '=', $token)
                ->where('archive', '=', false);
            // check if recovery row exist
            if ($rObject->count() !== 1) {
                throw new NotFoundException('This recovery data is not found');
            }

            $rData = $rObject->first();
            // check if user with this "user_id" in recovery row exist
            $rUser = App::$User->identity($rData->user_id);
            if ($rUser === null) {
                throw new NotFoundException('User is not found');
            }

            // all is ok, lets set new pwd
            $rUser->password = $rData->password;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $rUser->save();

            $rData->archive = true;
            $rData->save();

            // add notification
            App::$Session->getFlashBag()->add('success', __('Your account are successful recovered. We recommend you change password'));

            // lets open user session with recovered data
            $loginModel = new FormLogin();
            $loginModel->openSession($rUser);
            App::$Response->redirect('/'); // session is opened, refresh page
        }

        // lets work with recovery form data
        $model = new FormRecovery();
        if ($model->send()) {
            if ($model->validate()) {
                $model->make();
                App::$Session->getFlashBag()->add('success', __('We send to you email with instruction to recovery your account'));
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render visual form content
        return App::$View->render('recovery', [
            'model' => $model
        ]);
    }

    /**
     * Make logout if user is signIn
     * @throws ForbiddenException
     */
    public function actionLogout()
    {
        if (!App::$User->isAuth()) { // not auth? what you wanna?
            throw new ForbiddenException();
        }

        // unset session data
        App::$Session->invalidate();

        // redirect to main
        App::$Response->redirect('/');
    }

    /**
     * Approve user profile via $email and $token params
     * @param $email
     * @param $token
     * @throws ForbiddenException
     */
    public function actionApprove($email, $token)
    {
        // sounds like a not valid token
        if (App::$User->isAuth() || Str::length($token) < 32 || !Str::isEmail($email)) {
            throw new ForbiddenException();
        }
        // lets find token&email
        $find = App::$User->where('approve_token', '=', $token)
            ->where('email', '=', $email);

        // not found? exit
        if ($find->count() !== 1) {
            throw new ForbiddenException();
        }

        // get row and update approve information
        $user = $find->first();
        $user->approve_token = '0';
        $user->save();

        // open session and redirect to main
        $loginModel = new FormLogin();
        $loginModel->openSession($user);
        App::$Response->redirect('/'); // session is opened, refresh page
    }
}

1			<?php
2
3			namespace Apps\Controller\Front;
4
5			use Apps\ActiveRecord\Invite;
6			use Apps\ActiveRecord\UserRecovery;
7			use Apps\Model\Front\User\FormRecovery;
8			use Apps\Model\Front\User\FormRegister;
9			use Extend\Core\Arch\FrontAppController;
10			use Ffcms\Core\App;
11			use Apps\Model\Front\User\FormLogin;
12			use Ffcms\Core\Arch\View;
13			use Ffcms\Core\Exception\ForbiddenException;
14			use Ffcms\Core\Exception\NotFoundException;
15			use Ffcms\Core\Helper\Type\Obj;
16			use Ffcms\Core\Helper\Type\Str;
17
18			/**
19			* Class User - standard user controller: login/signup/logout/etc
20			* @package Apps\Controller\Front
21			*/
22			class User extends FrontAppController
23			{
24			/**
25			* View login form and process submit action
26			* @throws ForbiddenException
27			*/
28			public function actionLogin()
29			{
30			if (App::$User->isAuth()) { // always auth? get the f*ck out
31			throw new ForbiddenException();
32			}
33
34			$configs = $this->getConfigs();
35			// load login model
36			$loginForm = new FormLogin($configs['captchaOnLogin'] === 1);
37
38			// check if data is send and valid
39			if ($loginForm->send() && $loginForm->validate()) {
40			if ($loginForm->tryAuth()) {
41			App::$Response->redirect('/'); // void header change & exit()
42			}
43			App::$Session->getFlashBag()->add('error', __('User is never exist or password is incorrect!'));
44			}
45
46			// render view
47			return App::$View->render('login', [
48			'model' => $loginForm->export(),
49			'useCaptcha' => $configs['captchaOnLogin'] === 1
50			]);
51			}
52
53			/**
54			* View register form and process submit action
55			* @throws ForbiddenException
56			*/
57			public function actionSignup()
58			{
59			if (App::$User->isAuth()) { // always auth? prevent any actions
60			throw new ForbiddenException();
61			}
62
63			// load configs
64			$configs = $this->getConfigs();
65
66			// init register model
67			$registerForm = new FormRegister($configs['captchaOnRegister'] === 1);
68
69			// registration based on invite. Check conditions.
70			if ($configs['registrationType'] === 0) {
71			// get token and email
72			$inviteToken = App::$Request->query->get('token');
73			$inviteEmail = App::$Request->query->get('email');
74			// data sounds like a invalid?
75			if (Str::length($inviteToken) < 32 \|\| !Str::isEmail($inviteEmail)) {
76			throw new ForbiddenException(__('Registration allowed only if you have invite!'));
77			}
78			// remove oldest data
79			Invite::clean();
80			// try to find token
81			$find = Invite::where('token', '=', $inviteToken)
82			->where('email', '=', $inviteEmail)->count();
83
84			// token not foud? invalid invite key
85			if ($find !== 1) {
86			throw new ForbiddenException(__('Your invite token is invalid! Contact with administrator'));
87			}
88			// notify the invite token is accepted
89			if (!$registerForm->send()) {
90			App::$Session->getFlashBag()->add('success', __('Invite was accepted! Continue registration'));
91			}
92
93			// set email from token data
94			$registerForm->email = $inviteEmail;
95			}
96
97			// if register data is send and valid
98			if ($registerForm->send() && $registerForm->validate()) {
99			if ($registerForm->tryRegister($configs['registrationType'] === 1)) {
100			App::$Session->getFlashBag()->add('success', __('Your account is registered. You must confirm account via email'));
101			} else {
102			App::$Session->getFlashBag()->add('error', __('Login or email is always used on website'));
103			}
104			}
105
106			// render view
107			return App::$View->render('signup', [
108			'model' => $registerForm->export(),
109			'config' => $configs,
110			'useCaptcha' => $configs['captchaOnRegister'] === 1
111			]);
112			}
113
114			/**
115			* Recovery form and recovery submit action
116			* @param int\|null $id
117			* @param string\|null $token
118			* @throws ForbiddenException
119			* @throws NotFoundException
120			* @throws \Ffcms\Core\Exception\SyntaxException
121			*/
122			public function actionRecovery($id = null, $token = null)
123			{
124			if (App::$User->isAuth()) { // always auth? prevent any actions
125			throw new ForbiddenException();
126			}
127
128			// is recovery submit?
129			if (Obj::isLikeInt($id) && Str::length($token) >= 64) {
130			$rObject = UserRecovery::where('id', '=', $id)
131			->where('token', '=', $token)
132			->where('archive', '=', false);
133			// check if recovery row exist
134			if ($rObject->count() !== 1) {
135			throw new NotFoundException('This recovery data is not found');
136			}
137
138			$rData = $rObject->first();
139			// check if user with this "user_id" in recovery row exist
140			$rUser = App::$User->identity($rData->user_id);
141			if ($rUser === null) {
142			throw new NotFoundException('User is not found');
143			}
144
145			// all is ok, lets set new pwd
146			$rUser->password = $rData->password;
			0 ignored issues – show Bug introduced 2015-11-21 16:45 UTC by Report Bug Copy Issue Report Accessing `password` on the interface `Ffcms\Core\Interfaces\iUser` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
147			$rUser->save();
148
149			$rData->archive = true;
150			$rData->save();
151
152			// add notification
153			App::$Session->getFlashBag()->add('success', __('Your account are successful recovered. We recommend you change password'));
154
155			// lets open user session with recovered data
156			$loginModel = new FormLogin();
157			$loginModel->openSession($rUser);
158			App::$Response->redirect('/'); // session is opened, refresh page
159			}
160
161			// lets work with recovery form data
162			$model = new FormRecovery();
163			if ($model->send()) {
164			if ($model->validate()) {
165			$model->make();
166			App::$Session->getFlashBag()->add('success', __('We send to you email with instruction to recovery your account'));
167			} else {
168			App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
169			}
170			}
171
172			// render visual form content
173			return App::$View->render('recovery', [
174			'model' => $model
175			]);
176			}
177
178			/**
179			* Make logout if user is signIn
180			* @throws ForbiddenException
181			*/
182			public function actionLogout()
183			{
184			if (!App::$User->isAuth()) { // not auth? what you wanna?
185			throw new ForbiddenException();
186			}
187
188			// unset session data
189			App::$Session->invalidate();
190
191			// redirect to main
192			App::$Response->redirect('/');
193			}
194
195			/**
196			* Approve user profile via $email and $token params
197			* @param $email
198			* @param $token
199			* @throws ForbiddenException
200			*/
201			public function actionApprove($email, $token)
202			{
203			// sounds like a not valid token
204			if (App::$User->isAuth() \|\| Str::length($token) < 32 \|\| !Str::isEmail($email)) {
205			throw new ForbiddenException();
206			}
207			// lets find token&email
208			$find = App::$User->where('approve_token', '=', $token)
209			->where('email', '=', $email);
210
211			// not found? exit
212			if ($find->count() !== 1) {
213			throw new ForbiddenException();
214			}
215
216			// get row and update approve information
217			$user = $find->first();
218			$user->approve_token = '0';
219			$user->save();
220
221			// open session and redirect to main
222			$loginModel = new FormLogin();
223			$loginModel->openSession($user);
224			App::$Response->redirect('/'); // session is opened, refresh page
225			}
226			}

phpffcms / ffcms

Push — master ( 939347...72ceee )

User::actionSignup() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like