Apps\Model\Front\User\FormRecovery

Complexity

Total Complexity

9

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	17

Importance

Changes	3
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	labels()	0	7	1
A	rules()	0	9	1
B	make()	0	59	7

<?php

namespace Apps\Model\Front\User;

use Apps\ActiveRecord\UserRecovery;
use Ffcms\Core\App;
use Ffcms\Core\Arch\Model;
use Ffcms\Core\Exception\SyntaxException;
use Ffcms\Core\Helper\Date;
use Ffcms\Core\Helper\Type\Str;
use Apps\ActiveRecord\UserLog;

class FormRecovery extends Model
{
    const DELAY = 900; // delay between 2 recovery submits

    public $email;
    public $captcha;

    /**
    * Labels
    */
    public function labels()
    {
        return [
            'email' => __('Email'),
            'captcha' => __('Captcha')
        ];
    }

    /**
    * Validation rules
    */
    public function rules()
    {
        return [
            [['email', 'captcha'], 'required'],
            ['email', 'email'],
            ['captcha', 'App::$Captcha::validate'],
            ['email', 'App::$User::isMailExist']
        ];
    }

    /**
     * After validation generate new pwd, recovery token and send email
     * @throws SyntaxException
     */
    public function make()
    {
        $user = App::$User->getIdentityViaEmail($this->email);
        if ($user === null) {
            throw new SyntaxException('Email not found');
        }
        if ($user->approve_token !== '0' && Str::length($user->approve_token) > 0) {

Accessing approve_token on the interface Ffcms\Core\Interfaces\iUser suggest that you code against a concrete implementation. How about adding an instanceof check?

            throw new SyntaxException('You must approve your account');
        }

        $rows = UserRecovery::where('user_id', '=', $user->getId())
            ->orderBy('id', 'DESC')
            ->first();

        if ($rows !== null && $rows !== false) {
            // prevent spam of recovery messages
            if (Date::convertToTimestamp($rows->created_at) > time() - self::DELAY) {
                return;
            }
        }

        // generate pwd, token and pwdCrypt
        $newPwd = Str::randomLatinNumeric(mt_rand(8, 16));
        $pwdCrypt = App::$Security->password_hash($newPwd);
        $token = Str::randomLatinNumeric(mt_rand(64, 128));

        // write new data to recovery table
        $rObject = new UserRecovery();
        $rObject->user_id = $user->id;

Accessing id on the interface Ffcms\Core\Interfaces\iUser suggest that you code against a concrete implementation. How about adding an instanceof check?

        $rObject->password = $pwdCrypt;
        $rObject->token = $token;
        $rObject->save();

        // write logs data
        $log = new UserLog();
        $log->user_id = $user->id;

The property user_id does not exist on object<Apps\ActiveRecord\UserLog>. Since you implemented __set, maybe consider adding a @property annotation.

Accessing id on the interface Ffcms\Core\Interfaces\iUser suggest that you code against a concrete implementation. How about adding an instanceof check?

        $log->type = 'RECOVERY';

The property type does not exist on object<Apps\ActiveRecord\UserLog>. Since you implemented __set, maybe consider adding a @property annotation.

        $log->message = __('Password recovery is initialized from: %ip%', ['ip' => App::$Request->getClientIp()]);

The property message does not exist on object<Apps\ActiveRecord\UserLog>. Since you implemented __set, maybe consider adding a @property annotation.

        $log->save();

        // generate mail template
        $mailTemplate = App::$View->render('user/mail/recovery', [
            'login' => $user->login,

Accessing login on the interface Ffcms\Core\Interfaces\iUser suggest that you code against a concrete implementation. How about adding an instanceof check?

            'email' => $this->email,
            'password' => $newPwd,
            'token' => $token,
            'id' => $rObject->id
        ]);

        $sender = App::$Properties->get('adminEmail');

        // format SWIFTMailer format
        $mailMessage = \Swift_Message::newInstance(App::$Translate->get('Profile', 'Account recovery on %site%', ['site' => App::$Request->getHost()]))
            ->setFrom([$sender])
            ->setTo([$this->email])
            ->setBody($mailTemplate, 'text/html');
        // send message
        App::$Mailer->send($mailMessage);

$mailMessage is of type object<Swift_Mime_MimePart>, but the function expects a object<Swift_Mime_Message>.

    }
}