Sitemap::actionIndex() - Code Metrics - Inspection of "Sitemap builder [1/2]. Build url without request" - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ef4849...3d6fe1 )

by Mihail

created 2016-07-05 08:14 UTC

Sitemap::actionIndex() A

↳ Parent: Sitemap

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	7
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	17
rs	9.4285

<?php

namespace Apps\Controller\Front;

use Apps\Model\Front\Sitemap\EntityIndexList;
use Extend\Core\Arch\FrontAppController;
use Ffcms\Core\App;

/**
 * Class Sitemap. Display sitemap for search engines in xml format.
 * @package Apps\Controller\Front
 */
class Sitemap extends FrontAppController
{
    const EVENT_SITEMAP_LIST = 'sitemap.index';

    /**
     * Before run: set xml header and disable global html layout
     */
    public function before()
    {
        $this->layout = null;
        App::$Response->headers->set('Content-type', 'text/xml');
    }

    /**
     * List available sitemap index links
     * @return string
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionIndex()
    {
        // initialize model - scan available sitemap indexes
        $model = new EntityIndexList(App::$Request->getLanguage());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        // run event - allow add any other sitemap indexes in model before render it
        App::$Event->run(static::EVENT_SITEMAP_LIST, [
            'model' => $model
        ]);

        // build information about files
        $model->make();

        return App::$View->render('index', [
            'model' => $model
        ]);
    }
}

1			<?php
2
3			namespace Apps\Controller\Front;
4
5			use Apps\Model\Front\Sitemap\EntityIndexList;
6			use Extend\Core\Arch\FrontAppController;
7			use Ffcms\Core\App;
8
9			/**
10			* Class Sitemap. Display sitemap for search engines in xml format.
11			* @package Apps\Controller\Front
12			*/
13			class Sitemap extends FrontAppController
14			{
15			const EVENT_SITEMAP_LIST = 'sitemap.index';
16
17			/**
18			* Before run: set xml header and disable global html layout
19			*/
20			public function before()
21			{
22			$this->layout = null;
23			App::$Response->headers->set('Content-type', 'text/xml');
24			}
25
26			/**
27			* List available sitemap index links
28			* @return string
29			* @throws \Ffcms\Core\Exception\NativeException
30			* @throws \Ffcms\Core\Exception\SyntaxException
31			*/
32			public function actionIndex()
33			{
34			// initialize model - scan available sitemap indexes
35			$model = new EntityIndexList(App::$Request->getLanguage());
			0 ignored issues – show Documentation introduced 2016-07-05 08:19 UTC by Report Bug Copy Issue Report `\Ffcms\Core\App::$Request->getLanguage()` is of type `string\|null`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36
37			// run event - allow add any other sitemap indexes in model before render it
38			App::$Event->run(static::EVENT_SITEMAP_LIST, [
39			'model' => $model
40			]);
41
42			// build information about files
43			$model->make();
44
45			return App::$View->render('index', [
46			'model' => $model
47			]);
48			}
49			}

phpffcms / ffcms

Push — master ( ef4849...3d6fe1 )

Sitemap::actionIndex() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like