Apps\Controller\Admin\Comments\ActionSettings::settings()

Complexity

Conditions	3
Paths	3

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function settings()
    {
        // initialize settings model
        $model = new FormSettings($this->getConfigs());

It seems like getConfigs() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        // check if form is send
        if ($model->send()) {
            if ($model->validate()) {
                $this->setConfigs($model->getAllProperties());

Are you sure the usage of $model->getAllProperties() targeting Ffcms\Core\Arch\Model::getAllProperties() seems to always return null.

It seems like setConfigs() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                App::$Session->getFlashBag()->add('success', __('Settings is successful updated'));
                $this->response->redirect('comments/index');
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render view
        return $this->view->render('comments/settings', [
            'model' => $model
        ]);
}