Apps\Model\Front\Feedback\FormAnswerAdd

Complexity

Total Complexity

10

Size/Duplication

Total Lines	95
Duplicated Lines	17.89 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes	2
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	before()	0	9	2
A	labels()	8	8	1
A	rules()	9	9	1
B	make()	0	30	5

<?php

namespace Apps\Model\Front\Feedback;

use Apps\ActiveRecord\FeedbackAnswer;
use Apps\Model\Front\Profile\EntityAddNotification;
use Ffcms\Core\App;
use Ffcms\Core\Arch\Model;
use Ffcms\Core\Helper\Text;

/**
 * Class FormAnswerAdd. Model to work with add answer to feedback post thread
 * @package Apps\Model\Front\Feedback
 */
class FormAnswerAdd extends Model
{
    public $name;
    public $email;
    public $message;

    /** @var \Apps\ActiveRecord\FeedbackPost $_post */
    protected $_post;
    protected $_userId;
    protected $_ip;

    /**
     * FormAnswerAdd constructor. Pass active record of comment post and user id
     * @param $recordPost
     * @param int $userId
     */
    public function __construct($recordPost, $userId = 0)
    {
        $this->_post = $recordPost;
        $this->_userId = (int)$userId;
        parent::__construct();
    }

    /**
     * Define local properties if user is authorized
     */
    public function before()
    {
        if ($this->_userId > 0) {
            $user = App::$User->identity($this->_userId);
            $this->name = $user->getProfile()->nick;
            $this->email = $user->getParam('email');
        }
        $this->_ip = App::$Request->getClientIp();
    }

    /**
    * Labels for display form
    */
    public function labels()

This method seems to be duplicated in your project.

    {
        return [
            'name' => __('Name'),
            'email' => __('Email'),
            'message' => __('Message')
        ];
    }

    /**
    * Form validation rules
    */
    public function rules()

This method seems to be duplicated in your project.

    {
        return [
            [['name', 'email', 'message'], 'required'],
            ['name', 'length_min', 2],
            ['email', 'email'],
            ['message', 'length_min', 10]
        ];
    }

    /**
     * Add new row to database and set post is unreaded
     */
    public function make()
    {
        // update readed marker
        $this->_post->readed = 0;
        $this->_post->save();

        // add new answer row in database
        $record = new FeedbackAnswer();
        $record->feedback_id = $this->_post->id;
        $record->name = App::$Security->strip_tags($this->name);
        $record->email = App::$Security->strip_tags($this->email);
        $record->message = App::$Security->strip_tags($this->message);
        if ($this->_userId > 0) {
            $record->user_id = $this->_userId;
        }
        $record->ip = $this->_ip;
        $record->save();

        // add notification msg
        $targetId = $this->_post->user_id;
        if ($targetId !== null && (int)$targetId > 0 && $targetId !== $this->_userId) {
            $notify = new EntityAddNotification($targetId);

$targetId is of type integer, but the function expects a boolean.

            $uri = '/feedback/read/' . $this->_post->id . '/' . $this->_post->hash . '#feedback-answer-' . $record->id;
            $notify->add($uri,  EntityAddNotification::MSG_ADD_FEEDBACKANSWER, [
                'snippet' => Text::snippet(App::$Security->strip_tags($this->message), 50),

It seems like \Ffcms\Core\App::$Security->strip_tags($this->message) targeting Ffcms\Core\Helper\Security::strip_tags() can also be of type array; however, Ffcms\Core\Helper\Text::snippet() does only seem to accept string, maybe add an additional type check?

                'post' => Text::snippet(App::$Security->strip_tags($this->_post->message), 50)

It seems like \Ffcms\Core\App::$Security->strip_tags($this->_post->message) targeting Ffcms\Core\Helper\Security::strip_tags() can also be of type array; however, Ffcms\Core\Helper\Text::snippet() does only seem to accept string, maybe add an additional type check?

            ]);
        }

    }
}