ActionTurn::turn() - Code Metrics - Inspection of "Refactoring for heave actions in controllers" - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 81f334...c86e8c )

by Mihail

created 2018-01-13 21:00 UTC

ActionTurn::turn() C

↳ Parent: ActionTurn

Complexity

Conditions	7
Paths	6

Size

Total Lines	36
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	24
nc	6
nop	2
dl	0
loc	36
rs	6.7272
c	0
b	0
f	0

<?php

namespace Apps\Controller\Admin\Feedback;

use Apps\ActiveRecord\FeedbackPost;
use Ffcms\Core\App;
use Ffcms\Core\Exception\NotFoundException;
use Ffcms\Core\Helper\Type\Any;
use Ffcms\Core\Network\Request;
use Ffcms\Core\Network\Response;

/**
 * Trait ActionTurn
 * @package Apps\Controller\Admin\Feedback
 * @property Request $request
 * @property Response $response
 */
trait ActionTurn
{
    /**
     * Turn feedback request post - close, open, readed
     * @param string $direction
     * @param string $id
     * @return void
     * @throws NotFoundException
     */
    public function turn(string $direction, string $id): void
    {
        if (!Any::isInt($id) || $id < 1) {
            throw new NotFoundException('Bad is format');
        }
        // try to find record
        $record = FeedbackPost::find($id);
        if (!$record) {
            throw new NotFoundException(__('Feedback request with id %id% is not found', ['id' => $id]));
        }

        // switch operation direction to what we must change
        switch ($direction) {
            case 'open':
                $record->closed = 0;
                $record->save();
                break;
            case 'close':
                $record->closed = 1;
                $record->save();
                break;
            case 'read':
                $record->readed = 1;
                $record->save();
                break;
            default:
                throw new NotFoundException(__('Hack attention'));
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }

        // add notification of successful changes
        App::$Session->getFlashBag()->add('success', __('Feedback request is changed!'));

        // redirect to feedback post read
        $this->response->redirect('feedback/read/' . $id);
    }
}


1			<?php
2
3			namespace Apps\Controller\Admin\Feedback;
4
5			use Apps\ActiveRecord\FeedbackPost;
6			use Ffcms\Core\App;
7			use Ffcms\Core\Exception\NotFoundException;
8			use Ffcms\Core\Helper\Type\Any;
9			use Ffcms\Core\Network\Request;
10			use Ffcms\Core\Network\Response;
11
12			/**
13			* Trait ActionTurn
14			* @package Apps\Controller\Admin\Feedback
15			* @property Request $request
16			* @property Response $response
17			*/
18			trait ActionTurn
19			{
20			/**
21			* Turn feedback request post - close, open, readed
22			* @param string $direction
23			* @param string $id
24			* @return void
25			* @throws NotFoundException
26			*/
27			public function turn(string $direction, string $id): void
28			{
29			if (!Any::isInt($id) \|\| $id < 1) {
30			throw new NotFoundException('Bad is format');
31			}
32			// try to find record
33			$record = FeedbackPost::find($id);
34			if (!$record) {
35			throw new NotFoundException(__('Feedback request with id %id% is not found', ['id' => $id]));
36			}
37
38			// switch operation direction to what we must change
39			switch ($direction) {
40			case 'open':
41			$record->closed = 0;
42			$record->save();
43			break;
44			case 'close':
45			$record->closed = 1;
46			$record->save();
47			break;
48			case 'read':
49			$record->readed = 1;
50			$record->save();
51			break;
52			default:
53			throw new NotFoundException(__('Hack attention'));
54			break;
			0 ignored issues – show Unused Code introduced 2016-02-19 13:03 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
55			}
56
57			// add notification of successful changes
58			App::$Session->getFlashBag()->add('success', __('Feedback request is changed!'));
59
60			// redirect to feedback post read
61			$this->response->redirect('feedback/read/' . $id);
62			}
63			}
64

phpffcms / ffcms

Push — master ( 81f334...c86e8c )

ActionTurn::turn() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like