FormContentUpdate::save() - Code Metrics - Inspection of "Rework template engine - templex & plates" - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( a29a7e...12a432 )

by Mihail
created 2018-03-25 17:03 UTC
FormContentUpdate::save() C

↳ Parent: FormContentUpdate
Complexity

Conditions	11
Paths	128
Size

Total Lines	64
Code Lines	36
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	11
eloc	36
nc	128
nop	0
dl	0
loc	64
rs	5.6302
c	0
b	0
f	0
How to fix Long Method Complexity

<?php

namespace Apps\Model\Admin\Content;

use Apps\ActiveRecord\Content;
use Apps\ActiveRecord\ContentCategory;
use Apps\ActiveRecord\ContentTag;
use Ffcms\Core\App;
use Ffcms\Core\Arch\Model;
use Ffcms\Core\Helper\Date;
use Ffcms\Core\Helper\FileSystem\Directory;
use Ffcms\Core\Helper\FileSystem\File;
use Ffcms\Core\Helper\Type\Any;
use Ffcms\Core\Helper\Type\Obj;
use Ffcms\Core\Helper\Type\Str;

/**
 * Class FormContentUpdate. Create and update content items business model
 * @package Apps\Model\Admin\Content
 */
class FormContentUpdate extends Model
{
    public $title = [];
    public $text = [];
    public $path;
    public $poster;
    public $categoryId;
    public $authorId;
    public $metaTitle;
    public $metaKeywords = [];
    public $metaDescription = [];
    public $display = '1';
    public $source;
    public $addRating = 0;
    public $createdAt;
    public $important;

    public $galleryFreeId;

    private $_content;
    private $_new = false;

    /**
     * FormContentUpdate constructor. Pass content active record inside
     * @param Content $content
     */
    public function __construct(Content $content)
    {
        $this->_content = $content;
        parent::__construct();
    }

    /**
     * Set model properties from active record data
     */
    public function before()
    {
        // is new item?
        if ($this->_content->id === null) {
            $this->_new = true;
            if (!$this->galleryFreeId) {
                $this->galleryFreeId = '_tmp_' . Str::randomLatin(mt_rand(16, 32));
            }

            if (!$this->authorId) {
                $this->authorId = App::$User->identity()->getId();
            }

            if (!$this->categoryId) {
                $this->categoryId = 1;
            }
        } else { // is edit of exist item? define available data
            $this->title = $this->_content->title;
            $this->text = $this->_content->text;
            $this->path = $this->_content->path;
            $this->poster = $this->_content->poster;
            $this->categoryId = $this->_content->category_id;
            $this->authorId = $this->_content->author_id;
            $this->metaTitle = $this->_content->meta_title;
            $this->metaKeywords = $this->_content->meta_keywords;
            $this->metaDescription = $this->_content->meta_description;
            $this->display = $this->_content->display;
            $this->source = $this->_content->source;
            $this->createdAt = Date::convertToDatetime($this->_content->created_at, Date::FORMAT_TO_HOUR);
            $this->galleryFreeId = $this->_content->id;
            $this->important = $this->_content->important;
        }
    }

    /**
     * Validation rules
     * @return array
     */
    public function rules(): array
    {
        $res = [
            ['title.' . App::$Request->getLanguage(), 'required'],
            ['text.' . App::$Request->getLanguage(), 'required'],
            ['text', 'used'],
            ['path', 'reverse_match', '/[\/\'~`\!@#\$%\^&\*\(\)+=\{\}\[\]\|;:"\<\>,\?\\\]/'],
            [['path', 'categoryId', 'authorId', 'display', 'galleryFreeId', 'title', 'important'], 'required'],
            [['metaTitle', 'metaKeywords', 'metaDescription', 'poster', 'source', 'addRating', 'createdAt'], 'used'],
            [['addRating', 'authorId', 'display'], 'int'],
            [['important', 'display'], 'in', [0, 1]],
            ['categoryId', 'in', $this->categoryIds()],
            ['path', '\Apps\Model\Admin\Content\FormContentUpdate::validatePath'],
            ['authorId', '\App::$User::isExist']
        ];

        foreach (App::$Properties->get('languages') as $lang) {
            $res[] = ['title.' . $lang, 'length_max', 120, null, true, true];
            $res[] = ['keywords.' . $lang, 'length_max', 150];
            $res[] = ['description.' . $lang, 'length_max', 250];
        }

        return $res;
    }

    /**
     * Filtering attribute types
     * @return array
     */
    public function types(): array
    {
        return [
            'text' => '!secure'
        ];
    }

    /**
     * Form display labels
     * @return array
     */
    public function labels(): array
    {
        return [
            'title' => __('Content title'),
            'text' => __('Content text'),
            'path' => __('Path slug'),
            'categoryId' => __('Category'),
            'metaTitle' => __('Meta title'),
            'metaKeywords' => __('Meta keywords'),
            'metaDescription' => __('Meta description'),
            'display' => __('Public display'),
            'important' => __('Make important'),
            'createdAt' => __('Publish date'),
            'authorId' => __('Author identity'),
            'source' => __('Source URL'),
            'addRating' => __('Change rating'),
            'poster' => __('Poster')
        ];
    }

    /**
     * Save changes in database
     */
    public function save()
    {
        $this->_content->title = $this->title;
        $this->_content->text = $this->text;
        $this->_content->path = $this->path;
        $this->_content->category_id = $this->categoryId;
        $this->_content->author_id = $this->authorId;
        $this->_content->display = $this->display;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->_content->meta_title = $this->metaTitle;
        $this->_content->meta_keywords = $this->metaKeywords;
        $this->_content->meta_description = $this->metaDescription;
        $this->_content->source = $this->source;
        $this->_content->important = (int)$this->important;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        // check if rating is changed
        if ((int)$this->addRating !== 0) {
            $this->_content->rating += (int)$this->addRating;
        }
        // check if special comment hash is exist
        if ($this->_new || Str::length($this->_content->comment_hash) < 32) {
            $this->_content->comment_hash = $this->generateCommentHash();
        }

        // check if date is updated
        if (!Str::likeEmpty($this->createdAt) && !Str::startsWith('0000', Date::convertToDatetime($this->createdAt, Date::FORMAT_SQL_TIMESTAMP))) {
        if (!Str::likeEmpty($this->createdAt) && !Str::startsWith('0000', /** @scrutinizer ignore-type */ Date::convertToDatetime($this->createdAt, Date::FORMAT_SQL_TIMESTAMP))) {
            $this->_content->created_at = Date::convertToDatetime($this->createdAt, Date::FORMAT_SQL_TIMESTAMP);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }

        // save poster data
        $posterPath = '/upload/gallery/' . $this->galleryFreeId . '/orig/' . $this->poster;
        if (File::exist($posterPath)) {
            $this->_content->poster = $this->poster;
        }

        // get temporary gallery id
        $tmpGalleryId = $this->galleryFreeId;

        // save row
        $this->_content->save();
        
        // update tags data in special table (relation: content->content_tags = oneToMany)
        ContentTag::where('content_id', '=', $this->_content->id)->delete();
        $insertData = [];
        foreach ($this->metaKeywords as $lang => $keys) {
            // split keywords to tag array
            $tags = explode(',', $keys);
            foreach ($tags as $tag) {
                // cleanup tag from white spaces
                $tag = trim($tag);
                // prepare data to insert
                if (Str::length($tag) > 0) {
                    $insertData[] = [
                        'content_id' => $this->_content->id,
                        'lang' => $lang,
                        'tag' => $tag
                    ];
                }
            }
        }
        // insert tags
        ContentTag::insert($insertData);

        // move files
        if ($tmpGalleryId !== $this->_content->id) {
            Directory::rename('/upload/gallery/' . $tmpGalleryId, $this->_content->id);
        }
    }

    /**
     * Get allowed category ids as array
     * @return array
     */
    public function categoryIds()
    {
        $data = ContentCategory::getSortedCategories();
        return array_keys($data);
    }

    /**
     * Validate path filter
     * @return bool
     */
    public function validatePath()
    {
        // try to find this item
        $find = Content::where('path', '=', $this->path);
        // exclude self id
        if ($this->_content->id !== null && Any::isInt($this->_content->id)) {
            $find->where('id', '!=', $this->_content->id);
        }

        // limit only current category id
        $find->where('category_id', '=', $this->categoryId);

        return $find->count() < 1;
    }

    /**
     * Generate random string for comment hash value
     * @return string
     */
    private function generateCommentHash()
    {
        $hash = Str::randomLatinNumeric(mt_rand(32, 128));
        $find = Content::where('comment_hash', '=', $hash)->count();
        // hmmm, is always exist? Chance of it is TOOOO low, but lets recursion re-generate
        if ($find !== 0) {
            return $this->generateCommentHash();
        }

        return $hash;
    }
}

phpffcms / ffcms

Push — master ( a29a7e...12a432 )

FormContentUpdate::save() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
