Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 9 | class install_feedbackpost_table extends Migration implements MigrationInterface |
||
| 10 | { |
||
| 11 | /** |
||
| 12 | * Execute actions when migration is up |
||
| 13 | * @return void |
||
| 14 | */ |
||
| 15 | public function up() |
||
| 16 | { |
||
| 17 | $this->getSchema()->create('feedback_posts', function($table) { |
||
| 18 | $table->increments('id'); |
||
| 19 | $table->string('name', 100); |
||
| 20 | $table->string('email'); |
||
| 21 | $table->text('message'); |
||
| 22 | $table->boolean('readed')->default(false); |
||
| 23 | $table->boolean('closed')->default(false); |
||
| 24 | $table->string('hash', 128); |
||
| 25 | $table->integer('user_id')->unsigned()->default(0); |
||
| 26 | $table->string('ip', 64)->default('127.0.0.1'); // ipv6 & ipv4 |
||
| 27 | $table->timestamps(); |
||
| 28 | }); |
||
| 29 | parent::up(); |
||
| 30 | } |
||
| 31 | |||
| 32 | /** |
||
| 33 | * Seed created table via up() method with some data |
||
| 34 | * @return void |
||
| 35 | */ |
||
| 36 | public function seed() |
||
| 37 | { |
||
| 38 | |||
| 39 | } |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Execute actions when migration is down |
||
| 43 | * @return void |
||
| 44 | */ |
||
| 45 | public function down() |
||
| 49 | } |
||
| 50 | } |