Issues in index.php - New Issues - Inspection of "Comment widget admin iface, fixes, etc" - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6084dc...68443e )

by Mihail

created 2016-02-17 12:32 UTC

Loader/Api/index.php (4 issues)

Labels

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


// check if loader is initialized
if (!defined('root')) {
    die('Hack attempt');
}

// global environment
define('env_name', 'Api');
define('type', 'web');
define('env_no_layout', true);

require_once(root . '/Loader/Autoload.php');

// make fast-access alias \App::$Object

// class_alias('Ffcms\Core\App', 'App');
class App extends Ffcms\Core\App {}

/**
 * Alias for translate function for fast usage. Example: __('Welcome my friend')
 * @param string $text
 * @param array $params
 * @return string
 */
function __($text, array $params = []) {
/**
 * @ignore
 */
function getUser() {

}

function getUser($id, $realm) {

}
    return \App::$Translate->translate($text, $params);
}

try {
    // prepare to run
    \App::init([
        'Database' => true,
        'Session' => true,
        'Debug' => false,
        'User' => true,
        'Mailer' => true,
        'Captcha' => true,
        'Cache' => true
    ]);
    // display output
    \App::run();
} catch (Exception $e) {
    (new \Ffcms\Core\Exception\NativeException($e->getMessage()))->display();
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-02-17 12:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 9 and the first side effect is on line 5. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			// check if loader is initialized
4			if (!defined('root')) {
5			die('Hack attempt');
6			}
7
8			// global environment
9			define('env_name', 'Api');
10			define('type', 'web');
11			define('env_no_layout', true);
12
13			require_once(root . '/Loader/Autoload.php');
14
15			// make fast-access alias \App::$Object
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-17 12:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this `37%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
16			// class_alias('Ffcms\Core\App', 'App');
17			class App extends Ffcms\Core\App {}
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-02-17 12:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `App` has been defined more than once; this definition is ignored, only the first definition in `Loader/Admin/index.php` (L17-17) is considered. This check looks for classes that have been defined more than once. If you can, we would recommend to use standard object-oriented programming techniques. For example, to avoid multiple types, it might make sense to create a common interface, and then multiple, different implementations for that interface. This also has the side-effect of providing you with better IDE auto-completion, static analysis and also better OPCode caching from PHP. Loading history...
18			/**
19			* Alias for translate function for fast usage. Example: __('Welcome my friend')
20			* @param string $text
21			* @param array $params
22			* @return string
23			*/
24			function __($text, array $params = []) {
			0 ignored issues – show Best Practice introduced 2016-02-17 12:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this The function `__()` has been defined more than once; this definition is ignored, only the first definition in `Loader/Admin/index.php` (L24-26) is considered. This check looks for functions that have already been defined in other files. Some Codebases, like WordPress, make a practice of defining functions multiple times. This may lead to problems with the detection of function parameters and types. If you really need to do this, you can mark the duplicate definition with the `@ignore` annotation. /** * @ignore */ function getUser() { } function getUser($id, $realm) { } See also the PhpDoc documentation for @ignore. Loading history...
25			return \App::$Translate->translate($text, $params);
26			}
27
28			try {
29			// prepare to run
30			\App::init([
31			'Database' => true,
32			'Session' => true,
33			'Debug' => false,
34			'User' => true,
35			'Mailer' => true,
36			'Captcha' => true,
37			'Cache' => true
38			]);
39			// display output
40			\App::run();
41			} catch (Exception $e) {
42			(new \Ffcms\Core\Exception\NativeException($e->getMessage()))->display();
43			}
44

phpffcms / ffcms

Push — master ( 6084dc...68443e )

Loader/Api/index.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like