FormUpdate::labels() - Code Metrics - Inspection of "Feedback and ticket system application done!" - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 68443e...939347 )

by Mihail

created 2016-02-19 12:59 UTC

FormUpdate::labels() A

↳ Parent: FormUpdate

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	8
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	8
loc	8
rs	9.4285
cc	1
eloc	5
nc	1
nop	0

<?php

namespace Apps\Model\Admin\Feedback;

use Ffcms\Core\App;
use Ffcms\Core\Arch\Model;

class FormUpdate extends Model
{
    public $name;
    public $email;
    public $message;

    private $_record;

    /**
     * FormUpdate constructor. Pass active record inside the model.
     * @param $record
     */
    public function __construct($record)
    {
        $this->_record = $record;
        parent::__construct();
    }

    /**
     * Set model properties from active record data
     */
    public function before()
    {
        $this->name = $this->_record->name;
        $this->email = $this->_record->email;
        $this->message = $this->_record->message;
    }

    /**
    * Labels to display edit form
    */
    public function labels()

    {
        return [
            'name' => __('Name'),
            'email' => __('Email'),
            'message' => __('Message'),
        ];
    }

    /**
    * Rules to validate changes
    */
    public function rules()

    {
        return [
            [['name', 'email', 'message'], 'required'],
            ['name', 'length_min', '2'],
            ['message', 'length_min', 10],
            ['email', 'email']
        ];
    }

    /**
     * Save data to database
     */
    public function make()
    {
        $this->_record->name = App::$Security->strip_tags($this->name);
        $this->_record->email = App::$Security->strip_tags($this->email);
        $this->_record->message = App::$Security->strip_tags($this->message);
        $this->_record->save();
    }
}

1		<?php
2
3		namespace Apps\Model\Admin\Feedback;
4
5		use Ffcms\Core\App;
6		use Ffcms\Core\Arch\Model;
7
8		class FormUpdate extends Model
9		{
10		public $name;
11		public $email;
12		public $message;
13
14		private $_record;
15
16		/**
17		* FormUpdate constructor. Pass active record inside the model.
18		* @param $record
19		*/
20		public function __construct($record)
21		{
22		$this->_record = $record;
23		parent::__construct();
24		}
25
26		/**
27		* Set model properties from active record data
28		*/
29		public function before()
30		{
31		$this->name = $this->_record->name;
32		$this->email = $this->_record->email;
33		$this->message = $this->_record->message;
34		}
35
36		/**
37		* Labels to display edit form
38		*/
39	View Code Duplication	public function labels()
		0 ignored issues – show Duplication introduced 2016-02-19 13:03 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40		{
41		return [
42		'name' => __('Name'),
43		'email' => __('Email'),
44		'message' => __('Message'),
45		];
46		}
47
48		/**
49		* Rules to validate changes
50		*/
51	View Code Duplication	public function rules()
		0 ignored issues – show Duplication introduced 2016-02-19 13:03 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		{
53		return [
54		[['name', 'email', 'message'], 'required'],
55		['name', 'length_min', '2'],
56		['message', 'length_min', 10],
57		['email', 'email']
58		];
59		}
60
61		/**
62		* Save data to database
63		*/
64		public function make()
65		{
66		$this->_record->name = App::$Security->strip_tags($this->name);
67		$this->_record->email = App::$Security->strip_tags($this->email);
68		$this->_record->message = App::$Security->strip_tags($this->message);
69		$this->_record->save();
70		}
71		}

phpffcms / ffcms

Push — master ( 68443e...939347 )

FormUpdate::labels() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like