Apps\Controller\Admin\Comments

Complexity

Total Complexity

27

Size/Duplication

Total Lines	218
Duplicated Lines	33.49 %

Coupling/Cohesion

Components	0
Dependencies	17

Importance

Changes	6
Bugs	5	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
B	actionIndex()	26	26	1
A	actionRead()	0	13	3
C	actionEdit()	0	32	7
C	actionDelete()	0	45	12
B	actionAnswerlist()	26	26	1
A	actionSettings()	21	21	3

<?php

namespace Apps\Controller\Admin;


use Apps\ActiveRecord\CommentAnswer;
use Apps\ActiveRecord\CommentPost;
use Apps\Model\Admin\Comments\FormSettings;
use Extend\Core\Arch\AdminController;
use Ffcms\Core\App;
use Ffcms\Core\Exception\NotFoundException;
use Ffcms\Core\Helper\HTML\SimplePagination;
use Ffcms\Core\Helper\Type\Arr;
use Apps\Model\Admin\Comments\FormCommentUpdate;
use Ffcms\Core\Helper\Type\Obj;
use Apps\Model\Admin\Comments\FormCommentDelete;

/**
 * Class Comments. Admin controller for management user comments.
 * This class provide general admin implementation of control for user comments and its settings.
 * @package Apps\Controller\Admin
 */
class Comments extends AdminController
{
    const VERSION = 0.1;
    const ITEM_PER_PAGE = 10;

    const TYPE_COMMENT = 'comment';
    const TYPE_ANSWER = 'answer';

    public $type = 'widget';

    /**
     * List user comments with pagination
     * @return string
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionIndex()

This method seems to be duplicated in your project.

    {
        // set current page and offset
        $page = (int)App::$Request->query->get('page');
        $offset = $page * self::ITEM_PER_PAGE;

        // initialize active record model
        $query = new CommentPost();

        // make pagination
        $pagination = new SimplePagination([
            'url' => ['comments/index'],
            'page' => $page,
            'step' => self::ITEM_PER_PAGE,
            'total' => $query->count()
        ]);

        // get result as active records object with offset
        $records = $query->orderBy('id', 'desc')->skip($offset)->take(self::ITEM_PER_PAGE)->get();

        // render output view
        return App::$View->render('index', [
            'records' => $records,
            'pagination' => $pagination
        ]);
    }

    /**
     * List comment - read comment and list answers
     * @param int $id
     * @return string
     * @throws NotFoundException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionRead($id)
    {
        // find object in active record model
        $record = CommentPost::find($id);
        if ($record === null || $record === false) {
            throw new NotFoundException(__('Comment is not founded'));
        }

        // render response
        return App::$View->render('comment_read', [
            'record' => $record
        ]);
    }

    /**
     * Commentaries and answers edit action
     * @param string $type
     * @param int $id
     * @throws NotFoundException
     * @return string
     */
    public function actionEdit($type, $id)
    {
        // get active record by type and id from active records
        $record = null;
        switch ($type) {
            case static::TYPE_COMMENT:
                $record = CommentPost::find($id);
                break;
            case static::TYPE_ANSWER:
                $record = CommentAnswer::find($id);
                break;
        }

        // check if response is not empty
        if ($record === null || $record === false) {
            throw new NotFoundException(__('Comment is not founded'));
        }
        
        // init edit model
        $model = new FormCommentUpdate($record, $type);

$record is of type object<Ffcms\Core\Arch\ActiveModel>, but the function expects a object<Apps\Model\Admin\Comments\Apps\ActiveRecord\CommentPost>|object<Apps\Model\Admin\Comments\Apps\ActiveRecord\CommentAnswer>.

        
        // check if data is submited and validated
        if ($model->send() && $model->validate()) {
            $model->make();
            App::$Session->getFlashBag()->add('success', __('Comment or answer is successful updated'));
        }

        // render view
        return App::$View->render('edit', [
            'model' => $model->export()
        ]);
    }
    
    /**
     * Delete comments and answers single or multiply items
     * @param string $type
     * @param int $id
     * @throws NotFoundException
     * @return string
     */
    public function actionDelete($type, $id = 0)
    {
        // sounds like a multiply delete definition
        if ($id === 0 || (int)$id < 1) {
            $ids = App::$Request->query->get('selectRemove');
            if (Obj::isArray($ids) && Arr::onlyNumericValues($ids)) {

The method onlyNumericValues() does not seem to exist on object<Ffcms\Core\Helper\Type\Arr>.

                $id = $ids;
            } else {
                throw new NotFoundException('Bad conditions');
            }
        } else {
            $id = [$id];
        }
        
        // prepare query to db
        $query = null;
        switch ($type) {
            case self::TYPE_COMMENT:
                $query = CommentPost::whereIn('id', $id);
                break;
            case self::TYPE_ANSWER:
                $query = CommentAnswer::whereIn('id', $id);
                break;
        }
        
        // check if result is not empty
        if ($query === null || $query->count() < 1) {
            throw new NotFoundException(__('No comments found for this condition'));
        }
        
        // initialize model
        $model = new FormCommentDelete($query, $type);
        
        // check if delete is submited
        if ($model->send() && $model->validate()) {
            $model->make();
            App::$Session->getFlashBag()->add('success', __('Comments or answers are successful deleted!'));
            App::$Response->redirect('comments/' . ($type === 'answer' ? 'answerlist' : 'index'));
        }
        
        // render view
        return App::$View->render('delete', [
            'model' => $model
        ]);
    }

    /**
     * List answers 
     * @return string
     */
    public function actionAnswerlist()

This method seems to be duplicated in your project.

    {
        // set current page and offset
        $page = (int)App::$Request->query->get('page');
        $offset = $page * self::ITEM_PER_PAGE;
        
        // initialize ar answers model
        $query = new CommentAnswer();
        
        // build pagination list
        $pagination = new SimplePagination([
            'url' => ['comments/answerlist'],
            'page' => $page,
            'step' => self::ITEM_PER_PAGE,
            'total' => $query->count()
        ]);
        
        // get result as active records object with offset
        $records = $query->orderBy('id', 'desc')->skip($offset)->take(self::ITEM_PER_PAGE)->get();
        
        // render output view
        return App::$View->render('answer_list', [
            'records' => $records,
            'pagination' => $pagination
        ]);
    }

    /**
     * Comment widget global settings
     * @return string
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionSettings()

This method seems to be duplicated in your project.

    {
        // initialize settings model
        $model = new FormSettings($this->getConfigs());

        // check if form is send
        if ($model->send()) {
            if ($model->validate()) {
                $this->setConfigs($model->getAllProperties());
                App::$Session->getFlashBag()->add('success', __('Settings is successful updated'));
                App::$Response->redirect('comments/index');
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render view
        return App::$View->render('settings', [
            'model' => $model
        ]);
    }




}