Passed
Push — master ( c6150b...ef80b0 )
by Mihail
05:01
created

ActionSettings   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 25
Duplicated Lines 0 %

Importance

Changes 0
Metric Value
eloc 11
dl 0
loc 25
rs 10
c 0
b 0
f 0
wmc 3

1 Method

Rating   Name   Duplication   Size   Complexity  
A settings() 0 18 3
1
<?php
2
3
namespace Apps\Controller\Admin\User;
4
5
6
use Apps\Model\Admin\User\FormUserSettings;
7
use Ffcms\Core\App;
8
use Ffcms\Core\Arch\View;
9
use Ffcms\Core\Network\Request;
10
use Ffcms\Core\Network\Response;
11
12
/**
13
 * Trait ActionSettings
14
 * @package Apps\Controller\Admin\User
15
 * @property Request $request
16
 * @property Response $response
17
 * @property View $view
18
 */
19
trait ActionSettings
20
{
21
    /**
22
     * User app settings action
23
     * @return string|null
24
     * @throws \Ffcms\Core\Exception\SyntaxException
25
     */
26
    public function settings(): ?string
27
    {
28
        // load model and pass property's as argument
29
        $model = new FormUserSettings($this->getConfigs());
0 ignored issues
show
Bug introduced by zenn
It seems like getConfigs() must be provided by classes using this trait. How about adding it as abstract method to this trait? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

29
        $model = new FormUserSettings($this->/** @scrutinizer ignore-call */ getConfigs());
Loading history...
30
31
        if ($model->send()) {
32
            if ($model->validate()) {
33
                $this->setConfigs($model->getAllProperties());
0 ignored issues
show
Bug introduced by Mihail
Are you sure the usage of $model->getAllProperties() targeting Ffcms\Core\Arch\Model::getAllProperties() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
Bug introduced by zenn
It seems like setConfigs() must be provided by classes using this trait. How about adding it as abstract method to this trait? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

33
                $this->/** @scrutinizer ignore-call */ 
34
                       setConfigs($model->getAllProperties());
Loading history...
34
                App::$Session->getFlashBag()->add('success', __('Settings is successful updated'));
35
                $this->response->redirect('user/index');
36
            } else {
37
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
38
            }
39
        }
40
41
        // render view
42
        return $this->view->render('user/settings', [
43
            'model' => $model
44
        ]);
45
    }
46
}