View GitHub Repository ffcms

Schedule Inspection
Subscribe
Passed
Push — master ( 2f3799...59abca )
by Mihail
06:06
created
Status
Category
Toggle Patches
Apps/Controller/Front/Feedback.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -39,18 +39,18 @@  discard block
 
 block discarded – undo
39 39 
     {
40 40 
         // get configs
41 41 
         $configs = $this->getConfigs();
42 
-        if (!App::$User->isAuth() && !(bool)$configs['guestAdd']) {
42 
+        if (!App::$User->isAuth() && !(bool) $configs['guestAdd']) {
43 43 
             throw new ForbiddenException(__('Feedback available only for authorized users'));
44 44 
         }
45 45
46 46 
         // initialize model
47 
-        $model = new FormFeedbackAdd((bool)$configs['useCaptcha']);
47 
+        $model = new FormFeedbackAdd((bool) $configs['useCaptcha']);
48 48 
         if ($model->send()) {
49 49 
             if ($model->validate()) {
50 50 
                 // if validation is passed save data to db and get row
51 51 
                 $record = $model->make();
52 52 
                 App::$Session->getFlashBag()->add('success', __('Your message was added successful'));
53 
-                $this->response->redirect('feedback/read/' . $record->id . '/' . $record->hash);
53 
+                $this->response->redirect('feedback/read/'.$record->id.'/'.$record->hash);
54 54 
             } else {
55 55 
                 App::$Session->getFlashBag()->add('error', __('Message is not sended! Please, fix issues in form below'));
56 56 
             }
 
@@ -59,7 +59,7 @@  discard block
 
 block discarded – undo
59 59 
         // render output view
60 60 
         return $this->view->render('feedback/create', [
61 61 
             'model' => $model,
62 
-            'useCaptcha' => (bool)$configs['useCaptcha']
62 
+            'useCaptcha' => (bool) $configs['useCaptcha']
63 63 
         ]);
64 64 
     }
65 65 
 
@@ -90,7 +90,7 @@  discard block
 
 block discarded – undo
90 90
91 91 
         $model = null;
92 92 
         // check if feedback post is not closed for answers
93 
-        if (!(bool)$recordPost->closed) {
93 
+        if (!(bool) $recordPost->closed) {
94 94 
             // init new answer add model
95 95 
             $model = new FormAnswerAdd($recordPost);
96 96 
             // if answer is sender lets try to make it model
 
@@ -133,10 +133,10 @@  discard block
 
 block discarded – undo
133 133 
         // check if action is submited
134 134 
         if ($this->request->request->get('closeRequest', false)) {
135 135 
             // if created by authorized user
136 
-            if ((int)$record->user_id > 0) {
136 
+            if ((int) $record->user_id > 0) {
137 137 
                 $user = App::$User->identity();
138 138 
                 // button is pressed not by request creator
139 
-                if (!$user || $user->getId() !== (int)$record->user_id) {
139 
+                if (!$user || $user->getId() !== (int) $record->user_id) {
140 140 
                     throw new ForbiddenException(__('This feedback request was created by another user'));
141 141 
                 }
142 142 
             }
 
@@ -147,11 +147,11 @@  discard block
 
 block discarded – undo
147 147
148 148 
             // add notification and redirect
149 149 
             App::$Session->getFlashBag()->add('warning', __('Feedback request now is closed!'));
150 
-            $this->response->redirect('feedback/read/' . $id . '/' . $hash);
150 
+            $this->response->redirect('feedback/read/'.$id.'/'.$hash);
151 151 
         }
152 152
153 153 
         return $this->view->render('feedback/close', [
154 
-            'id' => (int)$id,
154 
+            'id' => (int) $id,
155 155 
             'hash' => $hash
156 156 
         ]);
157 157 
     }
 
@@ -164,7 +164,7 @@  discard block
 
 block discarded – undo
164 164 
     public function actionList(): ?string
165 165 
     {
166 166 
         // set current page and offset
167 
-        $page = (int)$this->request->query->get('page');
167 
+        $page = (int) $this->request->query->get('page');
168 168 
         $offset = $page * self::ITEM_PER_PAGE;
169 169
170 170 
         // check if user is authorized or throw exception
Please login to merge, or discard this patch.
Apps/View/Front/default/_layouts/default.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -27,7 +27,7 @@  discard block
 
 block discarded – undo
27 27 
     <?php if (\App::$Debug): ?>
28 28 
         <?= \App::$Debug->renderHead() ?>
29 29 
     <?php endif; ?>
30 
-    <?php if (!isset($fullgrid)){ $fullgrid = false; } ?>
30 
+    <?php if (!isset($fullgrid)) { $fullgrid = false; } ?>
31 31 
 </head>
32 32 
 <body class="bg-light">
33 33 
 
@@ -41,15 +41,15 @@  discard block
 
 block discarded – undo
41 41
42 42 
 if (\App::$User->isAuth()) {
43 43 
     $userId = \App::$User->identity()->getId();
44 
-    $navbar->menu('right', ['text' => __('Account') . ' <span class="badge" id="summary-count-block">0</span>', 'dropdown' => [
44 
+    $navbar->menu('right', ['text' => __('Account').' <span class="badge" id="summary-count-block">0</span>', 'dropdown' => [
45 45 
         ['text' => __('My profile'), 'link' => ['profile/show', [$userId]]],
46 
-        ['text' => __('Messages') . ' <span class="badge" id="pm-count-block">0</span>', 'link' => ['profile/messages'], 'class' => 'dropdown-item', 'html' => true],
46 
+        ['text' => __('Messages').' <span class="badge" id="pm-count-block">0</span>', 'link' => ['profile/messages'], 'class' => 'dropdown-item', 'html' => true],
47 47 
         ['text' => __('Feed'), 'link' => ['profile/feed'], 'class' => 'dropdown-item'],
48 
-        ['text' => __('Notifications') . ' <span class="badge" id="notify-count-block">0</span>', 'link' => ['profile/notifications'], 'class' => 'dropdown-item', 'html' => true],
48 
+        ['text' => __('Notifications').' <span class="badge" id="notify-count-block">0</span>', 'link' => ['profile/notifications'], 'class' => 'dropdown-item', 'html' => true],
49 49 
         ['text' => __('Settings'), 'link' => ['profile/settings'], 'class' => 'dropdown-item'],
50 50 
     ], 'properties' => ['html' => true]]);
51 51 
     if (\App::$User->identity()->role->can('Admin/Main/Index')) {
52 
-        $navbar->menu('right', ['text' => __('Admin'), 'link' => \App::$Alias->scriptUrl . '/admin']);
52 
+        $navbar->menu('right', ['text' => __('Admin'), 'link' => \App::$Alias->scriptUrl.'/admin']);
53 53 
     }
54 54 
     $navbar->menu('right', ['text' => __('Logout'), 'link' => ['user/logout']]);
55 55 
 } else {
Please login to merge, or discard this patch.
Apps/View/Admin/default/main/index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -51,7 +51,7 @@
 
 block discarded – undo
51 51 
         <h3><?= __('Directories and files') ?></h3>
52 52 
         <?php
53 53 
         foreach ($check->chmodCheck as $dir => $status) {
54 
-            echo $this->bootstrap()->badge(($status ? 'success' : 'danger'), $dir) . "&nbsp;";
54 
+            echo $this->bootstrap()->badge(($status ? 'success' : 'danger'), $dir)."&nbsp;";
55 55 
         }
56 56 
         ?>
57 57 
         <hr />
Please login to merge, or discard this patch.
Apps/Controller/Api/Main.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -45,8 +45,8 @@  discard block
 
 block discarded – undo
45 45 
             'roots' => [
46 46 
                 [
47 47 
                     'driver' => 'LocalFileSystem',
48 
-                    'path' => root . '/upload/',
49 
-                    'URL' => App::$Alias->scriptUrl . '/upload/'
48 
+                    'path' => root.'/upload/',
49 
+                    'URL' => App::$Alias->scriptUrl.'/upload/'
50 50 
                 ]
51 51 
             ]
52 52 
         ]));
 
@@ -111,9 +111,9 @@  discard block
 
 block discarded – undo
111 111 
     {
112 112 
         $this->setJsonHeader();
113 113 
         // get ffcms news if cache is not available
114 
-        $cache = App::$Cache->getItem('download.ffcms.api.news.' . $this->lang);
114 
+        $cache = App::$Cache->getItem('download.ffcms.api.news.'.$this->lang);
115 115 
         if (!$cache->isHit()) {
116 
-            $cache->set(File::getFromUrl('https://ffcms.org/api/api/news?lang=' . $this->lang))
116 
+            $cache->set(File::getFromUrl('https://ffcms.org/api/api/news?lang='.$this->lang))
117 117 
                 ->expiresAfter(1440);
118 118 
         }
119 119 
         return $cache->get();
Please login to merge, or discard this patch.
Apps/Controller/Admin/Main.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -50,7 +50,7 @@  discard block
 
 block discarded – undo
50 50 
     public function actionFiles(): ?string
51 51 
     {
52 52 
         return $this->view->render('main/files', [
53 
-            'connector' => App::$Alias->scriptUrl . '/api/main/files?lang=' . $this->request->getLanguage()
53 
+            'connector' => App::$Alias->scriptUrl.'/api/main/files?lang='.$this->request->getLanguage()
54 54 
         ]);
55 55 
     }
56 56 
 
@@ -115,9 +115,9 @@  discard block
 
 block discarded – undo
115 115 
      */
116 116 
     public function actionDeleteroute(): ?string
117 117 
     {
118 
-        $type = (string)$this->request->query->get('type');
119 
-        $loader = (string)$this->request->query->get('loader');
120 
-        $source = Str::lowerCase((string)$this->request->query->get('path'));
118 
+        $type = (string) $this->request->query->get('type');
119 
+        $loader = (string) $this->request->query->get('loader');
120 
+        $source = Str::lowerCase((string) $this->request->query->get('path'));
121 121
122 122 
         $model = new EntityDeleteRoute($type, $loader, $source);
123 123 
         if ($model->send() && $model->validate()) {
Please login to merge, or discard this patch.
Apps/Controller/Admin/Application.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -83,7 +83,7 @@  discard block
 
 block discarded – undo
83 83 
         $search = \Apps\ActiveRecord\App::getItem('app', $controller);
84 84
85 85 
         // check what we got
86 
-        if ($search === null || (int)$search->id < 1) {
86 
+        if ($search === null || (int) $search->id < 1) {
87 87 
             throw new NotFoundException('App is not founded');
88 88 
         }
89 89 
 
@@ -115,7 +115,7 @@  discard block
 
 block discarded – undo
115 115 
         $search = \Apps\ActiveRecord\App::where('sys_name', '=', $controllerName)
116 116 
             ->where('type', '=', 'app')
117 117 
             ->first();
118 
-        if (!$search || (int)$search->id < 1) {
118 
+        if (!$search || (int) $search->id < 1) {
119 119 
             throw new ForbiddenException('App is not founded');
120 120 
         }
121 121
Please login to merge, or discard this patch.
Apps/View/Admin/default/main/routing.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -37,9 +37,9 @@  discard block
 
 block discarded – undo
37 37 
                 if (Any::isArray($route)) {
38 38 
                     foreach ($route as $source => $target) {
39 39 
                         $alias->row([
40 
-                            ['text' => '<span class="badge badge-primary">' . $source . '</span> ' .
41 
-                                '→ ' .
42 
-                                '<span class="badge badge-secondary">' . $target . '</span>', 'html' => true],
40 
+                            ['text' => '<span class="badge badge-primary">'.$source.'</span> '.
41 
+                                '→ '.
42 
+                                '<span class="badge badge-secondary">'.$target.'</span>', 'html' => true],
43 43 
                             ['text' => $env],
44 44 
                             ['text' => Url::a(
45 45 
                                 ['main/deleteroute', null, ['type' => 'Alias', 'loader' => $env, 'path' => $source]],
 
@@ -71,9 +71,9 @@  discard block
 
 block discarded – undo
71 71 
                 if (Any::isArray($route)) {
72 72 
                     foreach ($route as $source => $target) {
73 73 
                         $dynamic->row([
74 
-                            ['text' => '<span class="badge badge-primary">' . $source . '</span> ' .
75 
-                                '→ ' .
76 
-                                '<span class="badge badge-secondary">' . $target . '</span>', 'html' => true],
74 
+                            ['text' => '<span class="badge badge-primary">'.$source.'</span> '.
75 
+                                '→ '.
76 
+                                '<span class="badge badge-secondary">'.$target.'</span>', 'html' => true],
77 77 
                             ['text' => $env],
78 78 
                             ['text' => Url::a(
79 79 
                                 ['main/deleteroute', null, ['type' => 'Callback', 'loader' => $env, 'path' => $source]],
 
@@ -92,6 +92,6 @@  discard block
 
 block discarded – undo
92 92 
 </div>
93 93 
 <?php if (!$aliasExist && !$callbackExist): ?>
94 94 
     <p class="alert alert-warning"><?= __('Custom routes is not yet found') ?></p>
95 
-<?php endif ;?>
96 
-<?= Url::a(['main/addroute'], '<i class="fa fa-plus"></i> ' . __('New route'), ['class' => 'btn btn-primary', 'html' => true]) ?>
95 
+<?php endif; ?>
96 
+<?= Url::a(['main/addroute'], '<i class="fa fa-plus"></i> '.__('New route'), ['class' => 'btn btn-primary', 'html' => true]) ?>
97 97 
 <?php $this->stop() ?>
Please login to merge, or discard this patch.
Apps/View/Admin/default/main/updates.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -64,7 +64,10 @@
 
 block discarded – undo
64 64 
     echo $form->button()->submit(__('Download update'), ['class' => 'btn btn-primary']);
65 65 
     echo $form->stop();
66 66 
     ?>
67 
-<?php else: ?>
67 
+<?php else {
68 
+    : ?>
68 69 
     <p class="alert alert-success"><?= __('Your system is up to date. No updates is available') ?></p>
69 
-<?php endif; ?>
70 
+<?php endif;
71 
+}
72 
+?>
70 73 
 <?php $this->stop() ?>
Please login to merge, or discard this patch.
Apps/View/Admin/default/application/_actions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -5,6 +5,6 @@
 
 block discarded – undo
5 5
6 6 
 ?>
7 7 
 <?php if (isset($controller)): ?>
8 
-    <a href="<?= Url::to($controller . '/index') ?>"><i class="fa fa-cogs"></i></a>&nbsp;
8 
+    <a href="<?= Url::to($controller.'/index') ?>"><i class="fa fa-cogs"></i></a>&nbsp;
9 9 
     <a href="<?= Url::to('application/turn', [$controller]) ?>"><i class="fa fa-power-off"></i></a>
10 10 
 <?php endif; ?>
11 11 
\ No newline at end of file
Please login to merge, or discard this patch.