Passed
Push — master ( 2f3799...59abca )
by Mihail
06:06
created

ActionSettings::settings()   A

Complexity

Conditions 3
Paths 3

Size

Total Lines 21
Code Lines 10

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 3
eloc 10
nc 3
nop 0
dl 0
loc 21
rs 9.9332
c 0
b 0
f 0
1
<?php
2
3
namespace Apps\Controller\Admin\Feedback;
4
5
use Apps\Model\Admin\Feedback\FormSettings;
6
use Ffcms\Core\App;
7
use Ffcms\Core\Arch\View;
8
use Ffcms\Core\Network\Request;
9
use Ffcms\Core\Network\Response;
10
11
/**
12
 * Trait ActionSettings
13
 * @package Apps\Controller\Admin\Feedback
14
 * @property Request $request
15
 * @property Response $response
16
 * @property View $view
17
 */
18
trait ActionSettings
19
{
20
    /**
21
     * @return string|null
22
     * @throws \Ffcms\Core\Exception\SyntaxException
23
     */
24
    public function settings(): ?string
25
    {
26
        // initialize model and pass configs
27
        $model = new FormSettings($this->getConfigs());
0 ignored issues
show
Bug introduced by zenn
It seems like getConfigs() must be provided by classes using this trait. How about adding it as abstract method to this trait? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

27
        $model = new FormSettings($this->/** @scrutinizer ignore-call */ getConfigs());
Loading history...
28
29
        // check if form is submited to save data
30
        if ($model->send()) {
31
            // is validation passed?
32
            if ($model->validate()) {
33
                // save properties
34
                $this->setConfigs($model->getAllProperties());
0 ignored issues
show
Bug introduced by Mihail
Are you sure the usage of $model->getAllProperties() targeting Ffcms\Core\Arch\Model::getAllProperties() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
Bug introduced by zenn
It seems like setConfigs() must be provided by classes using this trait. How about adding it as abstract method to this trait? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

34
                $this->/** @scrutinizer ignore-call */ 
35
                       setConfigs($model->getAllProperties());
Loading history...
35
                App::$Session->getFlashBag()->add('success', __('Settings is successful updated'));
36
                $this->response->redirect('feedback/index');
37
            } else {
38
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
39
            }
40
        }
41
42
        // render view
43
        return $this->view->render('feedback/settings', [
44
            'model' => $model
45
        ]);
46
    }
47
}