App::getConfigs() - Code Metrics - Inspection of "Cron interface, fix typos in content app," - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3ade98...223787 )

by Mihail

created 2016-05-22 09:08 UTC

App::getConfigs() A

↳ Parent: App

Complexity

Conditions	4
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
rs	9.2
cc	4
eloc	5
nc	3
nop	2

<?php

namespace Apps\ActiveRecord;

use Ffcms\Core\Arch\ActiveModel;
use Ffcms\Core\Cache\MemoryObject;
use Ffcms\Core\Exception\SyntaxException;
use Ffcms\Core\Helper\Serialize;
use Ffcms\Core\Helper\Type\Str;

/**
 * Class App - active record for 'prefix_apps' table.
 * @package Apps\ActiveRecord
 * @property int $id
 * @property string $type
 * @property string $sys_name
 * @property string $name
 * @property string $configs
 * @property int $disabled
 * @property float $version
 * @property string $created_at
 * @property string $updated_at
 */
class App extends ActiveModel
{
    /**
     * Get all objects with query caching
     * @return \Illuminate\Database\Eloquent\Collection|static
     * @throws SyntaxException
     */
    public static function getAll()
    {
        $object = MemoryObject::instance()->get('app.cache.all');
        // empty?
        if ($object === null) {
            $object = self::all();
            MemoryObject::instance()->set('app.cache.all', $object);
        }
        
        if ($object === null) {
            throw new SyntaxException('Application table "prefix_app" is empty!!!');
        }

        return $object;
    }

    /**
     * Get all object by defined $type with caching query in memory
     * @param $type
     * @return array|null
     * @throws SyntaxException
     */
    public static function getAllByType($type)
    {
        $response = null;
        foreach (self::getAll() as $object) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if ($object['type'] === $type) {
                $response[] = $object;
            }
        }

        return $response;
    }

    /**
     * Get single row by defined type and sys_name with query caching
     * @param string $type
     * @param string $sys_name
     * @return mixed|null
     * @throws SyntaxException
     */
    public static function getItem($type, $sys_name)
    {
        foreach (self::getAll() as $object) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if ($object['type'] === $type && $object['sys_name'] === $sys_name) {
                return $object;
            }
        }

        return null;
    }

    /**
     * Get application configs
     * @param string $type
     * @param string $name
     * @return array|null|string
     * @throws SyntaxException
     */
    public static function getConfigs($type, $name)
    {
        foreach (self::getAll() as $row) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if ($row->type === $type && $row->sys_name === $name) {
                return Serialize::decode($row->configs);
            }
        }

        return null;
    }

    /**
     * Get single config value by ext type, ext name and config key
     * @param string $type
     * @param string $name
     * @param string $configKey
     * @return null
     */
    public static function getConfig($type, $name, $configKey)
    {
        $configs = self::getConfigs($type, $name);
        if (isset($configs[$configKey])) {
            return $configs[$configKey];
        }

        return null;
    }

    /**
     * Get localized application name
     * @return string
     * @throws SyntaxException
     */
    public function getLocaleName()
    {
        if ($this->sys_name === null) {
            throw new SyntaxException('Application object is not founded');
        }

        $nameObject = Serialize::decode($this->name);
        $lang = \Ffcms\Core\App::$Request->getLanguage();
        $name = $nameObject[$lang];
        if (Str::likeEmpty($name)) {
            $name = $this->sys_name;
        }
        return $name;
    }

    /**
     * Check if app version match db version of this app
     * @return bool
     * @throws SyntaxException
     */
    public function checkVersion()
    {
        if ($this->sys_name === null) {
            throw new SyntaxException('Application object is not founded');
        }

        $scriptVersion = $this->getScriptVersion();

        return $scriptVersion === (float)$this->version;
    }

    /**
     * Get extension script version if exists
     * @return bool|float
     */
    public function getScriptVersion()
    {
        $class = 'Apps\Controller\Admin\\' . $this->sys_name;
        if (!class_exists($class)) {
            return false;
        }

        if (!defined($class . '::VERSION')) {
            return false;
        }

        return (float)constant($class . '::VERSION');
    }

}

1			<?php
2
3			namespace Apps\ActiveRecord;
4
5			use Ffcms\Core\Arch\ActiveModel;
6			use Ffcms\Core\Cache\MemoryObject;
7			use Ffcms\Core\Exception\SyntaxException;
8			use Ffcms\Core\Helper\Serialize;
9			use Ffcms\Core\Helper\Type\Str;
10
11			/**
12			* Class App - active record for 'prefix_apps' table.
13			* @package Apps\ActiveRecord
14			* @property int $id
15			* @property string $type
16			* @property string $sys_name
17			* @property string $name
18			* @property string $configs
19			* @property int $disabled
20			* @property float $version
21			* @property string $created_at
22			* @property string $updated_at
23			*/
24			class App extends ActiveModel
25			{
26			/**
27			* Get all objects with query caching
28			* @return \Illuminate\Database\Eloquent\Collection\|static
29			* @throws SyntaxException
30			*/
31			public static function getAll()
32			{
33			$object = MemoryObject::instance()->get('app.cache.all');
34			// empty?
35			if ($object === null) {
36			$object = self::all();
37			MemoryObject::instance()->set('app.cache.all', $object);
38			}
39
40			if ($object === null) {
41			throw new SyntaxException('Application table "prefix_app" is empty!!!');
42			}
43
44			return $object;
45			}
46
47			/**
48			* Get all object by defined $type with caching query in memory
49			* @param $type
50			* @return array\|null
51			* @throws SyntaxException
52			*/
53			public static function getAllByType($type)
54			{
55			$response = null;
56			foreach (self::getAll() as $object) {
			0 ignored issues – show Bug introduced 2015-11-21 16:45 UTC by Report Bug Copy Issue Report The expression `self::getAll()` of type `object<Illuminate\Databa...<Apps\ActiveRecord\App>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
57			if ($object['type'] === $type) {
58			$response[] = $object;
59			}
60			}
61
62			return $response;
63			}
64
65			/**
66			* Get single row by defined type and sys_name with query caching
67			* @param string $type
68			* @param string $sys_name
69			* @return mixed\|null
70			* @throws SyntaxException
71			*/
72			public static function getItem($type, $sys_name)
73			{
74			foreach (self::getAll() as $object) {
			0 ignored issues – show Bug introduced 2015-11-21 16:45 UTC by Report Bug Copy Issue Report The expression `self::getAll()` of type `object<Illuminate\Databa...<Apps\ActiveRecord\App>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
75			if ($object['type'] === $type && $object['sys_name'] === $sys_name) {
76			return $object;
77			}
78			}
79
80			return null;
81			}
82
83			/**
84			* Get application configs
85			* @param string $type
86			* @param string $name
87			* @return array\|null\|string
88			* @throws SyntaxException
89			*/
90			public static function getConfigs($type, $name)
91			{
92			foreach (self::getAll() as $row) {
			0 ignored issues – show Bug introduced 2015-11-21 16:45 UTC by Report Bug Copy Issue Report The expression `self::getAll()` of type `object<Illuminate\Databa...<Apps\ActiveRecord\App>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
93			if ($row->type === $type && $row->sys_name === $name) {
94			return Serialize::decode($row->configs);
95			}
96			}
97
98			return null;
99			}
100
101			/**
102			* Get single config value by ext type, ext name and config key
103			* @param string $type
104			* @param string $name
105			* @param string $configKey
106			* @return null
107			*/
108			public static function getConfig($type, $name, $configKey)
109			{
110			$configs = self::getConfigs($type, $name);
111			if (isset($configs[$configKey])) {
112			return $configs[$configKey];
113			}
114
115			return null;
116			}
117
118			/**
119			* Get localized application name
120			* @return string
121			* @throws SyntaxException
122			*/
123			public function getLocaleName()
124			{
125			if ($this->sys_name === null) {
126			throw new SyntaxException('Application object is not founded');
127			}
128
129			$nameObject = Serialize::decode($this->name);
130			$lang = \Ffcms\Core\App::$Request->getLanguage();
131			$name = $nameObject[$lang];
132			if (Str::likeEmpty($name)) {
133			$name = $this->sys_name;
134			}
135			return $name;
136			}
137
138			/**
139			* Check if app version match db version of this app
140			* @return bool
141			* @throws SyntaxException
142			*/
143			public function checkVersion()
144			{
145			if ($this->sys_name === null) {
146			throw new SyntaxException('Application object is not founded');
147			}
148
149			$scriptVersion = $this->getScriptVersion();
150
151			return $scriptVersion === (float)$this->version;
152			}
153
154			/**
155			* Get extension script version if exists
156			* @return bool\|float
157			*/
158			public function getScriptVersion()
159			{
160			$class = 'Apps\Controller\Admin\\' . $this->sys_name;
161			if (!class_exists($class)) {
162			return false;
163			}
164
165			if (!defined($class . '::VERSION')) {
166			return false;
167			}
168
169			return (float)constant($class . '::VERSION');
170			}
171
172			}

phpffcms / ffcms

Push — master ( 3ade98...223787 )

App::getConfigs() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like