Apps\Controller\Admin\Application

Complexity

Total Complexity

15

Size/Duplication

Total Lines	120
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	14

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	5	5	1
A	actionIndex()	6	6	1
B	actionInstall()	24	24	4
B	actionUpdate()	24	24	5
A	actionTurn()	21	21	4

<?php

namespace Apps\Controller\Admin;

use Apps\Model\Admin\Application\FormTurn;
use Apps\Model\Admin\Application\FormInstall;
use Apps\Model\Admin\Application\FormUpdate;
use Extend\Core\Arch\AdminController;
use Ffcms\Core\App;
use Ffcms\Core\Exception\ForbiddenException;
use Ffcms\Core\Exception\NotFoundException;
use Ffcms\Core\Helper\Type\Str;

/**
 * Class Application. View and manage system applications.
 * @package Apps\Controller\Admin
 */
class Application extends AdminController

This class seems to be duplicated in your project.

{
    public $type = 'app';

    /**
     * Application constructor.
     */
    public function __construct()
    {
        // prevent version checks
        parent::__construct(false);
    }

    /**
     * List of all installed applications
     * @return string
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionIndex()
    {
        return $this->view->render('index', [
            'apps' => $this->applications
        ]);
    }
    
    /**
     * Show installation for of applications
     * @return string
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionInstall()
    {
        $model = new FormInstall($this->applications, 'app');

        // check if model is sended
        if ($model->send()) {
            // validate app name
            if ($model->validate()) {
                // try to run ::install method from remoute controller
                if ($model->make()) {
                        App::$Session->getFlashBag()->add('success', __('Application "%app%" is successful installed!', ['app' => $model->sysname]));
                    $this->response->redirect('application/index');
                } else {
                    App::$Session->getFlashBag()->add('error', __('During the installation process an error has occurred! Please contact with application developer.'));
                }
            } else {
                App::$Session->getFlashBag()->add('error', __('Probably, app or widget with the same name is always used! Try to solve this conflict.'));
            }
        }

        return $this->view->render('install', [
            'model' => $model
        ]);
    }

    /**
     * Show and process update form for apps
     * @param string $sys_name
     * @return string
     * @throws \Ffcms\Core\Exception\SyntaxException
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws NotFoundException
     */
    public function actionUpdate($sys_name)
    {
        // get controller name and try to find app in db
        $controller = ucfirst(Str::lowerCase($sys_name));
        $search = \Apps\ActiveRecord\App::getItem('app', $controller);

        // check what we got
        if ($search === null || (int)$search->id < 1) {
            throw new NotFoundException('App is not founded');
        }

        // init model and make update with notification
        $model = new FormUpdate($search);
        if ($model->send() && $model->validate()) {
            $model->make();
            App::$Session->getFlashBag()->add('success', __('Application %s% is successful updated to %v% version', ['s' => $sys_name, 'v' => $model->scriptVersion]));
            $this->response->redirect('application/index');
        }

        // render response
        return $this->view->render('update', [
            'model' => $model
        ]);
    }

    /**
     * Allow turn on/off applications
     * @param $controllerName
     * @return string
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws ForbiddenException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionTurn($controllerName)
    {
        $controllerName = ucfirst(Str::lowerCase($controllerName));

        $search = \Apps\ActiveRecord\App::where('sys_name', '=', $controllerName)->where('type', '=', 'app')->first();

        if ($search === null || (int)$search->id < 1) {
            throw new ForbiddenException('App is not founded');
        }

        $model = new FormTurn($search);

$search of type object<Ffcms\Core\Arch\ActiveModel> is not a sub-type of object<Apps\ActiveRecord\App>. It seems like you assume a child class of the class Ffcms\Core\Arch\ActiveModel to be always present.

        if ($model->send()) {
            $model->update();
            App::$Session->getFlashBag()->add('success', __('Application status was changed'));
        }

        return $this->view->render('turn', [
            'app' => $search,
            'model' => $model
        ]);
    }
}