Comments::actionShowanswers() - Code Metrics - Inspection of "Comment front done! Some features for system." - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8f5376...4142cd )

by Mihail

created 2016-02-03 08:41 UTC

Comments::actionShowanswers() B

↳ Parent: Comments

Complexity

Conditions	5
Paths	4

Size

Total Lines	25
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	25
rs	8.439
cc	5
eloc	13
nc	4
nop	1

<?php

namespace Apps\Controller\Api;

use Apps\ActiveRecord\CommentPost;
use Apps\ActiveRecord\CommentAnswer;
use Apps\ActiveRecord\App as AppRecord;
use Apps\Model\Api\Comments\CommentAdd;
use Apps\Model\Api\Comments\CommentAnswerAdd;
use Apps\Model\Api\Comments\CommentPostAdd;
use Apps\Model\Api\Comments\EntityCommentData;
use Extend\Core\Arch\ApiController;
use Ffcms\Core\App;
use Ffcms\Core\Exception\JsonException;
use Ffcms\Core\Helper\Date;
use Ffcms\Core\Helper\Type\Obj;
use Ffcms\Core\Helper\Type\Str;

class Comments extends ApiController
{
    const ITEM_PER_PAGE = 10;

    public function actionAdd()
    {
        $this->setJsonHeader();
        $configs = AppRecord::getConfigs('widget', 'Comments');

        $replayTo = (int)App::$Request->request->get('replay-to');
        $model = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        // check if its a answer (comment answer type)
        if ($replayTo > 0) {
            $model = new CommentAnswerAdd($configs);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $model->replayTo = $replayTo;
        } else { // sounds like new comment row
            $model = new CommentPostAdd($configs);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $model->pathway = App::$Security->strip_tags(App::$Request->request->get('pathway'));
        }

        // pass general comment params to model
        $model->message = App::$Security->secureHtml((string)App::$Request->request->get('message'));
        $model->guestName = App::$Security->strip_tags(App::$Request->request->get('guest-name'));

        // check model conditions before add new row
        if ($model === null || !$model->check()) {
            throw new JsonException('Unknown error');
        }

        // add comment post or answer to database and get response active record row
        $record = $model->buildRecord();
        // pass row to entity builder model
        $response = new EntityCommentData($record);

        return json_encode([
            'status' => 1,
            'data' => $response->make() // build row to standard format
        ]);
    }

    public function actionList($index)
    {
        // set header
        $this->setJsonHeader();
        // get config count per page
        $perPage = (int)AppRecord::getConfig('widget', 'Comments', 'perPage');
        // offset can be only integer
        $index = (int)$index;
        $offset = $perPage * $index;
        // get comment target path and check
        $path = (string)App::$Request->query->get('path');
        if (Str::likeEmpty($path)) {
            throw new JsonException('Wrong path');
        }

        // select comments from db and check it
        $records = CommentPost::where('pathway', '=', $path)
            ->skip($offset)
            ->take($perPage)
            ->get();

        if ($records->count() < 1) {
            throw new JsonException(__('There is no comments found yet. You can be the first!'));
        }

        // build output json data as array
        $data = [];
        foreach ($records as $comment) {
            // prepare specified data to output response, based on entity model
            $commentResponse = new EntityCommentData($comment);

            // build output json data
            $data[] = $commentResponse->make();
            $commentResponse = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }

        // calculate comments left count
        $count = CommentPost::where('pathway', '=', $path)->count();
        $count -= $offset + $perPage;
        if ($count < 0) {
            $count = 0;
        }

        return json_encode([
            'status' => 1,
            'data' => $data,
            'leftCount' => $count
        ]);
    }

    public function actionShowanswers($commentId)
    {
        // check input data
        if (!Obj::isLikeInt($commentId) || (int)$commentId < 1) {
            throw new JsonException('Input data is incorrect');
        }

        // get data from db by comment id
        $records = CommentAnswer::where('comment_id', '=', $commentId);
        if ($records->count() < 1) {
            throw new JsonException(__('No answers for comment is founded'));
        }

        // prepare output
        $response = [];
        foreach ($records->get() as $row) {
            $commentAnswer = new EntityCommentData($row);
            $response[] = $commentAnswer->make();
        }

        return json_encode([
            'status' => 1,
            'data' => $response
        ]);
    }

}

1			<?php
2
3			namespace Apps\Controller\Api;
4
5			use Apps\ActiveRecord\CommentPost;
6			use Apps\ActiveRecord\CommentAnswer;
7			use Apps\ActiveRecord\App as AppRecord;
8			use Apps\Model\Api\Comments\CommentAdd;
9			use Apps\Model\Api\Comments\CommentAnswerAdd;
10			use Apps\Model\Api\Comments\CommentPostAdd;
11			use Apps\Model\Api\Comments\EntityCommentData;
12			use Extend\Core\Arch\ApiController;
13			use Ffcms\Core\App;
14			use Ffcms\Core\Exception\JsonException;
15			use Ffcms\Core\Helper\Date;
16			use Ffcms\Core\Helper\Type\Obj;
17			use Ffcms\Core\Helper\Type\Str;
18
19			class Comments extends ApiController
20			{
21			const ITEM_PER_PAGE = 10;
22
23			public function actionAdd()
24			{
25			$this->setJsonHeader();
26			$configs = AppRecord::getConfigs('widget', 'Comments');
27
28			$replayTo = (int)App::$Request->request->get('replay-to');
29			$model = null;
			0 ignored issues – show Unused Code introduced 2016-02-03 08:54 UTC by Report Bug Copy Issue Report `$model` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
30			// check if its a answer (comment answer type)
31			if ($replayTo > 0) {
32			$model = new CommentAnswerAdd($configs);
			0 ignored issues – show Bug introduced 2016-02-03 08:54 UTC by Report Bug Copy Issue Report It seems like `$configs` defined by `\Apps\ActiveRecord\App::...s('widget', 'Comments')` on line `26` can also be of type `null` or `string`; however, `Apps\Model\Api\Comments\...nswerAdd::__construct()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
33			$model->replayTo = $replayTo;
34			} else { // sounds like new comment row
35			$model = new CommentPostAdd($configs);
			0 ignored issues – show Bug introduced 2016-02-03 08:54 UTC by Report Bug Copy Issue Report It seems like `$configs` defined by `\Apps\ActiveRecord\App::...s('widget', 'Comments')` on line `26` can also be of type `null` or `string`; however, `Apps\Model\Api\Comments\...tPostAdd::__construct()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
36			$model->pathway = App::$Security->strip_tags(App::$Request->request->get('pathway'));
37			}
38
39			// pass general comment params to model
40			$model->message = App::$Security->secureHtml((string)App::$Request->request->get('message'));
41			$model->guestName = App::$Security->strip_tags(App::$Request->request->get('guest-name'));
42
43			// check model conditions before add new row
44			if ($model === null \|\| !$model->check()) {
45			throw new JsonException('Unknown error');
46			}
47
48			// add comment post or answer to database and get response active record row
49			$record = $model->buildRecord();
50			// pass row to entity builder model
51			$response = new EntityCommentData($record);
52
53			return json_encode([
54			'status' => 1,
55			'data' => $response->make() // build row to standard format
56			]);
57			}
58
59			public function actionList($index)
60			{
61			// set header
62			$this->setJsonHeader();
63			// get config count per page
64			$perPage = (int)AppRecord::getConfig('widget', 'Comments', 'perPage');
65			// offset can be only integer
66			$index = (int)$index;
67			$offset = $perPage * $index;
68			// get comment target path and check
69			$path = (string)App::$Request->query->get('path');
70			if (Str::likeEmpty($path)) {
71			throw new JsonException('Wrong path');
72			}
73
74			// select comments from db and check it
75			$records = CommentPost::where('pathway', '=', $path)
76			->skip($offset)
77			->take($perPage)
78			->get();
79
80			if ($records->count() < 1) {
81			throw new JsonException(__('There is no comments found yet. You can be the first!'));
82			}
83
84			// build output json data as array
85			$data = [];
86			foreach ($records as $comment) {
87			// prepare specified data to output response, based on entity model
88			$commentResponse = new EntityCommentData($comment);
89
90			// build output json data
91			$data[] = $commentResponse->make();
92			$commentResponse = null;
			0 ignored issues – show Unused Code introduced 2016-02-03 08:54 UTC by Report Bug Copy Issue Report `$commentResponse` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
93			}
94
95			// calculate comments left count
96			$count = CommentPost::where('pathway', '=', $path)->count();
97			$count -= $offset + $perPage;
98			if ($count < 0) {
99			$count = 0;
100			}
101
102			return json_encode([
103			'status' => 1,
104			'data' => $data,
105			'leftCount' => $count
106			]);
107			}
108
109			public function actionShowanswers($commentId)
110			{
111			// check input data
112			if (!Obj::isLikeInt($commentId) \|\| (int)$commentId < 1) {
113			throw new JsonException('Input data is incorrect');
114			}
115
116			// get data from db by comment id
117			$records = CommentAnswer::where('comment_id', '=', $commentId);
118			if ($records->count() < 1) {
119			throw new JsonException(__('No answers for comment is founded'));
120			}
121
122			// prepare output
123			$response = [];
124			foreach ($records->get() as $row) {
125			$commentAnswer = new EntityCommentData($row);
126			$response[] = $commentAnswer->make();
127			}
128
129			return json_encode([
130			'status' => 1,
131			'data' => $response
132			]);
133			}
134
135			}

phpffcms / ffcms

Push — master ( 8f5376...4142cd )

Comments::actionShowanswers() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like