Feedback::actionSettings() - Code Metrics - Inspection of "Controller refactoring. Pack of fixes" - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 02a4a5...734a7e )

by Mihail

created 2016-07-18 12:13 UTC

Feedback::actionSettings() A

↳ Parent: Feedback

Complexity

Conditions	3
Paths	3

Size

Total Lines	23
Code Lines	11

Duplication

Lines	23
Ratio	100 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
cc	3
eloc	11
c	2
b	1
f	0
nc	3
nop	0
dl	23
loc	23
rs	9.0856

<?php


namespace Apps\Controller\Admin;

use Apps\ActiveRecord\FeedbackAnswer;
use Apps\Model\Admin\Feedback\FormAnswerAdd;
use Apps\Model\Admin\Feedback\FormSettings;
use Apps\Model\Admin\Feedback\FormUpdate;
use Extend\Core\Arch\AdminController as Controller;
use Ffcms\Core\App;
use Apps\ActiveRecord\FeedbackPost;
use Ffcms\Core\Exception\NotFoundException;
use Ffcms\Core\Helper\HTML\SimplePagination;

/**
 * Class Feedback. Control and manage feedback request and answers.
 * @package Apps\Controller\Admin
 */
class Feedback extends Controller
{
    const VERSION = '0.1';
    const ITEM_PER_PAGE = 10;

    public $type = 'app';

    /**
     * List feedback post messages with notifications
     * @return string
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionIndex()

    {
        // set current page and offset
        $page = (int)$this->request->query->get('page');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $offset = $page * self::ITEM_PER_PAGE;

        // get feedback posts AR table
        $query = new FeedbackPost();

        // build pagination
        $pagination = new SimplePagination([
            'url' => ['feedback/index'],
            'page' => $page,
            'step' => self::ITEM_PER_PAGE,
            'total' => $query->count()
        ]);

        // build listing objects
        $records = $query->orderBy('id', 'desc')->skip($offset)->take(self::ITEM_PER_PAGE)->get();

        // render output
        return $this->view->render('index', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'records' => $records,
            'pagination' => $pagination
        ]);
    }

    /**
     * Read feedback post and answer and add answer to thread post
     * @param int $id
     * @return string
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws NotFoundException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionRead($id)
    {
        // find feedback post by id
        $record = FeedbackPost::find($id);
        if ($record === null || $record === false) {

            throw new NotFoundException(__('The feedback message is not founded'));
        }

        // initialize model with answer add if thread is not closed
        $model = null;
        if ((int)$record->closed !== 1) {
            $model = new FormAnswerAdd($record, App::$User->identity()->getId());
            if ($model->send()) {
                if ($model->validate()) {
                    $model->make();
                    App::$Session->getFlashBag()->add('success', __('New answer is successful add'));
                } else {
                    App::$Session->getFlashBag()->add('error', 'Validation failure');
                }
            }
        }

        // render view
        return $this->view->render('read', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'record' => $record,
            'model' => $model
        ]);
    }

    /**
     * Edit feedback post or answer
     * @param string $type
     * @param int $id
     * @return string
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws NotFoundException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionUpdate($type, $id)
    {
        // get active record based on type (post or answer for post)
        $record = null;
        $postId = $id;
        switch ($type) {
            case 'post':
                $record = FeedbackPost::find($id);
                break;
            case 'answer':
                $record = FeedbackAnswer::find($id);
                if ($record !== null && $record !== false) {
                    $postId = (int)$record->getFeedbackPost()->id;
                }
                break;
        }

        // try what we got
        if ($record === null || $record === false) {

            throw new NotFoundException(__('Feedback item is not founded'));
        }

        // initialize model
        $model = new FormUpdate($record);
        if ($model->send()) {
            if ($model->validate()) {
                $model->make();
                App::$Session->getFlashBag()->add('success', __('Feedback item are successful changed'));
                $this->response->redirect('feedback/read/' . $postId);

            } else {
                App::$Session->getFlashBag()->add('danger', __('Updating is failed'));
            }
        }

        // render output view
        return $this->view->render('update', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'model' => $model->filter()
        ]);
    }

    /**
     * Turn feedback request post - close, open, readed
     * @param string $direction
     * @param int $id
     * @return null
     * @throws NotFoundException
     */
    public function actionTurn($direction, $id)
    {
        // try to find record
        $record = FeedbackPost::find($id);
        if ($record === null || $record === false) {

            throw new NotFoundException(__('Feedback request with id %id% is not found', ['id' => $id]));
        }

        // switch operation direction to what we must change
        switch ($direction) {
            case 'open':
                $record->closed = 0;
                $record->save();
                break;
            case 'close':
                $record->closed = 1;
                $record->save();
                break;
            case 'read':
                $record->readed = 1;
                $record->save();
                break;
            default:
                throw new NotFoundException(__('Hack attention'));
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }

        // add notification of successful changes
        App::$Session->getFlashBag()->add('success', __('Feedback request is changed!'));

        // redirect to feedback post read
        $this->response->redirect('feedback/read/' . $id);

        return null;
    }

    /**
     * Delete feedback post or answer
     * @param string $type
     * @param int $id
     * @return string
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws NotFoundException
     * @throws \Exception
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionDelete($type, $id)
    {
        // try to get active record by type
        $record = null;
        switch ($type) {
            case 'post':
                $record = FeedbackPost::find($id);
                break;
            case 'answer':
                $record = FeedbackAnswer::find($id);
                break;
        }

        // check if we get the row
        if ($record === null || $record === false) {

            throw new NotFoundException(__('Feedback item is not founded'));
        }

        // if delete is submited
        if ($this->request->request->get('deleteFeedback')) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            // remove all answers
            if ($type === 'post') {
                FeedbackAnswer::where('feedback_id', '=', $record->id)->delete();
                // remove item
                $record->delete();
                App::$Session->getFlashBag()->add('success', __('Feedback record is successful removed'));
                $this->response->redirect('feedback/index');

            } else {
                // its a answer, lets remove it and redirect back in post
                $postId = $record->feedback_id;
                $record->delete();
                $this->response->redirect('feedback/read/' . $postId);

            }
        }

        // render view
        return $this->view->render('delete', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'type' => $type,
            'record' => $record
        ]);
    }

    /**
     * Settings of feedback application
     * @return string
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionSettings()

    {
        // initialize model and pass configs
        $model = new FormSettings($this->getConfigs());

        // check if form is submited to save data
        if ($model->send()) {
            // is validation passed?
            if ($model->validate()) {
                // save properties
                $this->setConfigs($model->getAllProperties());
                App::$Session->getFlashBag()->add('success', __('Settings is successful updated'));
                $this->response->redirect('feedback/index');

            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render view
        return $this->view->render('settings', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'model' => $model->filter()
        ]);
    }

}

1		<?php
2
3
4		namespace Apps\Controller\Admin;
5
6		use Apps\ActiveRecord\FeedbackAnswer;
7		use Apps\Model\Admin\Feedback\FormAnswerAdd;
8		use Apps\Model\Admin\Feedback\FormSettings;
9		use Apps\Model\Admin\Feedback\FormUpdate;
10		use Extend\Core\Arch\AdminController as Controller;
11		use Ffcms\Core\App;
12		use Apps\ActiveRecord\FeedbackPost;
13		use Ffcms\Core\Exception\NotFoundException;
14		use Ffcms\Core\Helper\HTML\SimplePagination;
15
16		/**
17		* Class Feedback. Control and manage feedback request and answers.
18		* @package Apps\Controller\Admin
19		*/
20		class Feedback extends Controller
21		{
22		const VERSION = '0.1';
23		const ITEM_PER_PAGE = 10;
24
25		public $type = 'app';
26
27		/**
28		* List feedback post messages with notifications
29		* @return string
30		* @throws \Ffcms\Core\Exception\NativeException
31		* @throws \Ffcms\Core\Exception\SyntaxException
32		*/
33	View Code Duplication	public function actionIndex()
		0 ignored issues – show Duplication introduced 2016-02-19 13:03 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		// set current page and offset
36		$page = (int)$this->request->query->get('page');
		0 ignored issues – show Documentation introduced 2016-07-18 12:18 UTC by Report Bug Copy Issue Report The property `request` does not exist on `object<Apps\Controller\Admin\Feedback>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
37		$offset = $page * self::ITEM_PER_PAGE;
38

phpffcms / ffcms

Push — master ( 02a4a5...734a7e )

Feedback::actionSettings() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like