Apps\Controller\Admin\User

Complexity

Total Complexity

23

Size/Duplication

Total Lines	215
Duplicated Lines	56.74 %

Coupling/Cohesion

Components	1
Dependencies	16

Importance

Changes	12
Bugs	5	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	actionUpdate()	24	24	3
A	actionGrouplist()	0	9	1
A	actionGroupUpdate()	20	20	3
B	actionInvite()	22	22	4
B	actionIndex()	26	26	1
C	actionDelete()	10	34	8
A	actionSettings()	20	20	3

<?php

namespace Apps\Controller\Admin;

use Apps\ActiveRecord\Role;
use Apps\Model\Admin\User\FormInviteSend;
use Apps\Model\Admin\User\FormUserDelete;
use Apps\Model\Admin\User\FormUserGroupUpdate;
use Apps\Model\Admin\User\FormUserSettings;
use Apps\Model\Admin\User\FormUserUpdate;
use Extend\Core\Arch\AdminController;
use Apps\ActiveRecord\User as UserRecords;
use Ffcms\Core\App;
use Ffcms\Core\Exception\NotFoundException;
use Ffcms\Core\Helper\HTML\SimplePagination;
use Ffcms\Core\Helper\Type\Arr;
use Ffcms\Core\Helper\Type\Obj;


/**
 * Class User. Admin controller of user application.
 * @package Apps\Controller\Admin
 */
class User extends AdminController
{
    const VERSION = 0.1;
    const ITEM_PER_PAGE = 10;

    public $type = 'app';

    /**
     * List all users as table
     * @return string
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionIndex()

This method seems to be duplicated in your project.

    {
        // init Active Record
        $query = new UserRecords();

        // set current page and offset
        $page = (int)$this->request->query->get('page', 0);

The property request does not exist on object<Apps\Controller\Admin\User>. Since you implemented __get, maybe consider adding a @property annotation.

        $offset = $page * self::ITEM_PER_PAGE;

        // build pagination
        $pagination = new SimplePagination([
            'url' => ['user/index'],
            'page' => $page,
            'step' => self::ITEM_PER_PAGE,
            'total' => $query->count()
        ]);

        // build listing objects
        $records = $query->orderBy('id', 'desc')->skip($offset)->take(self::ITEM_PER_PAGE)->get();

        // display viewer
        return $this->view->render('index', [

The property view does not exist on object<Apps\Controller\Admin\User>. Since you implemented __get, maybe consider adding a @property annotation.

            'records' => $records,
            'pagination' => $pagination
        ]);
    }

    /**
     * Edit user profile by id
     * @param int $id
     * @return string
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionUpdate($id)

This method seems to be duplicated in your project.

    {
        $user = UserRecords::findOrNew($id);

        // find user identify object
        //$user = App::$User->identity($id);

62% of this comment could be valid code. Did you maybe forget this after debugging?

        // generate model data based on user object
        $model = new FormUserUpdate($user);

        // check is form is sended
        if ($model->send()) {
            if ($model->validate()) { // check validation
                $model->save();
                App::$Session->getFlashBag()->add('success', __('Data was successful updated'));
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render viewer
        return $this->view->render('user_update', [

The property view does not exist on object<Apps\Controller\Admin\User>. Since you implemented __get, maybe consider adding a @property annotation.

            'model' => $model->filter()
        ]);
    }

    /**
     * Delete user row from database
     * @param int $id
     * @return string
     * @throws \Ffcms\Core\Exception\SyntaxException
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws NotFoundException
     */
    public function actionDelete($id = null)
    {
        // check if id is passed or get data from GET as array ids
        if ($id === 0 || (int)$id < 1) {

This code seems to be duplicated across your project.

            $ids = $this->request->query->get('selected');

The property request does not exist on object<Apps\Controller\Admin\User>. Since you implemented __get, maybe consider adding a @property annotation.

            if (Obj::isArray($ids) && Arr::onlyNumericValues($ids)) {
                $id = $ids;
            } else {
                throw new NotFoundException('Bad conditions');
            }
        } else {
            $id = [$id];
        }

        // initialize delete model
        $model = new FormUserDelete($id);

        // check if users is found
        if ($model->users === null) {
            throw new NotFoundException(__('Users are not found'));
        }

        // check if delete is submited
        if ($model->send() && $model->validate()) {
            $model->delete();
            App::$Session->getFlashBag()->add('success', __('Users and them data are successful removed'));
            $this->response->redirect('user/index');

The method redirect cannot be called on $this->response (of type string).

        }

        // set view response
        return $this->view->render('user_delete', [

The property view does not exist on object<Apps\Controller\Admin\User>. Since you implemented __get, maybe consider adding a @property annotation.

            'model' => $model
        ]);
    }

    /**
     * Show all role groups
     * @return string
     * @throws \Ffcms\Core\Exception\NativeException
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function actionGrouplist()
    {
        // get all roles
        $roles = Role::getAll();

        return $this->view->render('group_list', [

The property view does not exist on object<Apps\Controller\Admin\User>. Since you implemented __get, maybe consider adding a @property annotation.

            'records' => $roles
        ]);
    }

    /**
     * Edit and add groups
     * @param int $id
     * @return string
     * @throws \Ffcms\Core\Exception\SyntaxException
     * @throws \Ffcms\Core\Exception\NativeException
     */
    public function actionGroupUpdate($id)

This method seems to be duplicated in your project.

    {
        // find role or create new object
        $role = Role::findOrNew($id);

        $model = new FormUserGroupUpdate($role);
        if ($model->send()) { // work with post request
            if ($model->validate()) {
                $model->save();
                App::$Session->getFlashBag()->add('success', __('Data was successful updated'));
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render view
        return $this->view->render('group_update', [

The property view does not exist on object<Apps\Controller\Admin\User>. Since you implemented __get, maybe consider adding a @property annotation.

            'model' => $model->filter()
        ]);
    }

    /**
     * User identity settings
     * @return string
     * @throws \Ffcms\Core\Exception\SyntaxException
     * @throws \Ffcms\Core\Exception\NativeException
     */
    public function actionSettings()

This method seems to be duplicated in your project.

    {
        // load model and pass property's as argument
        $model = new FormUserSettings($this->getConfigs());

        if ($model->send()) {
            if ($model->validate()) {
                $this->setConfigs($model->getAllProperties());
                App::$Session->getFlashBag()->add('success', __('Settings is successful updated'));
                $this->response->redirect('user/index');

The method redirect cannot be called on $this->response (of type string).

            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render view
        return $this->view->render('settings', [

The property view does not exist on object<Apps\Controller\Admin\User>. Since you implemented __get, maybe consider adding a @property annotation.

            'model' => $model->filter()
        ]);
    }

    /**
     * Send invite to user by email
     * @return string
     * @throws \Ffcms\Core\Exception\SyntaxException
     * @throws \Ffcms\Core\Exception\NativeException
     */
    public function actionInvite()

This method seems to be duplicated in your project.

    {
        // init model
        $model = new FormInviteSend();

        if ($model->send()) {
            if ($model->validate()) {
                if ($model->make()) {
                    App::$Session->getFlashBag()->add('success', __('Invite was successful send!'));
                } else {
                    App::$Session->getFlashBag()->add('error', __('Mail server connection is failed!'));
                }
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render view
        return $this->view->render('invite', [

The property view does not exist on object<Apps\Controller\Admin\User>. Since you implemented __get, maybe consider adding a @property annotation.

            'model' => $model->filter()
        ]);
    }
}