Passed
Push — master ( 10220a...9ad793 )
by Mihail
05:11
created
Apps/Model/Install/Main/FormInstall.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Apps\ActiveRecord\Profile;
6 6
 use Apps\ActiveRecord\User;
7
-use Apps\Controller\Console\Db;
8 7
 use Ffcms\Core\App;
9 8
 use Ffcms\Core\Arch\Model;
10 9
 use Ffcms\Core\Helper\FileSystem\File;
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -71,14 +71,14 @@
 block discarded – undo
71 71
         $cfg['database'] = $this->db;
72 72
         $cfg['adminEmail'] = $this->email;
73 73
         $cfg['singleLanguage'] = $this->singleLanguage;
74
-        $cfg['multiLanguage'] = (bool)$this->multiLanguage;
75
-        $cfg['passwordSalt'] = '$2a$07$' . Str::randomLatinNumeric(mt_rand(21, 30)) . '$';
76
-        $cfg['debug']['cookie']['key'] = 'fdebug_' . Str::randomLatinNumeric(mt_rand(4, 16));
74
+        $cfg['multiLanguage'] = (bool) $this->multiLanguage;
75
+        $cfg['passwordSalt'] = '$2a$07$'.Str::randomLatinNumeric(mt_rand(21, 30)).'$';
76
+        $cfg['debug']['cookie']['key'] = 'fdebug_'.Str::randomLatinNumeric(mt_rand(4, 16));
77 77
         $cfg['debug']['cookie']['value'] = Str::randomLatinNumeric(mt_rand(32, 128));
78 78
 
79 79
         // import database tables
80 80
         $connectName = 'install';
81
-        include(root . '/Private/Database/install.php');
81
+        include(root.'/Private/Database/install.php');
82 82
 
83 83
         // insert admin user
84 84
         $user = new User();
Please login to merge, or discard this patch.
Apps/Model/Install/Main/EntityCheck.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,8 +20,8 @@
 block discarded – undo
20 20
     public $chmodCheck = [];
21 21
 
22 22
     /**
23
-    * Get default server information and prepare chmod info
24
-    */
23
+     * Get default server information and prepare chmod info
24
+     */
25 25
     public function before()
26 26
     {
27 27
         $this->phpVersion = phpversion();
Please login to merge, or discard this patch.
Apps/View/Install/default/main/index.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 ]);
55 55
 ?>
56 56
 
57
-<?php if($model->checkAll()): ?>
57
+<?php if ($model->checkAll()): ?>
58 58
     <?= \Ffcms\Core\Helper\Url::link('main/install', __('Start install'), ['class' => 'btn btn-success btn-block']) ?>
59 59
 <?php else: ?>
60 60
     <?= \Ffcms\Core\Helper\Url::link('main/index', __('Check again'), ['class' => 'btn btn-warning btn-block']) ?>
Please login to merge, or discard this patch.
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,10 @@
 block discarded – undo
56 56
 
57 57
 <?php if($model->checkAll()): ?>
58 58
     <?= \Ffcms\Core\Helper\Url::link('main/install', __('Start install'), ['class' => 'btn btn-success btn-block']) ?>
59
-<?php else: ?>
59
+<?php else {
60
+    : ?>
60 61
     <?= \Ffcms\Core\Helper\Url::link('main/index', __('Check again'), ['class' => 'btn btn-warning btn-block']) ?>
61
-<?php endif; ?>
62
+<?php endif;
63
+}
64
+?>
62 65
 
Please login to merge, or discard this patch.
Private/Database/Tables/Session.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 Illuminate\Database\Capsule\Manager::schema($connectName)->create('sessions', function($table) {
4
-    $table->string('sess_id', 128)->index()->primary()  ;
4
+    $table->string('sess_id', 128)->index()->primary();
5 5
     $table->binary('sess_data');
6 6
     $table->string('sess_lifetime', 16); // shutout to laravel, if i make it like "integer" it automaticlly add "primary" key for it, hate this!!!
7 7
     $table->string('sess_time', 16);
Please login to merge, or discard this patch.
Apps/View/Front/default/content/read.php 3 patches
Braces   +10 added lines, -4 removed lines patch added patch discarded remove patch
@@ -67,17 +67,23 @@
 block discarded – undo
67 67
         <?php if ($properties['author'] === true): ?>
68 68
             <?php if ($model->authorId !== null && $model->authorId > 0): ?>
69 69
                 <span><i class="fa fa-user"></i><?= Url::link(['profile/show', $model->authorId], $model->authorName, ['itemprop' => 'author']) ?></span>
70
-            <?php else: ?>
70
+            <?php else {
71
+    : ?>
71 72
                 <span><i class="fa fa-user"></i><s><?= $model->authorName ?></s></span>
72
-            <?php endif; ?>
73
+            <?php endif;
74
+}
75
+?>
73 76
         <?php endif; ?>
74 77
         <?php if ($properties['views'] === true): ?>
75 78
         <span><i class="fa fa-eye"></i><?= $model->views ?></span>
76 79
         <?php endif ?>
77 80
     </div>
78
-    <?php else: ?>
81
+    <?php else {
82
+    : ?>
79 83
     <hr />
80
-    <?php endif; ?>
84
+    <?php endif;
85
+}
86
+?>
81 87
     <?php if ($trash): ?>
82 88
     <p class="alert alert-danger"><i class="fa fa-trash-o"></i> <?= __('This content is placed in trash') ?></p>
83 89
     <?php endif; ?>
Please login to merge, or discard this patch.
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -159,12 +159,12 @@
 block discarded – undo
159 159
     	<div class="col-md-12">
160 160
     		<div class="pull-left">
161 161
         	<?php if ($properties['rating']) {
162
-        	    echo \App::$View->render('content/_rate', [
163
-        	        'id' => $model->id,
164
-        	        'rating' => $model->rating,
165
-        	        'canRate' => $model->canRate
166
-        	    ]);
167
-        	} ?>
162
+                echo \App::$View->render('content/_rate', [
163
+                    'id' => $model->id,
164
+                    'rating' => $model->rating,
165
+                    'canRate' => $model->canRate
166
+                ]);
167
+            } ?>
168 168
         	<?= \App::$View->render('content/_rateJs') ?>
169 169
     		</div>
170 170
     		<div class="pull-right">
Please login to merge, or discard this patch.
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 }
24 24
 
25 25
 // don't use breadcrumbs on injected pathway rule
26
-if (!\App::$Request->isPathInjected() && (bool)$model->getCategory()->getProperty('showCategory')) {
26
+if (!\App::$Request->isPathInjected() && (bool) $model->getCategory()->getProperty('showCategory')) {
27 27
     $breadcrumbs = [
28 28
             Url::to('/') => __('Home')
29 29
     ];
@@ -35,22 +35,22 @@  discard block
 block discarded – undo
35 35
                 $breadcrumbs[Url::to('content/list', $cat['path'], null, [], false)] = $cat['name'];
36 36
             }
37 37
         }
38
-        $breadcrumbs[] = __('Content') . ': ' . Str::sub($this->title, 0, 40);
38
+        $breadcrumbs[] = __('Content').': '.Str::sub($this->title, 0, 40);
39 39
     }
40 40
 
41 41
     $this->breadcrumbs = $breadcrumbs;
42 42
 }
43 43
 
44 44
 $properties = [
45
-    'date' => (bool)$model->getCategory()->getProperty('showDate'),
46
-    'author' => (bool)$model->getCategory()->getProperty('showAuthor'),
47
-    'views' => (bool)$model->getCategory()->getProperty('showViews'),
48
-    'category' => (bool)$model->getCategory()->getProperty('showCategory'),
49
-    'rating' => (bool)$model->getCategory()->getProperty('showRating'),
50
-    'tags' => (bool)$model->getCategory()->getProperty('showTags')
45
+    'date' => (bool) $model->getCategory()->getProperty('showDate'),
46
+    'author' => (bool) $model->getCategory()->getProperty('showAuthor'),
47
+    'views' => (bool) $model->getCategory()->getProperty('showViews'),
48
+    'category' => (bool) $model->getCategory()->getProperty('showCategory'),
49
+    'rating' => (bool) $model->getCategory()->getProperty('showRating'),
50
+    'tags' => (bool) $model->getCategory()->getProperty('showTags')
51 51
 ];
52
-$showComments = (bool)$model->getCategory()->getProperty('showComments');
53
-$showPoster = (bool)$model->getCategory()->getProperty('showPoster');
52
+$showComments = (bool) $model->getCategory()->getProperty('showComments');
53
+$showPoster = (bool) $model->getCategory()->getProperty('showPoster');
54 54
 
55 55
 ?>
56 56
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
         <span class="spaced"><i class="fa fa-eye"></i> <?= $model->views ?></span>
76 76
         <?php endif ?>
77 77
         <?php if (\App::$User->isAuth() && \App::$User->identity()->getRole()->can('Admin/Content/Update')): ?>
78
-        <span class="pull-right"><a href="<?= \App::$Alias->scriptUrl . '/admin/content/update/' . $model->id ?>" target="_blank"><i class="fa fa-pencil" style="color: #ff0000;"></i></a></span>
78
+        <span class="pull-right"><a href="<?= \App::$Alias->scriptUrl.'/admin/content/update/'.$model->id ?>" target="_blank"><i class="fa fa-pencil" style="color: #ff0000;"></i></a></span>
79 79
         <?php endif; ?>
80 80
     </div>
81 81
     <?php else: ?>
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
     <div id="content-text">
88 88
         <?php if ($showPoster === true && $model->posterFull !== null && $model->posterThumb !== null): ?>
89 89
             <a href="#showPoster" data-toggle="modal" data-target="#showPoster">
90
-                <img alt="<?= __('Poster for') ?>: <?= Str::lowerCase(\App::$Security->strip_tags($model->title)) ?>" src="<?= \App::$Alias->scriptUrl . $model->posterThumb ?>" class="image_poster img-thumbnail" />
90
+                <img alt="<?= __('Poster for') ?>: <?= Str::lowerCase(\App::$Security->strip_tags($model->title)) ?>" src="<?= \App::$Alias->scriptUrl.$model->posterThumb ?>" class="image_poster img-thumbnail" />
91 91
             </a>
92 92
 
93 93
             <!-- Modal poster pop-up -->
@@ -99,19 +99,19 @@  discard block
 block discarded – undo
99 99
                             <h4 class="modal-title" id="myModalLabel"><?= __('View poster') ?></h4>
100 100
                         </div>
101 101
                         <div class="modal-body">
102
-                            <img class="img-responsive" src="<?= \App::$Alias->scriptUrl . $model->posterFull ?>" alt="<?= __('Poster image') ?>" style="margin: 0 auto;" />
102
+                            <img class="img-responsive" src="<?= \App::$Alias->scriptUrl.$model->posterFull ?>" alt="<?= __('Poster image') ?>" style="margin: 0 auto;" />
103 103
                         </div>
104 104
                     </div>
105 105
                 </div>
106 106
             </div>
107
-        <?php endif ;?>
107
+        <?php endif; ?>
108 108
         <?= $model->text ?>
109 109
     </div>
110 110
     <?php if ($model->galleryItems !== null && Obj::isArray($model->galleryItems)): ?>
111 111
         <div class="row">
112 112
         <?php foreach ($model->galleryItems as $thumbPic => $fullPic): ?>
113 113
             <div class="col-md-2 well">
114
-                <a href="#showGallery" class="modalGallery" content="<?= \App::$Alias->scriptUrl . $fullPic ?>"><img src="<?= \App::$Alias->scriptUrl . $thumbPic ?>" class="img-responsive image-item" /></a>
114
+                <a href="#showGallery" class="modalGallery" content="<?= \App::$Alias->scriptUrl.$fullPic ?>"><img src="<?= \App::$Alias->scriptUrl.$thumbPic ?>" class="img-responsive image-item" /></a>
115 115
             </div>
116 116
         <?php endforeach; ?>
117 117
         </div>
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
                         <h4 class="modal-title" id="showModalLabel"><?= __('View picture') ?></h4>
124 124
                     </div>
125 125
                     <div class="modal-body" id="modal-gallery-body">
126
-                        <img class="img-responsive" src="<?= \App::$Alias->scriptUrl . $model->posterFull ?>" alt="<?= __('Gallery picture') ?>" style="margin: 0 auto;" />
126
+                        <img class="img-responsive" src="<?= \App::$Alias->scriptUrl.$model->posterFull ?>" alt="<?= __('Gallery picture') ?>" style="margin: 0 auto;" />
127 127
                     </div>
128 128
                 </div>
129 129
             </div>
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
                 </div>
145 145
                 <div id="similar<?= $idx ?>" class="panel-collapse collapse">
146 146
                     <div class="panel-body">
147
-                        <a href="<?= \App::$Alias->baseUrl . $item['uri'] ?>">
147
+                        <a href="<?= \App::$Alias->baseUrl.$item['uri'] ?>">
148 148
                             <?= $item['snippet'] ?>
149 149
                         </a>
150 150
                     </div>
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
                         echo '<i class="fa fa-tags hidden-xs"></i> ';
176 176
                         foreach ($model->metaKeywords as $tag) {
177 177
                             $tag = \App::$Security->strip_tags(trim($tag));
178
-                            echo Url::link(['content/tag', $tag], $tag, ['class' => 'label label-default']) . "&nbsp;";
178
+                            echo Url::link(['content/tag', $tag], $tag, ['class' => 'label label-default'])."&nbsp;";
179 179
                         }
180 180
                     }
181 181
                     ?>
Please login to merge, or discard this patch.
Apps/Model/Admin/Application/FormInstall.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,8 +33,8 @@
 block discarded – undo
33 33
     }
34 34
 
35 35
     /**
36
-    * Validation rules
37
-    */
36
+     * Validation rules
37
+     */
38 38
     public function rules()
39 39
     {
40 40
         return [
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
     public function before()
40 40
     {
41 41
         foreach ($this->_apps as $app) {
42
-            $this->_definedControllers[] = (string)$app->sys_name;
42
+            $this->_definedControllers[] = (string) $app->sys_name;
43 43
         }
44 44
 
45 45
         parent::before();
@@ -70,14 +70,14 @@  discard block
 block discarded – undo
70 70
     public function make()
71 71
     {
72 72
         $cName = ucfirst(Str::lowerCase($this->sysname));
73
-        $cPath = 'Apps\Controller\Admin\\' . $cName;
73
+        $cPath = 'Apps\Controller\Admin\\'.$cName;
74 74
         // if object class is not loaded - prevent install
75
-        if (!class_exists($cPath) || !defined($cPath . '::VERSION')) {
75
+        if (!class_exists($cPath) || !defined($cPath.'::VERSION')) {
76 76
             return false;
77 77
         }
78 78
 
79 79
         // get ext version
80
-        $cVersion = (float)constant($cPath . '::VERSION');
80
+        $cVersion = (float) constant($cPath.'::VERSION');
81 81
         if ($cVersion < 0.1) {
82 82
             $cVersion = 0.1;
83 83
         }
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 
94 94
         // callback to install method in extension
95 95
         if (method_exists($cPath, 'install')) {
96
-            call_user_func($cPath . '::install');
96
+            call_user_func($cPath.'::install');
97 97
         }
98 98
 
99 99
         return true;
Please login to merge, or discard this patch.
Apps/Controller/Admin/Content.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use Ffcms\Core\App;
10 10
 use Ffcms\Core\Exception\SyntaxException;
11 11
 use Ffcms\Core\Helper\FileSystem\File;
12
-use Ffcms\Core\Helper\Type\Arr;
13 12
 use Ffcms\Core\Helper\Type\Integer;
14 13
 use Ffcms\Core\Helper\Type\Str;
15 14
 
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
     public function actionIndex()
41 41
     {
42 42
         // set current page and offset
43
-        $page = (int)$this->request->query->get('page');
43
+        $page = (int) $this->request->query->get('page');
44 44
         $offset = $page * self::ITEM_PER_PAGE;
45 45
 
46 46
         $query = null;
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
         } elseif ($type === 'moderate') { // only items on moderate
52 52
             $query = ContentEntity::where('display', '=', 0);
53 53
         } elseif (Obj::isLikeInt($type)) { // sounds like category id ;)
54
-            $query = ContentEntity::where('category_id', '=', (int)$type);
54
+            $query = ContentEntity::where('category_id', '=', (int) $type);
55 55
         } else {
56 56
             $query = new ContentEntity();
57 57
             $type = 'all';
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
         if ($model->send() && $model->validate()) {
198 198
             // remove all trashed items
199 199
             foreach ($records->get() as $item) {
200
-                $galleryPath = '/upload/gallery/' . (int)$item->id;
200
+                $galleryPath = '/upload/gallery/'.(int) $item->id;
201 201
                 if (Directory::exist($galleryPath)) {
202 202
                     Directory::remove($galleryPath);
203 203
                 }
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
     public function actionCategoryupdate($id = null)
275 275
     {
276 276
         // get owner id for new rows
277
-        $parentId = (int)$this->request->query->get('parent');
277
+        $parentId = (int) $this->request->query->get('parent');
278 278
 
279 279
         // get relation and pass to model
280 280
         $record = ContentCategory::findOrNew($id);
Please login to merge, or discard this patch.
Extend/Core/Arch/AdminController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@
 block discarded – undo
123 123
     /**
124 124
      * Get current extension active record
125 125
      * @param string|null $type
126
-     * @return mixed
126
+     * @return AppRecord
127 127
      */
128 128
     public function getTypeItem($type = null)
129 129
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -86,18 +86,18 @@  discard block
 block discarded – undo
86 86
         $user = App::$User->identity();
87 87
         // user is not authed ?
88 88
         if ($user === null || !App::$User->isAuth()) {
89
-            $redirectUrl = App::$Alias->scriptUrl . '/user/login';
89
+            $redirectUrl = App::$Alias->scriptUrl.'/user/login';
90 90
             App::$Response->redirect($redirectUrl, true);
91 91
             exit();
92 92
         }
93 93
 
94
-        $permission = env_name . '/' . App::$Request->getController() . '/' . App::$Request->getAction();
94
+        $permission = env_name.'/'.App::$Request->getController().'/'.App::$Request->getAction();
95 95
 
96 96
         // doesn't have permission? get the f*ck out
97 97
         if (!$user->getRole()->can($permission)) {
98 98
             App::$Session->invalidate();
99 99
 
100
-            $redirectUrl = App::$Alias->scriptUrl . '/user/login';
100
+            $redirectUrl = App::$Alias->scriptUrl.'/user/login';
101 101
             App::$Response->redirect($redirectUrl, true);
102 102
             exit();
103 103
         }
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
      */
145 145
     public function getConfigs()
146 146
     {
147
-        return $this->type === 'widget' ? (array)Serialize::decode($this->widget->configs) : (array)Serialize::decode($this->application->configs);
147
+        return $this->type === 'widget' ? (array) Serialize::decode($this->widget->configs) : (array) Serialize::decode($this->application->configs);
148 148
     }
149 149
 
150 150
     /**
Please login to merge, or discard this patch.
Apps/Controller/Admin/Application.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         $search = \Apps\ActiveRecord\App::getItem('app', $controller);
72 72
 
73 73
         // check what we got
74
-        if ($search === null || (int)$search->id < 1) {
74
+        if ($search === null || (int) $search->id < 1) {
75 75
             throw new ForbiddenException('App is not founded');
76 76
         }
77 77
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 
97 97
         $search = \Apps\ActiveRecord\App::where('sys_name', '=', $controllerName)->where('type', '=', 'app')->first();
98 98
 
99
-        if ($search === null || (int)$search->id < 1) {
99
+        if ($search === null || (int) $search->id < 1) {
100 100
             throw new ForbiddenException('App is not founded');
101 101
         }
102 102
 
Please login to merge, or discard this patch.