Apps\Model\Api\Comments\CommentAnswerAdd

Complexity

Total Complexity

22

Size/Duplication

Total Lines	114
Duplicated Lines	26.32 %

Coupling/Cohesion

Components	1
Dependencies	15

Importance

Changes	4
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	before()	7	7	2
C	check()	23	51	13
B	buildRecord()	0	27	6

<?php

namespace Apps\Model\Api\Comments;


use Apps\ActiveRecord\CommentAnswer;
use Apps\ActiveRecord\CommentPost;
use Apps\Model\Front\Profile\EntityAddNotification;
use Ffcms\Core\App;
use Ffcms\Core\Arch\Model;
use Ffcms\Core\Exception\JsonException;
use Ffcms\Core\Helper\Date;
use Ffcms\Core\Helper\Text;
use Ffcms\Core\Helper\Type\Str;

/**
 * Class CommentAnswerAdd. Model to add comment answer to database and build response active record row.
 * @package Apps\Model\Api\Comments
 */
class CommentAnswerAdd extends Model
{
    public $message;
    public $replayTo = 0;
    public $guestName;
    public $ip;

    private $_configs;
    private $_userId = 0;

    public function __construct(array $configs)
    {
        $this->_configs = $configs;
        parent::__construct();
    }

    public function before()

This method seems to be duplicated in your project.

    {
        $this->ip = App::$Request->getClientIp();
        if (App::$User->isAuth()) {
            $this->_userId = App::$User->identity()->getId();
        }
    }

    /**
     * Check if comment answer conditions is ok. Will throw exception if not.
     * @return bool
     * @throws JsonException
     */
    public function check()
    {
        // check if user is auth'd or guest name is defined
        if (!App::$User->isAuth() && ((int)$this->_configs['guestAdd'] !== 1 || Str::length($this->guestName) < 2)) {

This code seems to be duplicated across your project.

            throw new JsonException(__('Guest name is not defined'));
        }

        // guest moderation
        if (!App::$User->isAuth() && (bool)$this->_configs['guestModerate']) {

This code seems to be duplicated across your project.

            $captcha = App::$Request->request->get('captcha');
            if (!App::$Captcha->validate($captcha)) {
                throw new JsonException(__('Captcha is incorrect! Click on image to refresh and try again'));
            }
        }

        // check if replayTo is defined
        if ($this->replayTo < 1) {
            throw new JsonException(__('Comment post thread is not founded'));
        }

        // check if message length is correct
        if (Str::length($this->message) < (int)$this->_configs['minLength'] || Str::length($this->message) > (int)$this->_configs['maxLength']) {

This code seems to be duplicated across your project.

            throw new JsonException(__('Message length is incorrect. Current: %cur%, min - %min%, max - %max%', [
                'cur' => Str::length($this->message),
                'min' => $this->_configs['minLength'],
                'max' => $this->_configs['maxLength']
            ]));
        }

        $count = CommentPost::where('id', '=', $this->replayTo)->count();
        if ($count !== 1) {
            throw new JsonException(__('Comment post thread is not founded'));
        }

        // check to prevent spam
        $query = CommentAnswer::where('user_id', '=', $this->_userId)
            ->orWhere('ip', '=', $this->ip)
            ->orderBy('created_at', 'DESC')
            ->first();

        // something is founded :D
        if ($query !== null) {

This code seems to be duplicated across your project.

            $answerTime = Date::convertToTimestamp($query->created_at);
            $delay = $answerTime + $this->_configs['delay'] - time();
            if ($delay > 0) { // sounds like config time is not passed now
                throw new JsonException(__('Spam protection: please, wait %sec% seconds', ['sec' => $delay]));
            }
        }

        return true;
    }

    /**
     * Add comment answer to database and return active record object
     * @return CommentAnswer
     */
    public function buildRecord()
    {
        $record = new CommentAnswer();
        $record->comment_id = $this->replayTo;
        $record->user_id = $this->_userId;
        $record->guest_name = $this->guestName;
        $record->message = $this->message;
        $record->lang = App::$Request->getLanguage();
        $record->ip = $this->ip;
        // check if premoderation is enabled and user is guest
        if ((bool)$this->_configs['guestModerate'] && $this->_userId < 1) {
            $record->moderate = 1;
        }
        $record->save();

        // add notification for comment post owner
        $commentPost = $record->getCommentPost();
        if ($commentPost !== null && (int)$commentPost->user_id !== 0 && (int)$commentPost->user_id !== $this->_userId) {
            $notify = new EntityAddNotification((int)$commentPost->user_id);

(int) $commentPost->user_id is of type integer, but the function expects a boolean.

            $notify->add($commentPost->pathway, EntityAddNotification::MSG_ADD_COMMENTANSWER, [
                'snippet' => Text::snippet(App::$Security->strip_tags($this->message), 50),

It seems like \Ffcms\Core\App::$Security->strip_tags($this->message) targeting Ffcms\Core\Helper\Security::strip_tags() can also be of type array; however, Ffcms\Core\Helper\Text::snippet() does only seem to accept string, maybe add an additional type check?

                'post' => Text::snippet(App::$Security->strip_tags($commentPost->message), 50)

It seems like \Ffcms\Core\App::$Security->strip_tags($commentPost->message) targeting Ffcms\Core\Helper\Security::strip_tags() can also be of type array; however, Ffcms\Core\Helper\Text::snippet() does only seem to accept string, maybe add an additional type check?

            ]);
        }

        return $record;
    }

}