Apps\Controller\Admin\User

Complexity

Total Complexity

19

Size/Duplication

Total Lines	173
Duplicated Lines	64.16 %

Coupling/Cohesion

Components	1
Dependencies	18

Importance

Changes	4
Bugs	1	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	actionIndex()	26	26	1
B	actionUpdate()	24	24	3
B	actionDelete()	0	22	4
A	actionGrouplist()	0	9	1
A	actionGroupUpdate()	20	20	3
A	actionSettings()	19	19	3
B	actionInvite()	22	22	4

<?php

namespace Apps\Controller\Admin;

use Apps\ActiveRecord\Role;
use Apps\Model\Admin\User\FormInviteSend;
use Apps\Model\Admin\User\FormUserDelete;
use Apps\Model\Admin\User\FormUserGroupUpdate;
use Apps\Model\Admin\User\FormUserSettings;
use Apps\Model\Admin\User\FormUserUpdate;
use Extend\Core\Arch\AdminAppController;
use Apps\ActiveRecord\User as UserRecords;
use Ffcms\Core\App;
use Ffcms\Core\Exception\NotFoundException;
use Ffcms\Core\Helper\HTML\SimplePagination;


class User extends AdminAppController
{
    const ITEM_PER_PAGE = 10;

    // list users
    public function actionIndex()

This method seems to be duplicated in your project.

    {
        // init Active Record
        $query = new UserRecords();

        // set current page and offset
        $page = (int)App::$Request->query->get('page');
        $offset = $page * self::ITEM_PER_PAGE;

        // build pagination
        $pagination = new SimplePagination([
            'url' => ['user/index'],
            'page' => $page,
            'step' => self::ITEM_PER_PAGE,
            'total' => $query->count()

The method count does not exist on object<Apps\ActiveRecord\User>? Since you implemented __call, maybe consider adding a @method annotation.

        ]);

        // build listing objects
        $records = $query->orderBy('id', 'desc')->skip($offset)->take(self::ITEM_PER_PAGE)->get();

The method orderBy does not exist on object<Apps\ActiveRecord\User>? Since you implemented __call, maybe consider adding a @method annotation.

        // display viewer
        $this->response = App::$View->render('index', [
            'records' => $records,
            'pagination' => $pagination
        ]);
    }

    // edit user profiles
    public function actionUpdate($id)

This method seems to be duplicated in your project.

    {
        $user = UserRecords::findOrNew($id);

        // find user identify object
        //$user = App::$User->identity($id);

62% of this comment could be valid code. Did you maybe forget this after debugging?

        // generate model data based on user object
        $model = new FormUserUpdate($user);

$user is of type object<Illuminate\Support\Collection>|object<Illuminate\Database\Eloquent\Model>, but the function expects a object<Ffcms\Core\Interfaces\iUser>.

        // check is form is sended
        if ($model->send()) {
            if ($model->validate()) { // check validation
                $model->save();
                App::$Session->getFlashBag()->add('success', __('Data was successful updated'));
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render viewer
        $this->response = App::$View->render('user_update', [
            'model' => $model->export()
        ]);
    }

    /**
     * Delete user data
     * @param $id
     * @throws NotFoundException
     */
    public function actionDelete($id)
    {
        if ($id < !1 || !App::$User->isExist($id)) {
            throw new NotFoundException('User is not founded');
        }

        // get user object and load model
        $user = App::$User->identity($id);
        $model = new FormUserDelete($user);

It seems like $user defined by \Ffcms\Core\App::$User->identity($id) on line 88 can be null; however, Apps\Model\Admin\User\FormUserDelete::__construct() does not accept null, maybe add an additional type check?

        if ($model->send()) {
            $model->delete();
            App::$Response->redirect('user/index');
        } else {
            App::$Session->getFlashBag()->add('error', __('There is no way to revert this action! Be careful!'));
        }

        // set view response
        $this->response = App::$View->render('user_delete', [
            'model' => $model
        ]);
    }

    /**
     * Show all role groups
     */
    public function actionGrouplist()
    {
        // get all roles
        $roles = Role::getAll();

        $this->response = App::$View->render('group_list', [
            'records' => $roles
        ]);
    }

    /**
     * Edit and add groups
     * @param $id
     */
    public function actionGroupUpdate($id)

This method seems to be duplicated in your project.

    {
        // find role or create new object
        $role = Role::findOrNew($id);

        $model = new FormUserGroupUpdate($role);

$role is of type object<Illuminate\Support\Collection>|object<Illuminate\Database\Eloquent\Model>, but the function expects a object<Apps\ActiveRecord\Role>.

        if ($model->send()) { // work with post request
            if ($model->validate()) {
                $model->save();
                App::$Session->getFlashBag()->add('success', __('Data was successful updated'));
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render view
        $this->response = App::$View->render('group_update', [
            'model' => $model
        ]);
    }

    /**
     * User identity settings
     */
    public function actionSettings()

This method seems to be duplicated in your project.

    {
        // load model and pass property's as argument
        $model = new FormUserSettings($this->getConfigs());

        if ($model->send()) {
            if ($model->validate()) {
                $this->setConfigs($model->getAllProperties());
                App::$Response->redirect('user/index');
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render view
        $this->response = App::$View->render('settings', [
            'model' => $model->export()
        ]);
    }

    /**
     * Send invite to users
     */
    public function actionInvite()

This method seems to be duplicated in your project.

    {
        // init model
        $model = new FormInviteSend();

        if ($model->send()) {
            if ($model->validate()) {
                if ($model->make()) {
                    App::$Session->getFlashBag()->add('success', __('Invite was successful send!'));
                } else {
                    App::$Session->getFlashBag()->add('error', __('Mail server connection is failed!'));
                }
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render view
        $this->response = App::$View->render('invite', [
            'model' => $model
        ]);
    }
}