Apps\Controller\Admin\Profile

Complexity

Total Complexity

25

Size/Duplication

Total Lines	166
Duplicated Lines	39.76 %

Coupling/Cohesion

Components	1
Dependencies	18

Importance

Changes	3
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	actionIndex()	26	26	1
A	actionDelete()	0	4	1
C	actionUpdate()	0	32	8
A	actionFieldlist()	0	8	1
B	actionFieldupdate()	23	23	5
B	actionFielddelete()	0	24	6
A	actionSettings()	17	17	3

<?php

namespace Apps\Controller\Admin;

use Apps\ActiveRecord\ProfileField;
use Apps\Model\Admin\Profile\FormFieldUpdate;
use Apps\Model\Admin\Profile\FormSettings;
use Apps\Model\Front\Profile\FormSettings as FrontFormSettings;
use Extend\Core\Arch\AdminAppController;
use Apps\ActiveRecord\Profile as ProfileRecords;
use Ffcms\Core\App;
use Ffcms\Core\Exception\ForbiddenException;
use Ffcms\Core\Exception\NotFoundException;
use Ffcms\Core\Helper\HTML\SimplePagination;
use Ffcms\Core\Helper\Type\Obj;

class Profile extends AdminAppController
{
    const ITEM_PER_PAGE = 10;

    // profile list
    public function actionIndex()

This method seems to be duplicated in your project.

    {
        // init Active Record
        $query = new ProfileRecords();

        // set current page and offset
        $page = (int)App::$Request->query->get('page');
        $offset = $page * self::ITEM_PER_PAGE;

        // build pagination
        $pagination = new SimplePagination([
            'url' => ['profile/index'],
            'page' => $page,
            'step' => self::ITEM_PER_PAGE,
            'total' => $query->count()

The method count does not exist on object<Apps\ActiveRecord\Profile>? Since you implemented __call, maybe consider adding a @method annotation.

        ]);

        // build listing objects
        $records = $query->orderBy('id', 'desc')->skip($offset)->take(self::ITEM_PER_PAGE)->get();

The method orderBy does not exist on object<Apps\ActiveRecord\Profile>? Since you implemented __call, maybe consider adding a @method annotation.

        // display viewer
        $this->response = App::$View->render('index', [
            'records' => $records,
            'pagination' => $pagination
        ]);
    }

    // redirect delete action to user controller
    public function actionDelete($id)
    {
        App::$Response->redirect('user/delete/' . $id);
    }

    /**
     * Profile edit action
     * @param int $id
     * @throws NotFoundException
     */
    public function actionUpdate($id)
    {
        if (!Obj::isLikeInt($id) || $id < 1) {
            throw new NotFoundException();
        }

        // get user profile via id
        $profile = ProfileRecords::find($id);
        if (false === $profile || null === $profile) {
            throw new NotFoundException();
        }

        // check if user id for this profile_id is exist
        if (!App::$User->isExist($profile->user_id)) {
            throw new NotFoundException();
        }

        // get user object from profile
        $user = $profile->User();
        $model = new FrontFormSettings($user);

        if ($model->send() && $model->validate()) {
            $model->save();
            App::$Session->getFlashBag()->add('success', __('Profile is updated'));
        }

        $this->response = App::$View->render('update', [
            'model' => $model->export(),
            'user' => $user,
            'profile' => $profile
        ]);
    }

    /**
     * List additional fields
     */
    public function actionFieldlist()
    {
        $records = ProfileField::all();

        $this->response = App::$View->render('field_list', [
            'records' => $records
        ]);
    }

    /**
     * Add and edit additional fields data
     * @param $id
     */
    public function actionFieldupdate($id)

This method seems to be duplicated in your project.

    {
        // get current record or new and init form DI
        $record = ProfileField::findOrNew($id);
        $model = new FormFieldUpdate($record);

$record is of type object<Illuminate\Support\Collection>|object<Illuminate\Database\Eloquent\Model>, but the function expects a object<Apps\ActiveRecord\ProfileField>.

        $isNew = false;
        if ($record->id === null) {
            $isNew = true;
        }
        // check if form is submited
        if ($model->send() && $model->validate()) {
            $model->save();
            if (true === $isNew) {
                App::$Response->redirect('profile/fieldlist');
            }
            App::$Session->getFlashBag()->add('success', __('Profile field was successful updated'));
        }

        $this->response = App::$View->render('field_update', [
            'model' => $model->export()
        ]);
    }

    /**
     * Delete custom field action
     * @param int $id
     * @throws ForbiddenException
     */
    public function actionFielddelete($id)
    {
        if (!Obj::isLikeInt($id) || $id < 1) {
            throw new ForbiddenException();
        }

        // check if record with $id is exist
        $record = ProfileField::find($id);
        if ($record === null || $record === false) {
            throw new ForbiddenException();
        }

        $model = new FormFieldUpdate($record);

        // if delete is submited - lets remove this record
        if ($model->send()) {
            $model->delete();
            App::$Response->redirect('profile/fieldlist');
        }

        $this->response = App::$View->render('field_delete', [
            'model' => $model->export()
        ]);
    }

    public function actionSettings()

This method seems to be duplicated in your project.

    {
        $model = new FormSettings($this->getConfigs());

        if ($model->send()) {
            if ($model->validate()) {
                $this->setConfigs($model->getAllProperties());
                App::$Response->redirect('profile/index');
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        $this->response = App::$View->render('settings', [
            'model' => $model
        ]);
    }


}