Apps\Controller\Api\Profile\ActionMessageSend::messageSend()

Complexity

Conditions	8
Paths	5

Size

Total Lines	34
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function messageSend(string $targetId): ?string
    {
        if (!Any::isInt($targetId) || $targetId < 1) {
            throw new NativeException('Bad target id format');
        }

        // check if user is auth
        if (!App::$User->isAuth()) {
            throw new ForbiddenException('Auth required');
        }

        // get current user object and check in blacklist
        $user = App::$User->identity();
        if (!Blacklist::check($user->id, $targetId)) {
            throw new ForbiddenException('In blacklist');
        }

        // check input params
        $msg = App::$Security->strip_tags($this->request->get('message'));
        if (!Any::isInt($targetId) || $targetId < 1 || Str::length($msg) < 1) {

It seems like $msg defined by \Ffcms\Core\App::$Security->strip_tags($this->request->get('message')) on line 51 can also be of type array; however, Ffcms\Core\Helper\Type\Str::length() does only seem to accept string, maybe add an additional type check?

            throw new NativeException('Wrong input data');
        }

        $this->setJsonHeader();

It seems like setJsonHeader() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        // try to save message
        $message = new Message();
        $message->target_id = $targetId;
        $message->sender_id = $user->id;
        $message->message = $msg;
        $message->save();

        return json_encode(['status' => 1]);
    }
}