phpffcms /
ffcms
| Conditions | 13 |
| Paths | 85 |
| Total Lines | 70 |
| Code Lines | 40 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 31 | public function listMessageDialog($offset = 0, $new = 0): ?string |
||
| 32 | { |
||
| 33 | // check is user auth |
||
| 34 | if (!App::$User->isAuth()) { |
||
| 35 | throw new ForbiddenException('Auth required'); |
||
| 36 | } |
||
| 37 | $this->setJsonHeader(); |
||
|
|
|||
| 38 | |||
| 39 | // check is offset is int |
||
| 40 | if ($offset !== 0 && !Any::isInt($offset)) { |
||
| 41 | $offset = 0; |
||
| 42 | } |
||
| 43 | ++$offset; |
||
| 44 | |||
| 45 | // get user person |
||
| 46 | $user = App::$User->identity(); |
||
| 47 | |||
| 48 | $records = Message::select('readed', 'target_id', 'sender_id', Capsule::raw('max(created_at) as cmax')) |
||
| 49 | ->where('target_id', '=', $user->id) |
||
| 50 | ->orWhere('sender_id', '=', $user->id) |
||
| 51 | ->orderBy('readed', 'ASC') //- error happens, cuz readed is boolean in pgsql |
||
| 52 | ->orderBy('cmax', 'DESC') |
||
| 53 | ->groupBy(['sender_id', 'target_id', 'readed']) // multiple order's can throw exception on some kind of database engines |
||
| 54 | ->take($offset * self::MSG_USER_LIST) |
||
| 55 | ->get(); |
||
| 56 | |||
| 57 | $userList = []; |
||
| 58 | $unreadList = []; |
||
| 59 | |||
| 60 | if (Any::isInt($new) && $new > 0 && App::$User->isExist($new)) { |
||
| 61 | $userList[] = $new; |
||
| 62 | } |
||
| 63 | |||
| 64 | // there is 2 way of messages: me->user; user->me, try to parse it |
||
| 65 | foreach ($records as $row) { |
||
| 66 | // target is not myself? then i'm - sender (remote user is target: my->to_user) |
||
| 67 | if ($row->target_id !== $user->id) { |
||
| 68 | $userList[] = $row->target_id; |
||
| 69 | } |
||
| 70 | |||
| 71 | // sender is not myself? then i'm - target (remote user is sender user->to_me) |
||
| 72 | if ($row->sender_id !== $user->id) { |
||
| 73 | $userList[] = $row->sender_id; |
||
| 74 | if ((bool)$row->readed !== true) { |
||
| 75 | $unreadList[] = $row->sender_id; |
||
| 76 | } |
||
| 77 | } |
||
| 78 | } |
||
| 79 | |||
| 80 | // store only unique users in dialog |
||
| 81 | $userList = array_unique($userList, SORT_NUMERIC); |
||
| 82 | // generate json response based on userList and unreadList |
||
| 83 | $response = []; |
||
| 84 | foreach ($userList as $user_id) { |
||
| 85 | $identity = App::$User->identity($user_id); |
||
| 86 | if (null === $identity) { |
||
| 87 | continue; |
||
| 88 | } |
||
| 89 | |||
| 90 | $response[] = [ |
||
| 91 | 'user_id' => $user_id, |
||
| 92 | 'user_nick' => $identity->profile->getNickname(), |
||
| 93 | 'user_avatar' => $identity->profile->getAvatarUrl('small'), |
||
| 94 | 'message_new' => Arr::in($user_id, $unreadList), |
||
| 95 | 'user_block' => !Blacklist::check($user->id, $identity->id) |
||
| 96 | ]; |
||
| 97 | } |
||
| 98 | |||
| 99 | return json_encode(['status' => 1, 'data' => $response]); |
||
| 100 | } |
||
| 101 | } |
||
| 102 |
This check looks for methods that are used by a trait but not required by it.
To illustrate, let’s look at the following code example
The trait
Idableprovides a methodequalsIdthat in turn relies on the methodgetId(). If this method does not exist on a class mixing in this trait, the method will fail.Adding the
getId()as an abstract method to the trait will make sure it is available.