Apps\Controller\Api\Profile\ActionMessageList

Complexity

Total Complexity

13

Size/Duplication

Total Lines	108
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
D	messageList()	0	97	13

<?php

namespace Apps\Controller\Api\Profile;

use Apps\ActiveRecord\Blacklist;
use Apps\ActiveRecord\Message;
use Ffcms\Core\App;
use Ffcms\Core\Exception\ForbiddenException;
use Ffcms\Core\Exception\NativeException;
use Ffcms\Core\Exception\NotFoundException;
use Ffcms\Core\Helper\Date;
use Ffcms\Core\Helper\Type\Any;
use Ffcms\Core\Helper\Type\Arr;
use Ffcms\Core\Network\Request;
use Ffcms\Core\Network\Response;

/**
 * Class ActionMessageList
 * @package Apps\Controller\Api\Profile
 * @property Request $request
 * @property Response $response
 * @method void setJsonHeader
 */
trait ActionMessageList
{
    /**
     * List messages with correspondent
     * @param $corId
     * @return string
     * @throws ForbiddenException
     * @throws NotFoundException
     * @throws NativeException
     */
    public function messageList($corId): ?string
    {
        if (!App::$User->isAuth()) {
            throw new ForbiddenException('Auth required');
        }

        if (!Any::isInt($corId) || $corId < 1) {
            throw new NotFoundException('Corresponded id is wrong');
        }

        // get special types for this action
        $queryType = $this->request->get('type');
        $queryId = (int)$this->request->get('id');
        // get current user object
        $user = App::$User->identity();

        if (Arr::in($queryType, ['before', 'after']) && (!Any::isInt($queryId) || $queryId < 1)) {
            throw new NativeException('Bad input data');
        }

        $messages = null;

$messages is not used, you could remove the assignment.

        // sounds like a Hindi code, but we need more closures to organize where conditions
        // after raw: select * from `ffcms_messages` where `id` > ? and ((`target_id` = ? and `sender_id` = ?) or (`target_id` = ? and `sender_id` = ?)) order by `created_at` desc

37% of this comment could be valid code. Did you maybe forget this after debugging?

        // before raw: select * from `ffcms_messages` where (`target_id` = ? and `sender_id` = ?) or (`target_id` = ? and `sender_id` = ?) order by `created_at` desc
        // default raw: select * from `ffcms_messages` where `id` < ? and ((`target_id` = ? and `sender_id` = ?) or (`target_id` = ? and `sender_id` = ?)) order by `created_at` desc

38% of this comment could be valid code. Did you maybe forget this after debugging?

        switch ($queryType) {
            case 'after':

case statements should be defined using a colon.

                $messages = Message::where('id', '>', $queryId)
                    ->where(function ($query) use ($corId, $user) {
                        $query->where(function ($q) use ($cor_id, $user) {

The variable $cor_id does not exist. Did you forget to declare it?

                            $q->where('target_id', '=', $user->getId())
                                ->where('sender_id', '=', $cor_id);
                        })->orWhere(function ($q) use ($cor_id, $user) {
                            $q->where('target_id', '=', $cor_id)
                                ->where('sender_id', '=', $user->getId());
                        });
                    });
                break;
            case 'before':
                $messages = Message::where('id', '<', $queryId)
                    ->where(function ($query) use ($corId, $user) {
                        $query->where(function ($q) use ($cor_id, $user) {

The variable $cor_id does not exist. Did you forget to declare it?

                            $q->where('target_id', '=', $user->getId())
                                ->where('sender_id', '=', $cor_id);
                        })->orWhere(function ($q) use ($cor_id, $user) {
                            $q->where('target_id', '=', $cor_id)
                                ->where('sender_id', '=', $user->getId());
                        });
                    });
                break;
            default:
                $messages = Message::where(function ($query) use ($corId, $user) {
                    $query->where('target_id', '=', $user->getId())
                        ->where('sender_id', '=', $corId);
                })->orWhere(function ($query) use ($corId, $user) {
                    $query->where('target_id', '=', $corId)
                        ->where('sender_id', '=', $user->getId());
                });
                break;
        }

        // set response header
        $this->setJsonHeader();

It seems like setJsonHeader() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $messages->orderBy('created_at', 'DESC')
            ->take(self::MSG_TEXT_LIST);

        // check if messages exist
        if ($messages->count() < 1) {
            return json_encode(['status' => 0, 'text' => 'No messages']);
        }

        // build response
        $response = null;
        foreach ($messages->get() as $msg) {
            /** @var Message $msg */
            $response[] = [
                'id' => $msg->id,
                'my' => $msg->sender_id === $user->id,
                'message' => $msg->message,
                'date' => Date::convertToDatetime($msg->created_at, Date::FORMAT_TO_SECONDS),
                'readed' => $msg->readed
            ];

            // update status to readed
            if ((bool)$msg->readed !== true && $msg->sender_id !== $user->id) {
                $msg->readed = true;
                $msg->save();
            }
        }

        return json_encode([
            'status' => 1,
            'data' => array_reverse($response),
            'blocked' => !Blacklist::check($user->id, $corId)
        ]);
    }
}