Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
21 | class ProfileField extends ActiveModel |
||
22 | { |
||
23 | |||
24 | /** |
||
25 | * Get all table data using memory cache |
||
26 | * @param array $columns |
||
27 | * @return \Illuminate\Database\Eloquent\Collection|mixed|static[] |
||
28 | */ |
||
29 | View Code Duplication | public static function all($columns = ['*']) |
|
40 | |||
41 | /** |
||
42 | * @deprecated |
||
43 | * @return \Illuminate\Database\Eloquent\Collection|mixed|static[] |
||
44 | */ |
||
45 | public static function getAll() |
||
49 | |||
50 | /** |
||
51 | * Get field name locale by field id |
||
52 | * @param int $id |
||
53 | * @return array|null|string |
||
54 | */ |
||
55 | public static function getNameById($id) |
||
66 | |||
67 | /** |
||
68 | * Get field type by field id |
||
69 | * @param int $id |
||
70 | * @return array|null|string |
||
71 | */ |
||
72 | public static function getTypeById($id) |
||
83 | |||
84 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.