Apps\Model\Front\Feedback\FormFeedbackAdd

Complexity

Total Complexity

10

Size/Duplication

Total Lines	118
Duplicated Lines	7.63 %

Coupling/Cohesion

Components	2
Dependencies	13

Importance

Changes	2
Bugs	1	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	before()	0	8	2
A	labels()	9	9	1
A	rules()	0	14	2
B	make()	0	24	2
A	sendEmail()	0	18	1
A	getHash()	0	4	1

<?php

namespace Apps\Model\Front\Feedback;

use Apps\ActiveRecord\FeedbackPost;
use Ffcms\Core\App;
use Ffcms\Core\Arch\Model;
use Ffcms\Core\Helper\Type\Str;

class FormFeedbackAdd extends Model
{
    public $name;
    public $email;
    public $captcha;
    public $message;

    private $_hash;

    private $_useCaptcha = true;

    public function __construct($captcha = true)
    {
        $this->_useCaptcha = (bool)$captcha;
        parent::__construct();
    }


    /**
    * Set user data if he is logged in
    */
    public function before()
    {
        if (App::$User->isAuth()) {
            $data = App::$User->identity();
            $this->name = $data->getProfile()->nick;
            $this->email = $data->email;

Accessing email on the interface Ffcms\Core\Interfaces\iUser suggest that you code against a concrete implementation. How about adding an instanceof check?

        }
    }

    /**
    * Labels to display form
    */
    public function labels()

This method seems to be duplicated in your project.

    {
        return [
            'name' => __('Name'),
            'email' => __('Email'),
            'message' => __('Message'),
            'captcha' => __('Captcha')
        ];
    }

    /**
    * Rules to validate send form
    */
    public function rules()
    {
        $rules = [
            [['name', 'email', 'message'], 'required'],
            ['name', 'length_min', '2'],
            ['message', 'length_min', 10],
            ['email', 'email'],
            ['captcha', 'used']
        ];
        if (true === $this->_useCaptcha) {
            $rules[] = ['captcha', 'App::$Captcha::validate'];
        }
        return $rules;
    }

    public function make()
    {
        // calculate security hash to direct-on access
        $hash = Str::randomLatinNumeric(mt_rand(16, 64));

        // init new row and set row data
        $record = new FeedbackPost();
        $record->name = App::$Security->strip_tags($this->name);
        $record->email = App::$Security->strip_tags($this->email);
        $record->message = App::$Security->strip_tags($this->message);
        $record->hash = $hash;
        if (App::$User->isAuth()) {
            $record->user_id = App::$User->identity()->getId();
        }

        $record->ip = App::$Request->getClientIp();
        // save row to db
        $record->save();

        // send notification to email
        $this->sendEmail($record);

        return $record;
    }

    /**
     * Send email notification after feedback request creation
     * @param $record
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    private function sendEmail($record)
    {
        // prepare email template
        $template = App::$View->render('feedback/mail/created', [
            'record' => $record
        ]);

        // get website default email
        $sender = App::$Properties->get('adminEmail');

        // build swift mailer handler
        $mailMessage = \Swift_Message::newInstance(App::$Translate->get('Feedback', 'Request #%id% is created', ['id' => $record->id]))
            ->setFrom([$sender])
            ->setTo([$record->email])
            ->setBody($template, 'text/html');
        // send message over swift instance
        App::$Mailer->send($mailMessage);
    }

    /**
     * @return string|null
     */
    public function getHash()
    {
        return $this->_hash;
    }
}