Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class FormSettings extends Model |
||
8 | { |
||
9 | public $count; |
||
10 | public $snippet; |
||
11 | public $cache; |
||
12 | |||
13 | private $_configs; |
||
14 | |||
15 | /** |
||
16 | * FormSettings constructor. Pass configs inside from controller |
||
17 | * @param array $configs |
||
18 | */ |
||
19 | public function __construct(array $configs) |
||
24 | |||
25 | /** |
||
26 | * Set default values from configs |
||
27 | */ |
||
28 | public function before() |
||
34 | |||
35 | /** |
||
36 | * Labels for form display |
||
37 | */ |
||
38 | public function labels() |
||
46 | |||
47 | /** |
||
48 | * Settings validation rules |
||
49 | */ |
||
50 | View Code Duplication | public function rules() |
|
57 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.