Test Failed
Push — master ( e3c39f...fe570d )
by Mihail
07:20
created

Apps/View/Front/default/user/signup.php (3 issues)

1
<?php
2
3
/** @var $notify array */
4
/** @var $useCaptcha bool */
5
/** @var $model \Apps\Model\Front\User\FormRegister */
6
/** @var \Ffcms\Templex\Template\Template $this */
7
8
$this->layout('_layouts/default', [
9
    'title' => __('Sign up')
10
])
11
?>
12
13
<?php $this->start('body') ?>
14
15
<h1><?= __('Sign up'); ?></h1>
16
<?= $this->insert('user/_menu/tabs') ?>
0 ignored issues
show
Are you sure the usage of $this->insert('user/_menu/tabs') targeting League\Plates\Template\Template::insert() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
17
18
<?php $form = $this->form($model) ?>
19
20
<?= $form->start() ?>
21
22
<?php // $this->insert('user/_menu/_social_panel') ?>
0 ignored issues
show
Unused Code Comprehensibility introduced by zenn
72% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
23
24
<?= $form->fieldset()->text('login', null, __('Enter your username for future use on the site')); ?>
25
<?= $form->fieldset()->text('email', null, __('Enter your e-mail for an account')); ?>
26
<?= $form->fieldset()->password('password', null, __('Enter a password for your account. It should be longer than 3 characters')); ?>
27
<?= $form->fieldset()->password('repassword', null, __('Repeat your password to be sure it correct')); ?>
28
29
<?= $this->insert('_core/form/fieldset/captcha', ['form' => $form]) ?>
30
31
<?= $form->button()->submit(__('Register!'), ['class' => 'btn btn-primary']) ?>
32
33
<?= $form->stop() ?>
34
35
<?= $this->stop() ?>
0 ignored issues
show
Are you sure the usage of $this->stop() targeting League\Plates\Template\Template::stop() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
36