Issues in settings.php - All Issues - Inspection of "Fix newcomments locale show" - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( e3c39f...fe570d )

by Mihail

created 2019-01-11 11:36 UTC

Apps/View/Admin/default/profile/settings.php (2 issues)

Labels

Bug 2

Severity

<?php

use Ffcms\Templex\Url\Url;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

/** @var Apps\Model\Admin\Profile\FormSettings $model */
/** @var \Ffcms\Templex\Template\Template $this */

$this->layout('_layouts/default', [
    'title' => __('Profile settings'),
    'breadcrumbs' => [
        Url::to('main/index') => __('Main'),
        Url::to('application/index') => __('Applications'),
        Url::to('profile/index') => __('Profile'),
        __('Settings')
    ]
]);
?>

<?php $this->start('body') ?>

<?= $this->insert('profile/_tabs') ?>
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
<h1><?= __('Profile settings') ?></h1>

<?php $form = $this->form($model) ?>

<?= $form->start() ?>

<?= $form->fieldset()->text('usersOnPage', null, __('How many users will be displayed per one list page?')) ?>
<?= $form->fieldset()->boolean('guestView', null, __('Allow guests view user profiles?')) ?>
<?= $form->fieldset()->text('wallPostOnPage', null,  __('How many wall posts must be displayed in one page of profile?')) ?>
<?= $form->fieldset()->text('wallPostOnFeed', null, __('How many wall posts must be displayed on one page of feed list?')) ?>
<?= $form->fieldset()->text('delayBetweenPost', null, __('Delay between 2 posts on wall from one user in seconds')) ?>
<?= $form->fieldset()->boolean('rating', null, __('Enable user rating system?')) ?>
<?= $form->fieldset()->text('ratingDelay', null, __('Delay in seconds between repeat change of rating from one user(model: one to one)')) ?>

<?= $form->button()->submit(__('Save'), ['class' => 'btn btn-primary']) ?>

<?= $form->stop() ?>

<?php $this->stop() ?>


1			<?php
2
3			use Ffcms\Templex\Url\Url;
			0 ignored issues – show Bug introduced 2018-11-23 12:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Url`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
4
5			/** @var Apps\Model\Admin\Profile\FormSettings $model */
6			/** @var \Ffcms\Templex\Template\Template $this */
7
8			$this->layout('_layouts/default', [
9			'title' => __('Profile settings'),
10			'breadcrumbs' => [
11			Url::to('main/index') => __('Main'),
12			Url::to('application/index') => __('Applications'),
13			Url::to('profile/index') => __('Profile'),
14			__('Settings')
15			]
16			]);
17			?>
18
19			<?php $this->start('body') ?>
20
21			<?= $this->insert('profile/_tabs') ?>
			0 ignored issues – show Bug introduced 2018-11-23 12:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->insert('profile/_tabs')` targeting `League\Plates\Template\Template::insert()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
22			<h1><?= __('Profile settings') ?></h1>
23
24			<?php $form = $this->form($model) ?>
25
26			<?= $form->start() ?>
27
28			<?= $form->fieldset()->text('usersOnPage', null, __('How many users will be displayed per one list page?')) ?>
29			<?= $form->fieldset()->boolean('guestView', null, __('Allow guests view user profiles?')) ?>
30			<?= $form->fieldset()->text('wallPostOnPage', null, __('How many wall posts must be displayed in one page of profile?')) ?>
31			<?= $form->fieldset()->text('wallPostOnFeed', null, __('How many wall posts must be displayed on one page of feed list?')) ?>
32			<?= $form->fieldset()->text('delayBetweenPost', null, __('Delay between 2 posts on wall from one user in seconds')) ?>
33			<?= $form->fieldset()->boolean('rating', null, __('Enable user rating system?')) ?>
34			<?= $form->fieldset()->text('ratingDelay', null, __('Delay in seconds between repeat change of rating from one user(model: one to one)')) ?>
35
36			<?= $form->button()->submit(__('Save'), ['class' => 'btn btn-primary']) ?>
37
38			<?= $form->stop() ?>
39
40			<?php $this->stop() ?>
41

phpffcms / ffcms

Push — master ( e3c39f...fe570d )

Apps/View/Admin/default/profile/settings.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like