for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
use Ffcms\Core\Helper\Date;
use Ffcms\Core\Helper\Type\Str;
use Ffcms\Templex\Url\Url;
/** @var \Apps\ActiveRecord\Profile[]|\Illuminate\Support\Collection $records */
/** @var array $pagination */
/** @var \Ffcms\Templex\Template\Template $this */
$this->layout('_layouts/default', [
'title' => __('Profile list'),
'breadcrumbs' => [
Url::to('main/index') => __('Main'),
Url::to('application/index') => __('Applications'),
__('Profile')
]
]);
?>
<?php $this->start('body') ?>
<?= $this->insert('profile/_tabs') ?>
$this->insert('profile/_tabs')
League\Plates\Template\Template::insert()
This check looks for function or method calls that always return null and whose return value is used.
class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) {
The method getObject() can return nothing but null, so it makes no sense to use the return value.
getObject()
The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.
<h1><?= __('Profile list') ?></h1>
$table = $this->table(['class' => 'table table-striped'])
->head([
['text' => '#'],
['text' => 'login'],
['text' => 'email'],
['text' => __('Nickname')],
['text' => __('Birthday')],
['text' => __('Rating')],
['text' => __('Actions'), 'properties' => ['class' => 'text-center']]
foreach ($records as $profile) {
$table->row([
['text' => $profile->id],
['text' => $profile->user->login],
['text' => $profile->user->email],
['text' => $profile->nick],
['text' => Str::startsWith('0000-', $profile->birthday) ? __('None') : Date::convertToDatetime($profile->birthday)],
['text' => ($profile->rating > 0 ? '+' : null) . $profile->rating],
['text' => $this->bootstrap()->btngroup(['class' => 'btn-group btn-group-sm'])
->add('<i class="fa fa-pencil"></i>', ['profile/update', [$profile->id]], ['html' => true, 'class' => 'btn btn-primary'])
->add('<i class="fa fa-trash-o"></i>', ['user/delete', [$profile->user->id]], ['html' => true, 'class' => 'btn btn-danger'])
->display(), 'html' => true, 'properties' => ['class' => 'text-center']]
}
<div class="table-responsive">
<?= $table->display() ?>
</div>
<?= $this->bootstrap()->pagination($pagination['url'], ['class' => 'pagination justify-content-center'])
->size($pagination['total'], $pagination['page'], $pagination['step'])
->display(); ?>
<?php $this->stop() ?>
phpffcms /
ffcms
zenn
This check looks for function or method calls that always return null and whose return value is used.
The method
getObject()can return nothing but null, so it makes no sense to use the return value.The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.