phpffcms / ffcms

Apps/Controller/Api/Comments/ActionAdd.php

<?php

namespace Apps\Controller\Api\Comments;

use Apps\ActiveRecord\App as AppRecord;
use Apps\Model\Api\Comments\CommentAnswerAdd;
use Apps\Model\Api\Comments\CommentPostAdd;
use Apps\Model\Api\Comments\EntityCommentData;
use Ffcms\Core\App;
use Ffcms\Core\Exception\NativeException;
use Ffcms\Core\Network\Request;
use Ffcms\Core\Network\Response;

/**
 * Trait ActionAdd
 * @package Apps\Controller\Api\Comments
 * @property Request $request
 * @property Response $response
 * @method void setJsonHeader()
 */
trait ActionAdd
{
    /**
     * Add comment or answer via ajax.
     * @return string
     * @throws NativeException
     * @throws \Ffcms\Core\Exception\JsonException
     */
    public function add(): ?string
    {
        $this->setJsonHeader();
        $configs = AppRecord::getConfigs('widget', 'Comments');

        $replayTo = (int)$this->request->request->get('replay-to');
        $model = null;
        // check if its a answer (comment answer type)
        if ($replayTo > 0) {
            $model = new CommentAnswerAdd($configs);

It seems like $configs can also be of type null and string; however, parameter $configs of Apps\Model\Api\Comments\CommentAnswerAdd::__construct() does only seem to accept array, maybe add an additional type check?

            $model->replayTo = $replayTo;
        } else { // sounds like new comment row
            $model = new CommentPostAdd($configs);

It seems like $configs can also be of type null and string; however, parameter $configs of Apps\Model\Api\Comments\CommentPostAdd::__construct() does only seem to accept array, maybe add an additional type check?

            $model->appName = App::$Security->strip_tags($this->request->request->get('app_name'));
            $model->appId = (int)$this->request->request->get('app_id');
        }

        // pass general comment params to model
        $model->message = App::$Security->secureHtml((string)$this->request->request->get('message'));
        $model->guestName = App::$Security->strip_tags($this->request->request->get('guest-name'));

        // check model conditions before add new row
        if (!$model|| !$model->check()) {
            throw new NativeException('Unknown error');
        }

        // add comment post or answer to database and get response active record row
        $record = $model->buildRecord();
        // pass row to entity builder model
        $response = new EntityCommentData($record);

        return json_encode([
            'status' => 1,
            'data' => $response->make() // build row to standard format
        ]);
    }
}