phpffcms / ffcms

Apps/Controller/Admin/User/ActionUpdate.php

<?php

namespace Apps\Controller\Admin\User;

use Apps\ActiveRecord\User as UserRecord;
use Apps\Model\Admin\User\FormUserUpdate;
use Ffcms\Core\App;
use Ffcms\Core\Arch\View;
use Ffcms\Core\Exception\SyntaxException;
use Ffcms\Core\Network\Request;
use Ffcms\Core\Network\Response;

/**
 * Trait ActionUpdate
 * @package Apps\Controller\Admin\User
 * @property Request $request
 * @property Response $response
 * @property View $view
 */
trait ActionUpdate
{
    /**
     * Edit user profile by id
     * @param string $id
     * @return string
     * @throws SyntaxException
     */
    public function update(?string $id = null): ?string
    {
        $user = UserRecord::findOrNew($id);
        // generate model data based on user object
        $model = new FormUserUpdate($user);

It seems like $user can also be of type null; however, parameter $user of Apps\Model\Admin\User\FormUserUpdate::__construct() does only seem to accept Ffcms\Core\Interfaces\iUser, maybe add an additional type check?

        // check is form is sended
        if ($model->send()) {
            if ($model->validate()) { // check validation
                $model->save();
                App::$Session->getFlashBag()->add('success', __('Data was successful updated'));
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render viewer
        return $this->view->render('user/user_update', [
            'model' => $model
        ]);
    }
}