phpffcms / ffcms

Apps/Controller/Admin/Feedback/ActionSettings.php

<?php

namespace Apps\Controller\Admin\Feedback;

use Apps\Model\Admin\Feedback\FormSettings;
use Ffcms\Core\App;
use Ffcms\Core\Arch\View;
use Ffcms\Core\Network\Request;
use Ffcms\Core\Network\Response;

/**
 * Trait ActionSettings
 * @package Apps\Controller\Admin\Feedback
 * @property Request $request
 * @property Response $response
 * @property View $view
 */
trait ActionSettings
{
    /**
     * @return string|null
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function settings(): ?string
    {
        // initialize model and pass configs
        $model = new FormSettings($this->getConfigs());

It seems like getConfigs() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        // check if form is submited to save data
        if ($model->send()) {
            // is validation passed?
            if ($model->validate()) {
                // save properties
                $this->setConfigs($model->getAllProperties());

Are you sure the usage of $model->getAllProperties() targeting Ffcms\Core\Arch\Model::getAllProperties() seems to always return null.

It seems like setConfigs() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                App::$Session->getFlashBag()->add('success', __('Settings is successful updated'));
                $this->response->redirect('feedback/index');
            } else {
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
            }
        }

        // render view
        return $this->view->render('feedback/settings', [
            'model' => $model
        ]);
    }
}