Test Failed
Push — master ( e3c39f...fe570d )
by Mihail
07:20
created

Apps/Controller/Admin/Comments/ActionSettings.php (1 issue)

Labels
1
<?php
2
3
namespace Apps\Controller\Admin\Comments;
4
5
use Apps\Model\Admin\Comments\FormSettings;
6
use Ffcms\Core\App;
7
use Ffcms\Core\Arch\View;
8
use Ffcms\Core\Network\Request;
9
use Ffcms\Core\Network\Response;
10
11
/**
12
 * Trait ActionSettings
13
 * @package Apps\Controller\Admin\Comments
14
 * @property Request $request
15
 * @property Response $response
16
 * @property View $view
17
 */
18
trait ActionSettings
19
{
20
    /**
21
     * Comment widget global settings
22
     * @return string
23
     * @throws \Ffcms\Core\Exception\SyntaxException
24
     */
25
    public function settings()
26
    {
27
        // initialize settings model
28
        $model = new FormSettings($this->getConfigs());
29
30
        // check if form is send
31
        if ($model->send()) {
32
            if ($model->validate()) {
33
                $this->setConfigs($model->getAllProperties());
0 ignored issues
show
Are you sure the usage of $model->getAllProperties() targeting Ffcms\Core\Arch\Model::getAllProperties() seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
34
                App::$Session->getFlashBag()->add('success', __('Settings is successful updated'));
35
                $this->response->redirect('comments/index');
36
            } else {
37
                App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
38
            }
39
        }
40
41
        // render view
42
        return $this->view->render('comments/settings', [
43
            'model' => $model
44
        ]);
45
    }
46
}
47