Apps\Model\Front\Search\SearchContent

Complexity

Total Complexity

6

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	1
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	2
B	getResult()	0	38	4

<?php


namespace Apps\Model\Front\Search;


use Apps\Model\Front\Search\Interfaces\SearchContainer;
use Ffcms\Core\App;
use Ffcms\Core\Arch\Model;
use Apps\ActiveRecord\Content;
use Ffcms\Core\Helper\Text;
use Ffcms\Core\Helper\Type\Str;

class SearchContent extends Model implements SearchContainer
{
    private $query;
    private $limit;

    /**
     * SearchContainer constructor. Pass string query inside
     * @param string $query
     * @param int $limit
     */
    public function __construct($query, $limit = 10)
    {
        $this->query = $query;
        $this->limit = (int)$limit;
        if ($this->limit < 1) {
            $this->limit = 1;
        }
        parent::__construct();
    }

    /**
     * Build search results
     * @return array[AbstractSearchResult]

The doc-type array[AbstractSearchResult] could not be parsed: Expected "]" at position 2, but found "AbstractSearchResult". (view supported doc-types)

     */
    public function getResult()
    {
        // relevant search by string query
        $records = Content::search($this->query)

The method search() does not exist on Apps\ActiveRecord\Content. Did you maybe mean getSearchQueriesForColumn()?

            ->take($this->limit)
            ->get();

        // check if result is not empty
        if ($records->count() < 1) {
            return [];
        }

        // build result items
        $result = [];
        foreach ($records as $item) {
            /** @var \Apps\ActiveRecord\Content $item */
            $title = $item->getLocaled('title');
            $text = App::$Security->strip_tags($item->getLocaled('text'));

It seems like $item->getLocaled('text') targeting Ffcms\Core\Arch\ActiveModel::getLocaled() can also be of type null; however, Ffcms\Core\Helper\Security::strip_tags() does only seem to accept string|array, maybe add an additional type check?

            $snippet = Text::snippet($text);

It seems like $text defined by \Ffcms\Core\App::$Security->strip_tags($item->getLocaled('text')) on line 55 can also be of type array; however, Ffcms\Core\Helper\Text::snippet() does only seem to accept string, maybe add an additional type check?

            // prevent empty items
            if (Str::likeEmpty($title)) {

It seems like $title defined by $item->getLocaled('title') on line 54 can also be of type array or string; however, Ffcms\Core\Helper\Type\Str::likeEmpty() does only seem to accept null, maybe add an additional type check?

                continue;
            }

            // initialize abstract response pattern
            $res = new AbstractSearchResult();
            $res->setTitle($title);

It seems like $title defined by $item->getLocaled('title') on line 54 can also be of type array or null; however, Apps\Model\Front\Search\AbstractSearchResult::setTitle() does only seem to accept string, maybe add an additional type check?

            $res->setSnippet($snippet);
            $res->setDate($item->created_at);

It seems like $item->created_at can also be of type boolean; however, Apps\Model\Front\Search\AbstractSearchResult::setDate() does only seem to accept string, maybe add an additional type check?

            $res->setRelevance((int)$item->relevance);

The property relevance does not exist on object<Apps\ActiveRecord\Content>. Since you implemented __get, maybe consider adding a @property annotation.

            $res->setUri('/content/read/' . $item->getPath());

            // accumulate response var
            $result[] = $res;
        }
        
        return $result;
    }
}